Spec change: https://github.com/w3c/csswg-drafts/issues/3000 WPT test updated: https://github.com/web-platform-tests/wpt/commit/2eaab8231e69a8b71af9b617aacd683e8711d17e As expected, the updated tests are failing after import. See issue 875412 .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e823b4fff113c9fd5707924adb70bbe2a3261c1 commit 1e823b4fff113c9fd5707924adb70bbe2a3261c1 Author: Stephen McGruer <smcgruer@chromium.org> Date: Wed Aug 29 19:05:50 2018 web-animations: Handle 'auto' as a composite value for keyframes Upstream the spec has changed from using 'null' to represent a missing composite value on keyframes to using 'auto'. Instead of changing our internal representations to use two different enums (i.e. CompositeOperator and CompositorOperationOrAuto), this CL just updates the conversion logic to treat 'auto' as the previous 'null' value, avoiding any change of internal logic. Spec change: https://github.com/w3c/csswg-drafts/issues/3000 Bug: 877967 Change-Id: I8a1c83799f4a538c0102875f6259ac337e9d0843 Reviewed-on: https://chromium-review.googlesource.com/1191205 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#587229} [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/WebKit/LayoutTests/external/wpt/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animatable/animate-expected.txt [delete] https://crrev.com/59b9c0bbe9eac3adbf636b0ebd29d32cbe8bf162/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/composite-expected.txt [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt [delete] https://crrev.com/59b9c0bbe9eac3adbf636b0ebd29d32cbe8bf162/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/setKeyframes-expected.txt [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/blink/renderer/bindings/core/v8/BUILD.gn [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/blink/renderer/core/animation/base_keyframe.idl [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/blink/renderer/core/animation/base_property_indexed_keyframe.idl [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/blink/renderer/core/animation/effect_input.cc [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/blink/renderer/core/animation/effect_model.cc [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/blink/renderer/core/animation/effect_model.h [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/blink/renderer/core/animation/element_animation.cc [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/blink/renderer/core/animation/keyframe.cc [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/blink/renderer/core/animation/keyframe.h [modify] https://crrev.com/1e823b4fff113c9fd5707924adb70bbe2a3261c1/third_party/blink/renderer/core/animation/keyframe_effect.cc
Comment 1 by majidvp@chromium.org
, Aug 27