New issue
Advanced search Search tips

Issue 877966 link

Starred by 1 user
Status: Fixed
Owner:
msarda@chromium.org
Closed: Sep 12
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Delete GaiaAuthFetcher::DeprecatedStartCookieForOAuthLoginTokenExchange

Project Member Reported by droger@chromium.org, Aug 27 
This function seems no longer used. There are still callsites in the code, but the associated UserMetricsAction (Signin_UseDeprecatedCookieToOAuth2TokenEndpoint) is never recorded on any platforms.

We should double check and remove the function and all its callsites.

Comment 1 by droger@chromium.org, Sep 6

Cc: -msarda@chromium.org
Owner: msarda@chromium.org

Comment 2 by msarda@chromium.org, Sep 7

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a

commit 64f860c0c3d7a4311b0b2ec69ab2b443ae80761a
Author: Mihai Sardarescu <msarda@chromium.org>
Date: Wed Sep 12 10:25:08 2018

Remove GaiaAuthFetcher::DeprecatedStartCookieForOAuthLoginTokenExchange

The programmatic_auth endpoint was deprecated server-side since the 2017 Q1.
The Chrome client side code was update to avoid using this endpoint. It
seems that we do not see any user actions recorded for
Signin_UseDeprecatedCookieToOAuth2TokenEndpoint. So the code to exchange
the Gaia cookies for a OAuth2 login token is dead.

This CL removes its usage from Chrome desktop and ChromeOS. Additional
clean-up is required for ChromeOS, but that should be tracked separately
by a ChromeOS engineer that understands well the ChromeOS login sequence
and the way policies are applied on ChromeOS.

Bug:  877966 
Change-Id: I02cef4aae06323022131b4ace3e80a9d045b9806
Reviewed-on: https://chromium-review.googlesource.com/1212962
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590636}
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/login/auth/chrome_login_performer.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/login/signin/oauth2_login_manager.h
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/login/signin/oauth2_token_fetcher.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/login/signin/oauth2_token_fetcher.h
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/policy/blocking_login_browsertest.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.h
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/policy/wildcard_login_checker.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/chromeos/policy/wildcard_login_checker.h
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/google_apis/gaia/fake_gaia.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/google_apis/gaia/gaia_auth_fetcher.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/google_apis/gaia/gaia_auth_fetcher.h
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/google_apis/gaia/gaia_auth_fetcher_unittest.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/google_apis/gaia/gaia_urls.cc
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/google_apis/gaia/gaia_urls.h
[modify] https://crrev.com/64f860c0c3d7a4311b0b2ec69ab2b443ae80761a/tools/traffic_annotation/summary/annotations.xml

Comment 4 by msarda@chromium.org, Sep 12

Status: Fixed (was: Started)
Remaining clean-up work for ChromeOS is tracked in http://crbug.com/882838
►

Sign in to add a comment