New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 877957 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Delete tools/android/roll/update_support_library.py and associated build files

Project Member Reported by wnwen@chromium.org, Aug 27

Issue description

This would avoid new devs thinking they need to update these old scripts too. We use android_deps exclusively for the support libraries and play services libraries now.
 
Cc: thakis@chromium.org
This includes files under build/secondary/android_tools
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f15ce0b7a64b912d3b2a83d7d42f7f0c974fad2

commit 2f15ce0b7a64b912d3b2a83d7d42f7f0c974fad2
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Sep 06 20:16:10 2018

Android: Remove unused files in build/secondary

Bug:  877957 
Change-Id: I49d47adfc4bec9e6f7b580e76b0204541a338d9c
Reviewed-on: https://chromium-review.googlesource.com/1211523
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589264}
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/apk_proguard.flags
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_auth_api_phone_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_auth_base_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_auth_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_base_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_basement_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_cast_framework_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_cast_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_fido_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_gcm_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_iid_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_location_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_tasks_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_vision_common_java.info
[delete] https://crrev.com/e5d293af4d696758a23193ba91d25a28003843ed/build/secondary/third_party/android_tools/google_play_services_vision_java.info

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/80bdd452c8ea9e17c863f36bc397ed7aa1c74c97

commit 80bdd452c8ea9e17c863f36bc397ed7aa1c74c97
Author: Peter Wen <wnwen@google.com>
Date: Thu Sep 06 21:03:41 2018

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/remoting/android/internal/+/5359bbccdf157176a23fb6a8ed68a5941753ee3f

commit 5359bbccdf157176a23fb6a8ed68a5941753ee3f
Author: Peter Wen <wnwen@google.com>
Date: Thu Sep 06 20:39:53 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/ba11264e097100878261f0c302ade15706240bd5

commit ba11264e097100878261f0c302ade15706240bd5
Author: Peter Wen <wnwen@google.com>
Date: Mon Sep 10 13:24:41 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6a3a5c9ff14cad7c305b43e53894cc0be059390

commit c6a3a5c9ff14cad7c305b43e53894cc0be059390
Author: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Sep 10 17:26:42 2018

Roll src-internal 77e18bee2225..ba11264e0971 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/77e18bee2225..ba11264e0971


Created with:
  gclient setdep -r src-internal@ba11264e0971

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:877957 
TBR=mmoss@chromium.org

Change-Id: I081be2dc6a956982f5c229f96377a0fb5cb344e9
Reviewed-on: https://chromium-review.googlesource.com/1216104
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589961}
[modify] https://crrev.com/c6a3a5c9ff14cad7c305b43e53894cc0be059390/DEPS

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a64e88eb84bda760555b372c180f0dd91d0d003

commit 6a64e88eb84bda760555b372c180f0dd91d0d003
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Sep 10 20:12:50 2018

Android: Replace android_tools with android_deps

Mechanical build change. Will TBR after review.

TBR=agrieve@chromium.org

Bug:  877957 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: If99deaf4070d7c327b2b8b253057aea3b7a80ca7
Reviewed-on: https://chromium-review.googlesource.com/1216853
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590036}
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/android_webview/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/android_webview/tools/automated_ui_tests/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/base/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/base/test/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/build/secondary/third_party/android_tools/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/chrome/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/chrome/android/webapk/libs/client/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/chrome/android/webapk/libs/runtime_library/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/chrome/browser/android/vr/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/chrome/test/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/chrome/test/android/cast_emulator/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/chromecast/browser/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/chromecast/media/cma/backend/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/chromecast/public/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/autofill/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/background_task_scheduler/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/bookmarks/common/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/cronet/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/download/public/background_service/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/download/public/common/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/feature_engagement/internal/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/feature_engagement/public/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/location/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/minidump_uploader/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/offline_items_collection/core/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/safe_browsing/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/signin/core/browser/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/sync/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/components/variations/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/content/public/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/device/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/device/gamepad/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/media/base/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/media/capture/video/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/net/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/remoting/android/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/remoting/android/client_java_tmpl.gni
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/services/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/third_party/android_media/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/third_party/android_swipe_refresh/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/third_party/custom_tabs_client/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/third_party/espresso/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/third_party/feed/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/third_party/robolectric/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/tools/android/audio_focus_grabber/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/tools/android/customtabs_benchmark/BUILD.gn
[modify] https://crrev.com/6a64e88eb84bda760555b372c180f0dd91d0d003/ui/android/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3f51cb7db6c1c8c58f96d5b57d1b9f1fdffe632

commit a3f51cb7db6c1c8c58f96d5b57d1b9f1fdffe632
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Sep 12 14:14:19 2018

Android: Remove build/secondary aliases for play

- Change remoting to use google_play_services_package rather than manual
  specification.

Mechanical change. Will TBR after review.

TBR=agrieve@chromium.org

Bug:  877957 
Change-Id: Ie85e0ad25105e31efb410e7376de598763f42d04
Reviewed-on: https://chromium-review.googlesource.com/1217502
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590663}
[modify] https://crrev.com/a3f51cb7db6c1c8c58f96d5b57d1b9f1fdffe632/build/config/android/config.gni
[modify] https://crrev.com/a3f51cb7db6c1c8c58f96d5b57d1b9f1fdffe632/build/secondary/third_party/android_tools/BUILD.gn
[modify] https://crrev.com/a3f51cb7db6c1c8c58f96d5b57d1b9f1fdffe632/remoting/android/BUILD.gn
[modify] https://crrev.com/a3f51cb7db6c1c8c58f96d5b57d1b9f1fdffe632/third_party/android_deps/BUILD.gn

Labels: DevX
Labels: QuickFix
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7899e08d3eafd91c8feba31e2a18b715f833675f

commit 7899e08d3eafd91c8feba31e2a18b715f833675f
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Jan 16 15:45:58 2019

Android: Remove build/android/play_services

We have already migrated upstream to third_party/android_deps so these
files and related buildsteps are no longer needed.

This CL also removes the [y/n] confirmation for the Play SDK.

Bug:  877957 , 868879 
Change-Id: I6bdb5355031a2d3a4a9a2f82531bd1956f288edd
Reviewed-on: https://chromium-review.googlesource.com/c/1394925
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623249}
[modify] https://crrev.com/7899e08d3eafd91c8feba31e2a18b715f833675f/DEPS
[modify] https://crrev.com/7899e08d3eafd91c8feba31e2a18b715f833675f/build/android/PRESUBMIT.py
[delete] https://crrev.com/ae5e5a5785d23ad6ca824b1ff399fe31b9060b77/build/android/play_services/LICENSE.sha1
[delete] https://crrev.com/ae5e5a5785d23ad6ca824b1ff399fe31b9060b77/build/android/play_services/config.json
[delete] https://crrev.com/ae5e5a5785d23ad6ca824b1ff399fe31b9060b77/build/android/play_services/google_play_services_library.zip.sha1
[delete] https://crrev.com/ae5e5a5785d23ad6ca824b1ff399fe31b9060b77/build/android/play_services/update.py
[delete] https://crrev.com/ae5e5a5785d23ad6ca824b1ff399fe31b9060b77/build/android/play_services/update_test.py
[delete] https://crrev.com/ae5e5a5785d23ad6ca824b1ff399fe31b9060b77/tools/android/roll/update_support_library.py

Comment 12 by wnwen@google.com, Jan 16 (6 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment