Issue 877948 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	finnur@chromium.org
Closed:	Aug 29
Cc:	peter@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	3
Type:	Bug

Photo Picker should use singular in title when in single-selection mode

Project Member Reported by finnur@chromium.org, Aug 27

Issue description

When the PhotoPicker on Android is shown by a website that expects a single photo, the title of the dialog should not show "Select images", as it is misleading (and you can't select more than one).

Not an urgent fix, but I hear it can smooth some wrinkles in some relationship quarters...

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21e2a0aa71d826d52c304ae83e8a321b06a4e842

commit 21e2a0aa71d826d52c304ae83e8a321b06a4e842
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Tue Aug 28 17:59:51 2018

Photo Picker: use 'Select image' instead of *images* when single-selecting.

Bug:  877948 ,  656015 
Change-Id: Ifc19e9a8566094adccf39ef953d909e7b5218dd8
Reviewed-on: https://chromium-review.googlesource.com/1190023
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586780}
[modify] https://crrev.com/21e2a0aa71d826d52c304ae83e8a321b06a4e842/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PhotoPickerDialog.java
[modify] https://crrev.com/21e2a0aa71d826d52c304ae83e8a321b06a4e842/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java
[modify] https://crrev.com/21e2a0aa71d826d52c304ae83e8a321b06a4e842/chrome/android/java/strings/android_chrome_strings.grd
[add] https://crrev.com/21e2a0aa71d826d52c304ae83e8a321b06a4e842/chrome/android/java/strings/android_chrome_strings_grd/IDS_PHOTO_PICKER_SELECT_IMAGE.png.sha1
[add] https://crrev.com/21e2a0aa71d826d52c304ae83e8a321b06a4e842/chrome/android/java/strings/android_chrome_strings_grd/IDS_PHOTO_PICKER_SELECT_IMAGES.png.sha1

Comment 2 by finnur@chromium.org, Aug 29

Status: Fixed (was: Started)

►

Issue 877948 link

Issue metadata

Photo Picker should use singular in title when in single-selection mode

Issue description

Comment 1 by bugdroid1@chromium.org, Aug 28

Comment 1 Deleted

Comment 2 by finnur@chromium.org, Aug 29

Comment 2 Deleted

Sign in to add a comment