vertical-align is inherited to anonymous inline boxes |
|
Issue descriptionIn the following HTML, the 'vertical-align' should not apply to "x", because "x" is wrapped in an anonymous inline boxes as per: https://drafts.csswg.org/css2/visuren.html#anonymous <body> <span style="vertical-align: top"> <span style="font-size: 500%">A</span> x </span> </body>
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/736345b4bf29bd8121985bf07c056810fda4aaf6 commit 736345b4bf29bd8121985bf07c056810fda4aaf6 Author: Koji Ishii <kojii@chromium.org> Date: Mon Aug 27 14:58:16 2018 Fix fast/table/column-in-inline.html not to rely on wrong behavior fast/table/column-in-inline.html says it tests "a table-column with a table-cell sibling are wrapped inside an inline-table when the parent is inline" but it also tests: 1. Anonymous inline box inherits non-inherited properties, which contradicts with the spec (crbug.com/877946). 2. If the above was fixed, it tests baseline alignment of inline tables. LayoutNG fails because it does not have crbug.com/877946. This patch changes the test to focus on what it says, and creates a separate test for crbug.com/869877 . Bug: 869877 , 877946 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0b53ec68d5ea59a93010d49891d6bfe3a6688158 Reviewed-on: https://chromium-review.googlesource.com/1179736 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#586261} [modify] https://crrev.com/736345b4bf29bd8121985bf07c056810fda4aaf6/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/736345b4bf29bd8121985bf07c056810fda4aaf6/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/736345b4bf29bd8121985bf07c056810fda4aaf6/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/linebox/anonymous-inline-inherit-001-ref.html [add] https://crrev.com/736345b4bf29bd8121985bf07c056810fda4aaf6/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/linebox/anonymous-inline-inherit-001.html [modify] https://crrev.com/736345b4bf29bd8121985bf07c056810fda4aaf6/third_party/WebKit/LayoutTests/fast/table/column-in-inline-expected.html [modify] https://crrev.com/736345b4bf29bd8121985bf07c056810fda4aaf6/third_party/WebKit/LayoutTests/fast/table/column-in-inline.html |
|
►
Sign in to add a comment |
|
Comment 1 by kojii@chromium.org
, Aug 27