gclient setdep incorrect execution
Reported by
wangqing...@loongson.cn,
Aug 27
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3189.0 Safari/537.36 Steps to reproduce the problem: 1. gclient setdep --var checkout_nacl=False What is the expected behavior? Modify the value of checkout_nacl to 'False' What went wrong? The value of checkout_nacl become to 'TFalseT' Did this work before? N/A Chrome version: 62.0.3189.0 Channel: n/a OS Version: OS X 10.13.2 Flash Version:
,
Aug 27
,
Aug 27
,
Aug 27
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/5cc2afd9b8fae7e6f2d0f0c07abf14a2a2916ee7 commit 5cc2afd9b8fae7e6f2d0f0c07abf14a2a2916ee7 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Tue Aug 28 00:54:45 2018 gclient_eval: Handle non-string variables. Bug: 877902 Change-Id: I77a1f213318d1e09ae050c2ea0113b2976bd259e Reviewed-on: https://chromium-review.googlesource.com/1191928 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/5cc2afd9b8fae7e6f2d0f0c07abf14a2a2916ee7/gclient_eval.py [modify] https://crrev.com/5cc2afd9b8fae7e6f2d0f0c07abf14a2a2916ee7/tests/gclient_eval_unittest.py
,
Aug 28
Should be fixed. Please reopen if not.
,
Aug 28
Thanks for comment #5, it's ok now!
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d01cd9ca2edaae6fde4a54251aa6843bb8059ee7 commit d01cd9ca2edaae6fde4a54251aa6843bb8059ee7 Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Aug 28 02:02:15 2018 Roll src/third_party/depot_tools 2d0e03cb5ddc..5cc2afd9b8fa (3 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2d0e03cb5ddc..5cc2afd9b8fa git log 2d0e03cb5ddc..5cc2afd9b8fa --date=short --no-merges --format='%ad %ae %s' 2018-08-28 ehmaldonado@chromium.org gclient_eval: Handle non-string variables. 2018-08-28 tandrii@chromium.org git cl patch: cleanup tests. 2018-08-27 tandrii@chromium.org git cl: use project~number on Gerrit for GetChangeCommit. Created with: gclient setdep -r src/third_party/depot_tools@5cc2afd9b8fa The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:877902 ,chromium:719954,chromium:876910 TBR=agable@chromium.org Change-Id: Icef56dd47e11f7a3089fe2ad0549d7655cebdddd Reviewed-on: https://chromium-review.googlesource.com/1192254 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586541} [modify] https://crrev.com/d01cd9ca2edaae6fde4a54251aa6843bb8059ee7/DEPS |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by susan.boorgula@chromium.org
, Aug 27