New issue
Advanced search Search tips

Issue 877896 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Focus is lost after pressing 'Tab' key in chrome://settings/content/cookies.

Reported by rp...@etouch.net, Aug 27

Issue description

Chrome version :70.0.3534.0 (Official Build)Revision 68a5d485789e45a91c9fa90aab4dd33113131ccd-refs/branch-heads/3534@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10),Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS)  OS

Steps to reproduce:
1. Launch chrome and navigate to chrome://settings/content/cookies
2. Click on 'Add' button and add a site.
3. Now press 'Tab' key and observe focus

Actual Result: Focus is lost after pressing 'Tab' key
Expected Result: Focus should be seen on next object after pressing 'Tab' key.

This is a regression issue broken in ‘M-70’ and below is bisect info.
Good build: 70.0.3530.0 (Revision: 584942).
Bad build: 70.0.3531.0  (Revision: 585560).

You are probably looking for a change made after 585391 (known good), but no later than 585393 (first known bad).

Narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/bf31bedf12761be9d4e56500559f2777cbcbeedd..508ebd69e877434b4966b33a702fe389566244d7?pretty=fuller&n=50	

Suspect: https://chromium.googlesource.com/chromium/src/+/508ebd69e877434b4966b33a702fe389566244d7 from Narrow bisect

@aee: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You
 
Actual_video.mp4
329 KB View Download
Expected_video.mp4
209 KB View Download
Note : Unable to provide bisect using hasbisect-per-revision as we are getting error hence, providing narrow bisect.
Status: Started (was: Assigned)
cr-policy-pref-indicator is grabbing focus when it is not enforced and shows no icon. Need to prevent that from happening.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9c9e660008325bf580a7163c5bebf08e2eaaea1

commit d9c9e660008325bf580a7163c5bebf08e2eaaea1
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Aug 30 17:52:03 2018

Site Settings WebUI: hide policy pref indicator when not enforced

Bug:  877896 
Change-Id: I008e41233bf9378370b592425e5a928a0b97301f
Reviewed-on: https://chromium-review.googlesource.com/1195745
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587651}
[modify] https://crrev.com/d9c9e660008325bf580a7163c5bebf08e2eaaea1/chrome/browser/resources/settings/site_settings/site_list_entry.html
[modify] https://crrev.com/d9c9e660008325bf580a7163c5bebf08e2eaaea1/chrome/browser/resources/settings/site_settings/site_list_entry.js

Labels: TE-Verified-M70 TE-Verified-70.0.3538.0
Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS) and Mac OS X(10.12.6,10.13.1,10.13.6)OS with latest Canary Chrome version : 70.0.3538.0 and the issue is Fixed.Hence adding TE Verified Label.

Kindly refer the attached screen cast for reference.
Fixed_video.mp4
342 KB View Download
Status: Fixed (was: Started)

Sign in to add a comment