AppWindowApiTest.Get#testGetAllMultipleWindows fails (reliably) on Windows 10 [only?] |
|||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of tapted@google.com browser_tests failing on chromium.win/Win10 Tests x64 Builders failed on: - Win10 Tests x64: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64
,
Aug 27
,
Aug 27
,
Aug 27
,
Aug 27
https://chromium-review.googlesource.com/c/chromium/src/+/1188736
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9a9af50f975f4cc520c05df41353ac5cbc03397 commit d9a9af50f975f4cc520c05df41353ac5cbc03397 Author: Trent Apted <tapted@chromium.org> Date: Mon Aug 27 07:34:43 2018 Fix AppWindowApiTest.Get#testGetAllMultipleWindows properly Its comparator was rubbish and always has been. Array.prototype.sort() takes a function that should return {-1, 0, 1}, not bool. TBR=benwells@chromium.org Bug: 877890 Change-Id: I65162d2b261ad4ff91a028bf62c0cdcfb765df27 Reviewed-on: https://chromium-review.googlesource.com/1188736 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#586206} [modify] https://crrev.com/d9a9af50f975f4cc520c05df41353ac5cbc03397/chrome/test/data/extensions/platform_apps/windows_api_get/background.js
,
Aug 28
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tapted@chromium.org
, Aug 27Components: Platform>Apps>Container
Labels: OS-Windows
Summary: AppWindowApiTest.Get#testGetAllMultipleWindows fails (reliably) on Windows 10 [only?] (was: browser_tests failing on chromium.win/Win10 Tests x64)