New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 877880 link

Starred by 1 user
Status: Fixed
Owner:
alancutter@chromium.org
Closed: Aug 27
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Desktop PWAs: App menu button misaligned on Windows 7

Project Member Reported by alancutter@chromium.org, Aug 27 
Chrome Version: 70
OS: Windows 7

The hosted app menu button got shifted to the wrong place by https://chromium-review.googlesource.com/c/chromium/src/+/1183019.

Have WIP CL to fix: https://chromium-review.googlesource.com/c/chromium/src/+/1189247/1,edit
before-maximised.png
10.0 KB View Download
after-maximised.png
7.4 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab1b027ee7a5b6f1e4893410256bbcc40de97c5d

commit ab1b027ee7a5b6f1e4893410256bbcc40de97c5d
Author: Alan Cutter <alancutter@chromium.org>
Date: Mon Aug 27 09:09:36 2018

Fix hosted app menu button positioning on Windows 7

The position of the hosted app menu button was moved accidentally
by https://chromium-review.googlesource.com/c/chromium/src/+/1183019.
This CL fixes the incorrect y offset used for Windows 7.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354844&signed_aid=ABFeIzothXglSH0Jji074A==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354845&signed_aid=0q4hc-ELfn8qErN1FZ9KlQ==&inline=1

Bug:  877880 
Change-Id: Ie90a49df72dea040c3d7224b9dfd1ee6aaabf8c4
Reviewed-on: https://chromium-review.googlesource.com/1189247
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586215}
[modify] https://crrev.com/ab1b027ee7a5b6f1e4893410256bbcc40de97c5d/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc

Comment 2 by alancutter@chromium.org, Aug 27

Status: Fixed (was: Started)

Comment 3 by viswa.karala@chromium.org, Aug 28

Labels: Needs-Feedback
@Alan Cutter: Could you please provide sample Test file/URL that reproducing the issue and help us in verifying the fix.

Thanks!

Comment 4 by alancutter@chromium.org, Aug 28 

Sorry about the lack of instructions.
1. https://fast-lute.glitch.me/
2. Menu > Install Fast Lute
3. Observe app menu button in titlebar.
►

Sign in to add a comment