New issue
Advanced search Search tips

Issue 877870 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 10
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Issue a console warning when preloadResponse is not used.

Project Member Reported by falken@chromium.org, Aug 27

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06f028f7d66f9ff5bfad7289276f1d06c22762b8

commit 06f028f7d66f9ff5bfad7289276f1d06c22762b8
Author: Ting Shao <ting.shao@intel.com>
Date: Tue Sep 25 04:15:17 2018

[Service Worker] Add console message for aborted preload request

When a navigation preload request is aborted, no console message is
sent to the service worker. That's because the "unsanitized_message"
field of blink::WebServiceWorkerError is not set.

When Sending the message to console, prefer the unsanitized one if
avaiable. Update service worker browser test to cover this change.

Bug:  877870 
Test: content_browsertests  -gtest_filter=ServiceWorkerNavigationPreloadTest.CanceledByInterceptor
Change-Id: Icad28ce1a9feb40b729bc2504d9c9adb33593a0a
Reviewed-on: https://chromium-review.googlesource.com/1235376
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593823}
[modify] https://crrev.com/06f028f7d66f9ff5bfad7289276f1d06c22762b8/AUTHORS
[modify] https://crrev.com/06f028f7d66f9ff5bfad7289276f1d06c22762b8/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/06f028f7d66f9ff5bfad7289276f1d06c22762b8/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc

Status: Fixed (was: Available)
Thanks for the fix!

Sign in to add a comment