New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 877861 link

Starred by 2 users
Status: Fixed
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Closed: Aug 29
Cc:
thomasanderson@chromium.org
alancutter@chromium.org
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Linux PWAs: Enable custom window frame

Project Member Reported by mgiuca@chromium.org, Aug 27 
Currently we just use the normal Linux window frame (provided by the window manager). Need to draw our own custom window frame for PWAs, in order to show the origin and app menu button.

We'll just re-use the Windows 7 "opaque window frame", which is automatically styled "close enough" to a typical Linux window frame.

Comment 1 by mgiuca@chromium.org, Aug 27 

Attaching before and after screenshots.

Note: The "after" has several issues:

1. The origin and 3-dot menu are not vertically aligned properly.
2. The 3-dot menu is not clickable. ( Issue 877363 )

These will be solved in a later CL.
before.png
17.8 KB View Download
after.png
17.7 KB View Download

Comment 3 by thomasanderson@chromium.org, Aug 27

Cc: thomasanderson@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2208563c05caa553df260f34b9209a18b2347add

commit 2208563c05caa553df260f34b9209a18b2347add
Author: Matt Giuca <mgiuca@chromium.org>
Date: Tue Aug 28 01:47:47 2018

Enable custom window frame for PWAs and bookmark apps on Linux.

Bug:  877861 
Change-Id: I021faa5014e83c2a7ec992e59f22974fd9fdc51c
Reviewed-on: https://chromium-review.googlesource.com/1189685
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586537}
[modify] https://crrev.com/2208563c05caa553df260f34b9209a18b2347add/chrome/browser/ui/views/frame/desktop_browser_frame_aurax11.cc

Comment 5 by mgiuca@chromium.org, Aug 29

Status: Fixed (was: Started)

Comment 6 by viswa.karala@chromium.org, Aug 30

Labels: Needs-Feedback
@Matt Giuca: Could you please provide reproducible steps with excepted and actual behaviour which helps us in verifying the fix from TE end.

Thanks!

Comment 7 by mgiuca@chromium.org, Aug 31 

#6 Sorry.

1. Install a PWA (e.g., https://killer-marmot.appspot.com/web, then choose "Install Killer Marmot" from the Chrome menu).

See screenshots for before/after.

Comment 8 by viswa.karala@chromium.org, Sep 3

Labels: TE-Verified-71.0.3541.0 TE-Verified-M71
Able to reproduce the issue on chrome version# 70.0.3532.0 build without fix.
Verified the fix on Ubuntu 14.04 using Chrome version #71.0.3541.0 as per the comment #1 & 7
Attaching screen cast for reference.
Observed "The origin and 3-dot menu are vertically aligned properly and 3-dot menu is clickable"
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
877861.ogv
2.6 MB View Download
►

Sign in to add a comment