chromeos-base/authpolicy is failing UnitTest stage in ubsan builder |
||||||||
Issue descriptionAs the title says, chromeos-base/authpolicy is failing in the UnitTest stage of the ubsan builder. An example log can be found here: https://luci-logdog.appspot.com/v/?s=chromeos/buildbucket/cr-buildbucket.appspot.com/8937131194333835744/+/steps/UnitTest/0/stdout Most of the failures seem to be kinit failures, e.g. authpolicy-0.0.1-r1168: [0826/141029:ERROR:tgt_manager.cc(172)] kinit failed - bad password authpolicy-0.0.1-r1168: [0826/141029:ERROR:tgt_manager.cc(172)] kinit failed - bad password authpolicy-0.0.1-r1168: [0826/141030:ERROR:tgt_manager.cc(166)] kinit failed - bad user name Please fix this asap.
,
Aug 28
,
Aug 28
,
Aug 31
Hey, is there a way to repro locally?
,
Aug 31
Repro instructions: Create ubsan profile $ ./setup_board --board=amd64-generic --profile=ubsan Build authpolicy $ ./build_packages chromeos-base/authpolicy Run unit tests $ FEATURES=test emerge-amd64-generic chromeos-base/authpolicy
,
Sep 3
Thanks!
,
Sep 3
The failing tests just runs /bin/echo inside minijail. I'm trying from a command line: /sbin/minijail0 /bin/echo ==135917==WARNING: reading executable name failed with errno 2, some stack frames may not be symbolized ==135917==WARNING: reading executable name failed with errno 2, some stack frames may not be symbolized /usr/bin/coreutils: symbol lookup error: /lib64/libminijailpreload.so: undefined symbol: __ubsan_handle_type_mismatch_v1_abort Any idea how to fix it?
,
Sep 3
Is it possible to disable minijail when running tests under UBSan? Or maybe minijail lets the user to provide a list of exceptions that he still may access?
,
Sep 3
Yes, we already disable asan for minijail. Same should most likely be done for ubsan. I think, adding ubsan after asan to this file should fix this. https://cs.corp.google.com/chromeos_public/src/third_party/chromiumos-overlay/profiles/targets/chromeos/package.use.mask
,
Sep 4
this has already been done in Minijail (https://android-review.googlesource.com/c/platform/external/minijail/+/737175) we just need to roll Minijail in CrOS. Will upload a CL shortly.
,
Sep 4
Regarding #10, will it fix the symbol lookup error which is most likely caused by loading minijail library by an executable that was not built with ubsan. I am doubtful since the aosp CL does not touch build aspects of minijail.
,
Sep 4
Fair point, we need to do both.
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/66d2fa2593d44f9df9af6661ef3292d6b2105ab9 commit 66d2fa2593d44f9df9af6661ef3292d6b2105ab9 Author: Roman Sorokin <rsorokin@chromium.org> Date: Wed Sep 05 16:15:19 2018 authpolicy: Fix unit tests for UBSAN Seems like UBSAN image does not have 'grep' executable. Switched to 'cat'. BUG= chromium:877846 TEST=run tests locally with ubsan profile CQ-DEPEND=CL:1202183 Change-Id: Id08b27fe5ed35c18b842f29dcc344ac1fafb6a13 Reviewed-on: https://chromium-review.googlesource.com/1202089 Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/66d2fa2593d44f9df9af6661ef3292d6b2105ab9/authpolicy/process_executor_unittest.cc
,
Sep 6
,
Sep 6
,
Oct 1
Hi Roman, Please let me know if this bug requires any additional manual verification. I checked already steps from #5 and don't see such errors. Thanks, Ivan
,
Oct 2
Hi, this one should be ok w/o manual verification. Thanks! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rogerta@chromium.org
, Aug 27Owner: atwilson@chromium.org
Status: Assigned (was: Untriaged)