-> grt based on blame

summary: I suspect this has always been a flaky test - it just "always" succeeded on the up-to-3 retries. But when findit does --gtest_repeat=20, some failures now register with ~20% probability.



I can't find try-flakes for this - http://chromium-try-flakes.appspot.com/search?q=SafeBrowsingModuleVerifierWinTest.VerifyModuleModified

The suspect r586152 is a revert of r586063

There are some old DrMemory failures for these tests mentioned in  Issue 403073 

The findit chart actually shows the test going from a 0% pass rate to a flaky pass rate.

the non-flaky error is consistent with the CL description in https://chromium-review.googlesource.com/c/chromium/src/+/1189444


the flaky error is

[ RUN      ] SafeBrowsingModuleVerifierWinTest.VerifyModuleModified

../../chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc(220): error: Expected equality of these values:

  2

  num_bytes_different

    Which is: 1

Stack trace:

Backtrace:

	StackTraceGetter::CurrentStackTrace [0x02FA105A+90]

	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x02FB7AFA+74]

	testing::internal::AssertHelper::operator= [0x02FB760B+75]

	safe_browsing::SafeBrowsingModuleVerifierWinTest_VerifyModuleModified_Test::TestBody [0x02721708+3128]



[  FAILED  ] SafeBrowsingModuleVerifierWinTest.VerifyModuleModified (78 ms)

[1/1] SafeBrowsingModuleVerifierWinTest.VerifyModuleModified (78 ms)
1 test failed:
    SafeBrowsingModuleVerifierWinTest.VerifyModuleModified (../../chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc:190)

These are flaking in the waterfall too :/

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/71124

[ RUN      ] SafeBrowsingModuleVerifierWinTest.VerifyModuleExportModified
../../chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc(395): error: Expected equality of these values:
  3
  state.modification_size()
    Which is: 2
Stack trace:
Backtrace:
	StackTraceGetter::CurrentStackTrace [0x041C15CA+90]
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x041D806A+74]
	testing::internal::AssertHelper::operator= [0x041D7B7B+75]
	safe_browsing::SafeBrowsingModuleVerifierWinTest_VerifyModuleExportModified_Test::TestBody [0x0394754F+7679]
[  FAILED  ] SafeBrowsingModuleVerifierWinTest.VerifyModuleExportModified (0 ms)

+folks making safe-browsing changes recently

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af1529d9cd7bb61d462d5a55ccdc81e2316cd208

commit af1529d9cd7bb61d462d5a55ccdc81e2316cd208
Author: Trent Apted <tapted@chromium.org>
Date: Mon Aug 27 03:42:53 2018

Disable flaky SafeBrowsingModuleVerifierWinTest.VerifyModuleModified[Modified]

TBR=grt@chromium.org

Bug: 877815
Change-Id: Ie8145b1bce2354365fc0284374bef442e67cf10c
Reviewed-on: https://chromium-review.googlesource.com/1189510
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586186}
[modify] https://crrev.com/af1529d9cd7bb61d462d5a55ccdc81e2316cd208/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc

 Issue 877869  has been merged into this issue.

My changes were: [1] 6f1789c0af4860ec2dc6d5509173a2861e150deb and [2] 48a9c061e5cbb83200a50cbc4bc800c7529c9489.

[1] *should* only affect Android WebView (and I really doubt it has an effect on non-Android). It adds some resources to Chrome, which I expect are still built into Chrome. But the modified logic should only run on Android WebView.

[2] will affect all platforms, but this should only affect a debugging page (chrome://interstitials), and should have no appreciable effect on production or in unrelated tests.

So, without any familiarity with the disabled tests, I would guess my changes did not impact this. If someone has more familiarity, please let me know if I'm mistaken.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccd6f989bd90ad3f172a7d8a90ea2bfd782000ec

commit ccd6f989bd90ad3f172a7d8a90ea2bfd782000ec
Author: Greg Thompson <grt@chromium.org>
Date: Tue Sep 25 12:55:35 2018

Re-enable SafeBrowsingModuleVerifierWinTest.VerifyModuleModified[Modified] in non-debug builds.

They are only flaking in debug builds, so only disable them there.

BUG=877815
TBR=tapted@chromium.org

Change-Id: Id3e376881f3185fda3801cb2eaa13d5c7fc3b1a0
Reviewed-on: https://chromium-review.googlesource.com/1242946
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593903}
[modify] https://crrev.com/ccd6f989bd90ad3f172a7d8a90ea2bfd782000ec/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc