Addresses autofilled when autofill forms preference is disabled |
|||||||
Issue descriptionChrome Version: 70.0.3528.4 (Official Build) dev (64-bit) OS: Mac OS X 10.13.6 What steps will reproduce the problem? (1) Navigate to chrome://settings/autofill (2) Enable "Autofill forms" and "Save and fill addresses" (3) Add an address, filling in a name/email. (4) Disable "Autofill forms." Observe that the "Save and fill addresses" control is disabled in the UI, but is still in the on position. (5) Navigate to https://github.com/contact. Click on the name/email fields, observe that the autofilled name/email are offered as autofill completions. Since "Autofill forms" is disabled, my expectation is that address autofill should be disabled. If this behavior is intentional, and these two preference knobs are meant to be independent, then disabling the "Autofill forms" option should not disable the "Save and fill addresses" option.
,
Aug 28
I see this too on Canary. I have always had autofill disabled, but recent Canary versions have started collecting autofill information (any info, not just addresses) and syncing it. Looking at my sync data, the earliest autofill entry I can find dates was uploaded by Chrome 70.0.3525.5 on August 18th. I had upgraded that day from 70.0.3508.0. https://crbug.com/877955 can probably be merged into this bug.
,
Aug 29
Thanks for the reports! That seems not ideal indeed, I'm pretty sure that's not intended, especially if you've had autofill disabled in the past.
,
Aug 29
Thanks for reporting. Recent changes have unfortunately left the Autofill toggles in an inconstant state for Canary users. "Autofill forms" toggle is essentially a noop. That toggle is to be removed in the following days. Moving forward Autofill feature will be controlled via the two toggles, "Remember addresses and other information" and "Remember payment methods". We're also working on fixing the problem in #c2 by migrating the previous value of the Autofill toggle to the new toggles so if you have Autofill turned off it remains off.
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3061bdc4b480f5c5f4f91f3735b17178933b9ff commit c3061bdc4b480f5c5f4f91f3735b17178933b9ff Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Aug 30 16:25:32 2018 [AF] Migrate the value of kAutofillEnabledDeprecated to the new prefs Sets the value of the new Autofill prefs "once" to the value of the now deprecated Autofill master pref once all profile prefs are registered. This is required for those users who had Autofill disabled before introduction of the new prefs. Bug: 870328 , 877801 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iac4c1f7325c3a058b3d0fda0af0500a0ff23106a Reviewed-on: https://chromium-review.googlesource.com/1194598 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#587613} [modify] https://crrev.com/c3061bdc4b480f5c5f4f91f3735b17178933b9ff/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/c3061bdc4b480f5c5f4f91f3735b17178933b9ff/components/autofill/core/common/BUILD.gn [modify] https://crrev.com/c3061bdc4b480f5c5f4f91f3735b17178933b9ff/components/autofill/core/common/autofill_prefs.cc [modify] https://crrev.com/c3061bdc4b480f5c5f4f91f3735b17178933b9ff/components/autofill/core/common/autofill_prefs.h [add] https://crrev.com/c3061bdc4b480f5c5f4f91f3735b17178933b9ff/components/autofill/core/common/autofill_prefs_unittest.cc [modify] https://crrev.com/c3061bdc4b480f5c5f4f91f3735b17178933b9ff/ios/chrome/browser/prefs/browser_prefs.mm
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e8a67679cecb521eee5e76d59d43f8792d08897 commit 2e8a67679cecb521eee5e76d59d43f8792d08897 Author: sebsg <sebsg@chromium.org> Date: Fri Aug 31 20:26:35 2018 [AF] Clean up Autofill settings toggles. Remove the master toggle. Add sublabels for the profile and credit card toggles. Add row to inform users if an extention is managing the toggles. Change the title from "Addresses" to "Addresses and more". Bug: 860526 , 877801 Change-Id: I2d0d156108667d9463263f4e490761a506bf9a13 Reviewed-on: https://chromium-review.googlesource.com/1196924 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#588148} [modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/app/settings_strings.grdp [modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html [modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/test/data/extensions/api_test/settings_private/test.js [modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/test/data/webui/settings/autofill_section_test.js [modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/test/data/webui/settings/payments_section_test.js
,
Sep 4
,
Sep 5
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 19e310ee3fadb69e485b2cd51485e48f6287df85 was merged to refs/branch-heads/3538 branch with no merge approval from a TPM! Please explain why this change was merged to the branch!
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19e310ee3fadb69e485b2cd51485e48f6287df85 commit 19e310ee3fadb69e485b2cd51485e48f6287df85 Author: sebsg <sebsg@chromium.org> Date: Wed Sep 05 17:26:54 2018 Merge-70 [AF] Clean up Autofill settings toggles. Remove the master toggle. Add sublabels for the profile and credit card toggles. Add row to inform users if an extention is managing the toggles. Change the title from "Addresses" to "Addresses and more". TBR=sebsg@chromium.org (cherry picked from commit 2e8a67679cecb521eee5e76d59d43f8792d08897) Bug: 860526 , 877801 Change-Id: I2d0d156108667d9463263f4e490761a506bf9a13 Reviewed-on: https://chromium-review.googlesource.com/1196924 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588148} Reviewed-on: https://chromium-review.googlesource.com/1207215 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#53} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/app/settings_strings.grdp [modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html [modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/test/data/extensions/api_test/settings_private/test.js [modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/test/data/webui/settings/autofill_section_test.js [modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/test/data/webui/settings/payments_section_test.js
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c1b8f512b820a18bb1c0105f23e16257379d8f2 commit 6c1b8f512b820a18bb1c0105f23e16257379d8f2 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Fri Sep 07 17:32:44 2018 [AF] Fixes migration of the kAutofillEnabledDeprecated pref The migration was added for Android only by mistake (crrev.com/c/1194598) Bug: 870328 , 877801 Change-Id: Ie21b24ce67ef437dfa60755a5ec9ce03d5eb2661 Reviewed-on: https://chromium-review.googlesource.com/1213548 Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589565} [modify] https://crrev.com/6c1b8f512b820a18bb1c0105f23e16257379d8f2/chrome/browser/prefs/browser_prefs.cc
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ac1a4728115f93eb24928678b753a858259602e commit 5ac1a4728115f93eb24928678b753a858259602e Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Sep 11 14:47:08 2018 [AF] Fixes migration of the kAutofillEnabledDeprecated pref The migration was added for Android only by mistake (crrev.com/c/1194598) TBR=mahmadi@chromium.org (cherry picked from commit 6c1b8f512b820a18bb1c0105f23e16257379d8f2) Bug: 870328 , 877801 Change-Id: Ie21b24ce67ef437dfa60755a5ec9ce03d5eb2661 Reviewed-on: https://chromium-review.googlesource.com/1213548 Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589565} Reviewed-on: https://chromium-review.googlesource.com/1219776 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#270} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/5ac1a4728115f93eb24928678b753a858259602e/chrome/browser/prefs/browser_prefs.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by p...@myitcv.org.uk
, Aug 27