New issue
Advanced search Search tips

Issue 877785 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in cc::RestoreOp::Serialize

Project Member Reported by ClusterFuzz, Aug 25

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5742118707134464

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: UNKNOWN WRITE
Crash Address: 0x000147d38000
Crash State:
  cc::RestoreOp::Serialize
  cc::PaintOp::Serialize
  gpu::raster::PaintOpSerializer::Serialize
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=585071:585171

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5742118707134464

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 25

Components: Internals>Compositing Internals>GPU>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 26

Labels: Target-70 M-70
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 26

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 26

Labels: Pri-1
Cc: danakj@chromium.org vmp...@chromium.org
Owner: enne@chromium.org
Status: Assigned (was: Untriaged)
Likely caused by https://chromium-review.googlesource.com/c/chromium/src/+/561921
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 5

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 7 by ClusterFuzz, Sep 8

ClusterFuzz has detected this issue as fixed in range 589552:589567.

Detailed report: https://clusterfuzz.com/testcase?key=5742118707134464

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: UNKNOWN WRITE
Crash Address: 0x000147d38000
Crash State:
  cc::RestoreOp::Serialize
  cc::PaintOp::Serialize
  gpu::raster::PaintOpSerializer::Serialize
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=585071:585171
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=589552:589567

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5742118707134464

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Sep 8

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5742118707134464 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 8

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 14

Labels: Merge-Request-70
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 14

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70
Hi enne - mind taking a look at the fixed range (https://clusterfuzz.com/v2/revisions?job=mac_asan_chrome&range=589552%3A589567&noredirect=1) and see if there's a fix there we should merge to M70?
There is nothing even remotely obvious in that changelist, unfortunately.  I even looked through the Skia changes just in case.  Thanks for asking though; that's a really good thought.
Labels: -ReleaseBlock-Stable -Target-70 -M-70 Target-71 M-71
Thanks for looking!
Project Member

Comment 16 by sheriffbot@chromium.org, Dec 15

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment