New issue
Advanced search Search tips

Issue 877775 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 914572
issue 896386

Blocking:
issue 879378
issue 892681
issue 887141



Sign in to add a comment

Rework third-party packages recipe

Project Member Reported by iannucci@chromium.org, Aug 25

Issue description

Currently the third-party packages recipe (3pp) requires recipe modification when adding new packages, and this modification process is less straightforward than one would hope (in particular, what would be 3-4 lines of shell requires modification of a couple different files, copying and modifying a boilerplate recipe and regenerating expectations). 

Additionally, the current recipe doesn't support cross-compilation, and it's not obvious how to add it without making things more complicated.

Thirdly, the recipes don't treat the fetch, build, package, upload cycle in a uniform way; some packages we build are meant to be consumed as dependencies and so are rebuilt every time, some are not, each package roughly manages its own cipd interactions, etc.

The goal for the rework is:
  * Adding/changing packages, their dependencies or build procedure should not require any recipe modification. The recipe should publish a fixed API and the package definitions should live elsewhere, e.g. in the infra repo in a mostly-declarative format.
  * Cross compilation/toolchain management should be trivial (at least for cross-arch on linux, but ideally built so that we can add cross-platform cross-compile as well, e.g. with clang for windows and mac from linux).
  * Heavily document the API of the recipe so interacting with it is very predictable.
  * Allow local execution of the recipe to build any subset of packages known to it.
  * Allow other teams to define packages in their own repo and re-use this recipe verbatim (preferably from the infra recipe bundle).

Because this rework is pretty extensive architecturally, I'll be writing it as a parallel recipe/module with parallel builders instead of rebuilding it in-place.
 
Showing comments 40 - 139 of 139 Older
Project Member

Comment 40 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cb3a5a335cfacd24543d1b80f6e26f069d8663b5

commit cb3a5a335cfacd24543d1b80f6e26f069d8663b5
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Sep 28 22:37:01 2018

[third_party_packages/readline] Fix includes, global header, curses

R=dnj@chromium.org, hinoka@chromium.org, tandrii@chromium.org

Bug: 877775
Change-Id: Idd1e79637dce4dbda4234ed82957cfd4b6f4548f
Reviewed-on: https://chromium-review.googlesource.com/1252722
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17963}
[modify] https://crrev.com/cb3a5a335cfacd24543d1b80f6e26f069d8663b5/third_party_packages/readline/install.sh
[modify] https://crrev.com/cb3a5a335cfacd24543d1b80f6e26f069d8663b5/third_party_packages/readline/3pp.pb

Project Member

Comment 41 by bugdroid1@chromium.org, Sep 29

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4b05a6e835f9f01cf0405fedf865dcffd71c1e29

commit 4b05a6e835f9f01cf0405fedf865dcffd71c1e29
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Sep 29 02:36:13 2018

[third_party_packages/pip_bootstrap] Add package for bootstrapping pip.

This replaces the hard-coded pip bootstrap package at
  https://chrome-infra-packages.appspot.com/p/infra/third_party/pip-packages/+/

The new one has one fewer copy of pip, and a much simpler bootstrap script.
This will be used as a tool for the `cpython` package.

R=dnj@chromium.org, hinoka@chromium.org, tandrii@chromium.org

Bug: 877775
Change-Id: Ie36e3dd9a447454586b73ef878906da1c34df4aa
Reviewed-on: https://chromium-review.googlesource.com/1252723
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17969}
[add] https://crrev.com/4b05a6e835f9f01cf0405fedf865dcffd71c1e29/third_party_packages/pip_bootstrap/fetch.py
[add] https://crrev.com/4b05a6e835f9f01cf0405fedf865dcffd71c1e29/third_party_packages/pip_bootstrap/pip_bootstrap.py
[add] https://crrev.com/4b05a6e835f9f01cf0405fedf865dcffd71c1e29/third_party_packages/pip_bootstrap/3pp.pb
[add] https://crrev.com/4b05a6e835f9f01cf0405fedf865dcffd71c1e29/third_party_packages/pip_bootstrap/install.sh

Project Member

Comment 42 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5ac0eaf7adc102b9360b65dedab4f56acad6b574

commit 5ac0eaf7adc102b9360b65dedab4f56acad6b574
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 01 21:16:45 2018

[third_party_packages_ng/cpython] Add python (finally)

Works for at least mac-amd64, linux-amd64 and linux-arm64

R=dnj@chromium.org, dnj@google.com, hinoka@chromium.org, tandrii@chromium.org

Bug: 877775
Change-Id: I66da89c2fa26c897fd7468160e953097fbce256e
Reviewed-on: https://chromium-review.googlesource.com/c/1130081
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17978}
[add] https://crrev.com/5ac0eaf7adc102b9360b65dedab4f56acad6b574/third_party_packages/cpython/patches/0001-Update-Python-to-build-static-modules.patch
[add] https://crrev.com/5ac0eaf7adc102b9360b65dedab4f56acad6b574/third_party_packages/cpython/install.sh
[add] https://crrev.com/5ac0eaf7adc102b9360b65dedab4f56acad6b574/third_party_packages/cpython/python_test.py
[add] https://crrev.com/5ac0eaf7adc102b9360b65dedab4f56acad6b574/third_party_packages/cpython/python_ssl_suffix.py
[add] https://crrev.com/5ac0eaf7adc102b9360b65dedab4f56acad6b574/third_party_packages/cpython/gnu_version_script.txt
[add] https://crrev.com/5ac0eaf7adc102b9360b65dedab4f56acad6b574/third_party_packages/cpython/python_mod_gen.py
[add] https://crrev.com/5ac0eaf7adc102b9360b65dedab4f56acad6b574/third_party_packages/cpython/3pp.pb
[add] https://crrev.com/5ac0eaf7adc102b9360b65dedab4f56acad6b574/third_party_packages/cpython/patches/0002-Enable-manual-version-specification.patch
[add] https://crrev.com/5ac0eaf7adc102b9360b65dedab4f56acad6b574/third_party_packages/cpython/README.md
[add] https://crrev.com/5ac0eaf7adc102b9360b65dedab4f56acad6b574/third_party_packages/cpython/example.vpython

Project Member

Comment 43 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c1fb817f34137b4fc4b5e842b6cb226357e84f0c

commit c1fb817f34137b4fc4b5e842b6cb226357e84f0c
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Oct 04 23:04:00 2018

[third_party_packages_ng] Add better experiment support/build id tags.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I6348f66507c89d6a3cad5594ea23c49b384507b0
Reviewed-on: https://chromium-review.googlesource.com/c/1257563
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18070}
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/tests/full.py
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/empty spec.json
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipes/third_party_packages_ng.py
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/create.py
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/resolved_spec.py
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_mac-amd64.json
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/__init__.py
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-amd64.json
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/bad spec.json
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/README.recipes.md
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/api.py
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/duplicate load.json
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/cipd_spec.py
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-armv6l.json
[modify] https://crrev.com/c1fb817f34137b4fc4b5e842b6cb226357e84f0c/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_windows-amd64.json

Project Member

Comment 44 by bugdroid1@chromium.org, Oct 4

Labels: merge-merged-config
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/a13d63fa87c23d543dc17c166d118494f9d6d8d9

commit a13d63fa87c23d543dc17c166d118494f9d6d8d9
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Oct 04 23:44:51 2018

Project Member

Comment 45 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/68c08ab46e9e8317a53c3073ce3444eb67ef4f97

commit 68c08ab46e9e8317a53c3073ce3444eb67ef4f97
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 05 00:50:26 2018

[third_party_packages_ng] Do not use run.py for dockerbuild.

Dockerbuild works without any of the bootstrap env stuff in infra.git;
bypassing run.py prevents the need for any of that stuff (just the
basic dockerbuild python module).

`run.py` and the additional bootstrap junk is intentionally NOT included
in the recipe bundle, so the recipe currently fails on the bots.

R=hinoka@chromium.org, tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: Ib0dbdcc86093879e1dd129409584717ef19fcdf6
Reviewed-on: https://chromium-review.googlesource.com/c/1263584
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18083}
[modify] https://crrev.com/68c08ab46e9e8317a53c3073ce3444eb67ef4f97/recipes/recipe_modules/third_party_packages_ng/run_script.py
[modify] https://crrev.com/68c08ab46e9e8317a53c3073ce3444eb67ef4f97/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-armv6l.json
[modify] https://crrev.com/68c08ab46e9e8317a53c3073ce3444eb67ef4f97/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-amd64.json

Project Member

Comment 46 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116

commit 840950f4bfb6469b4ff72ae4e54ab5c0f5e71116
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 05 00:58:43 2018

[cipd] Fix typo in pkg-deploy method.

Somehow an extra space got in, making the whole thing broken.

TBR=hinoka@chromium.org, tandrii@chromium.org, vadimsh@chromium.org

Recipe-Nontrivial-Roll: infra
Bug: 877775
Change-Id: I581185dec9ed305db616ea905204a1e13e840759
Reviewed-on: https://chromium-review.googlesource.com/c/1263027
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116/recipe_modules/cipd/examples/full.expected/win64.json
[modify] https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116/recipe_modules/cipd/examples/full.expected/basic_with_no_refs_or_tags.json
[modify] https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116/recipe_modules/cipd/examples/full.expected/search-empty-result.json
[modify] https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116/recipe_modules/cipd/examples/full.expected/mac64.json
[modify] https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116/recipe_modules/cipd/examples/full.expected/basic.json
[modify] https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116/recipe_modules/cipd/examples/full.expected/describe-many-instances.json
[modify] https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116/recipe_modules/cipd/examples/full.expected/basic_pkg.json
[modify] https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116/README.recipes.md
[modify] https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116/recipe_modules/cipd/examples/full.expected/basic_with_pkg_vars.json
[modify] https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116/recipe_modules/cipd/api.py

Project Member

Comment 47 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5fb121449e9ab66f2e325eaa41997280f60f8d19

commit 5fb121449e9ab66f2e325eaa41997280f60f8d19
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 05 02:39:27 2018

[third_party_packages_ng] Add standalone .vpython spec, fix experimental.

This should correctly be able to run dockerbuild as a standalone script
(apart from infra.git) and also correctly calculate the package names
(since the recipe is unconditionally assigning it's package_prefix value
to the 3pp module).

TBR=hinoka@chromium.org, tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I013d48af0c05e756718a8d833072cf4af9b7847b
Reviewed-on: https://chromium-review.googlesource.com/c/1263796
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18088}
[modify] https://crrev.com/5fb121449e9ab66f2e325eaa41997280f60f8d19/recipes/recipe_modules/third_party_packages_ng/tests/full.py
[add] https://crrev.com/5fb121449e9ab66f2e325eaa41997280f60f8d19/infra/tools/dockerbuild/standalone.vpython
[modify] https://crrev.com/5fb121449e9ab66f2e325eaa41997280f60f8d19/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-armv6l.json
[modify] https://crrev.com/5fb121449e9ab66f2e325eaa41997280f60f8d19/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_mac-amd64.json
[modify] https://crrev.com/5fb121449e9ab66f2e325eaa41997280f60f8d19/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-amd64.json
[modify] https://crrev.com/5fb121449e9ab66f2e325eaa41997280f60f8d19/recipes/README.recipes.md
[modify] https://crrev.com/5fb121449e9ab66f2e325eaa41997280f60f8d19/recipes/recipe_modules/third_party_packages_ng/api.py
[modify] https://crrev.com/5fb121449e9ab66f2e325eaa41997280f60f8d19/recipes/recipe_modules/third_party_packages_ng/run_script.py
[modify] https://crrev.com/5fb121449e9ab66f2e325eaa41997280f60f8d19/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_windows-amd64.json

Project Member

Comment 48 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/157147a7d228bcf0a0626d71712999de639388a8

commit 157147a7d228bcf0a0626d71712999de639388a8
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 05 03:23:34 2018

Blocking: 892681
Project Member

Comment 50 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/85af45334ed48cc2e35ddaef0c428f701246260a

commit 85af45334ed48cc2e35ddaef0c428f701246260a
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 05 17:42:27 2018

[windows_sdk] Default to cache/windows_sdk.

This should allow better integration with buildbucket named cache
support. Since this was already parameterized it shouldn't actually
break anything; previously the directory would be deleted on every run,
now it will still be deleted on every run (but we can add a buildbucket
named cache entry for it to preserve it).

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I1184fb59a3ed18bfda5fcb288903201b01527096
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Reviewed-on: https://chromium-review.googlesource.com/c/1263861
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/85af45334ed48cc2e35ddaef0c428f701246260a/recipes/recipe_modules/windows_sdk/examples/full.expected/win.json
[modify] https://crrev.com/85af45334ed48cc2e35ddaef0c428f701246260a/recipes/README.recipes.md
[modify] https://crrev.com/85af45334ed48cc2e35ddaef0c428f701246260a/recipes/recipe_modules/windows_sdk/api.py

Project Member

Comment 51 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/56d9c05565f7335db3bd91c4f17a1c1c3e858321

commit 56d9c05565f7335db3bd91c4f17a1c1c3e858321
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 05 18:31:46 2018

[third_party_packages_ng] Add documentation about named caches.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: Iccaa25818c2aa061a8aee998067fb5fbeb9574e6
Reviewed-on: https://chromium-review.googlesource.com/c/1264015
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18108}
[modify] https://crrev.com/56d9c05565f7335db3bd91c4f17a1c1c3e858321/recipes/README.recipes.md
[modify] https://crrev.com/56d9c05565f7335db3bd91c4f17a1c1c3e858321/recipes/recipe_modules/third_party_packages_ng/api.py

Project Member

Comment 52 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/c75ec305aacbb9fc987388cbbbbf92c0e3e63169

commit c75ec305aacbb9fc987388cbbbbf92c0e3e63169
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 05 18:32:26 2018

Project Member

Comment 54 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/781a65e273c55b278cf47247f22afcbd4c1ca733

commit 781a65e273c55b278cf47247f22afcbd4c1ca733
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Oct 05 21:00:32 2018

Roll src/third_party/depot_tools 0c3bd49069d4..71e3be7a50c2 (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0c3bd49069d4..71e3be7a50c2


git log 0c3bd49069d4..71e3be7a50c2 --date=short --no-merges --format='%ad %ae %s'
2018-10-05 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-10-05 iannucci@chromium.org [windows_sdk] Default to cache/windows_sdk.


Created with:
  gclient setdep -r src/third_party/depot_tools@71e3be7a50c2

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877775
TBR=agable@chromium.org

Change-Id: I025a744cc1400d500985ca5cadcffe34b3284a3b
Reviewed-on: https://chromium-review.googlesource.com/c/1265048
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597286}
[modify] https://crrev.com/781a65e273c55b278cf47247f22afcbd4c1ca733/DEPS

Project Member

Comment 55 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/dfd3ed9be5ab0f58176d82e83830d5b0617ab633

commit dfd3ed9be5ab0f58176d82e83830d5b0617ab633
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 05 21:06:55 2018

[third_party_packages_ng] Even more debugging information to help debug bots.

TBR=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I42361ec621219aff89e473e70fa791801d446dd3
Reviewed-on: https://chromium-review.googlesource.com/c/1265342
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18121}
[modify] https://crrev.com/dfd3ed9be5ab0f58176d82e83830d5b0617ab633/infra/tools/dockerbuild/dockcross.py

Project Member

Comment 56 by bugdroid1@chromium.org, Oct 6

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6e649bba74002172866f33a9c09fcf4d3288bf8f

commit 6e649bba74002172866f33a9c09fcf4d3288bf8f
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Oct 06 04:31:09 2018

[dockerbuild] chmod +x start.sh so it works for all mapped users.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I1f510e08f998dced3abc62418218ac419a45d841
Reviewed-on: https://chromium-review.googlesource.com/c/1266181
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18136}
[modify] https://crrev.com/6e649bba74002172866f33a9c09fcf4d3288bf8f/infra/tools/dockerbuild/dockcross.py
[modify] https://crrev.com/6e649bba74002172866f33a9c09fcf4d3288bf8f/infra/tools/dockerbuild/resources/Dockerfile.template

Project Member

Comment 57 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/288c9e8ce316f6eb88752a8a28168a1257611b7d

commit 288c9e8ce316f6eb88752a8a28168a1257611b7d
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 08 17:50:26 2018

Project Member

Comment 58 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7dab846d9f2aed8f1feb8cc5ad3ddda1ca1671e8

commit 7dab846d9f2aed8f1feb8cc5ad3ddda1ca1671e8
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 08 22:56:55 2018

[dockerbuild] Ensure that start.sh can be executed by all users.

Also revert excessively verbose logging change.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: Ia4c10042941d30470a87f38cf01c372e167f1074
Reviewed-on: https://chromium-review.googlesource.com/c/1269683
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18160}
[modify] https://crrev.com/7dab846d9f2aed8f1feb8cc5ad3ddda1ca1671e8/infra/tools/dockerbuild/dockcross.py
[modify] https://crrev.com/7dab846d9f2aed8f1feb8cc5ad3ddda1ca1671e8/infra/tools/dockerbuild/resources/Dockerfile.template

Project Member

Comment 59 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d6eae7b87f6a7e6c54b062d7ba1d9fdc53e3fc26

commit d6eae7b87f6a7e6c54b062d7ba1d9fdc53e3fc26
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 08 23:06:23 2018

[third_party_packages_ng] Use vpython for basic script invocation.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I2bd5b8423c56b14ca61bf56e4f9c7416673eaa39
Reviewed-on: https://chromium-review.googlesource.com/c/1270015
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18162}
[modify] https://crrev.com/d6eae7b87f6a7e6c54b062d7ba1d9fdc53e3fc26/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-armv6l.json
[modify] https://crrev.com/d6eae7b87f6a7e6c54b062d7ba1d9fdc53e3fc26/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_mac-amd64.json
[modify] https://crrev.com/d6eae7b87f6a7e6c54b062d7ba1d9fdc53e3fc26/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-amd64.json
[modify] https://crrev.com/d6eae7b87f6a7e6c54b062d7ba1d9fdc53e3fc26/recipes/README.recipes.md
[modify] https://crrev.com/d6eae7b87f6a7e6c54b062d7ba1d9fdc53e3fc26/recipes/recipe_modules/third_party_packages_ng/api.py
[modify] https://crrev.com/d6eae7b87f6a7e6c54b062d7ba1d9fdc53e3fc26/recipes/recipe_modules/third_party_packages_ng/run_script.py
[modify] https://crrev.com/d6eae7b87f6a7e6c54b062d7ba1d9fdc53e3fc26/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_windows-amd64.json

Project Member

Comment 60 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b2a3ebd8be76fa1a523598503a9870c5d6e16025

commit b2a3ebd8be76fa1a523598503a9870c5d6e16025
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 09 18:42:01 2018

[third_party_packages_ng] Better build plan sorting.

This will make the actual execution of the recipe 'flat'; we should
never end up building a dependency while we're trying to build a package
now.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: Ic823ea439957dcd74692ac0f16196f9381881eee
Reviewed-on: https://chromium-review.googlesource.com/c/1270256
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18186}
[modify] https://crrev.com/b2a3ebd8be76fa1a523598503a9870c5d6e16025/recipes/recipe_modules/third_party_packages_ng/resolved_spec.py
[modify] https://crrev.com/b2a3ebd8be76fa1a523598503a9870c5d6e16025/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_mac-amd64.json
[modify] https://crrev.com/b2a3ebd8be76fa1a523598503a9870c5d6e16025/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-armv6l.json
[modify] https://crrev.com/b2a3ebd8be76fa1a523598503a9870c5d6e16025/recipes/recipe_modules/third_party_packages_ng/api.py
[modify] https://crrev.com/b2a3ebd8be76fa1a523598503a9870c5d6e16025/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-amd64.json

Project Member

Comment 61 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/61bdbde851b35f3aea0bdf2a3723d2feb718c0b7

commit 61bdbde851b35f3aea0bdf2a3723d2feb718c0b7
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 09 19:04:14 2018

[third_party_packages_ng] Change default experimental prefix.

To avoid hogging 'experimental' :).

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I4f2749035be65bf1d1990fc8607be0d898cb9607
Reviewed-on: https://chromium-review.googlesource.com/c/1270257
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18187}
[modify] https://crrev.com/61bdbde851b35f3aea0bdf2a3723d2feb718c0b7/recipes/recipe_modules/third_party_packages_ng/tests/full.py
[modify] https://crrev.com/61bdbde851b35f3aea0bdf2a3723d2feb718c0b7/recipes/recipes/third_party_packages_ng.py
[modify] https://crrev.com/61bdbde851b35f3aea0bdf2a3723d2feb718c0b7/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-armv6l.json
[modify] https://crrev.com/61bdbde851b35f3aea0bdf2a3723d2feb718c0b7/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_mac-amd64.json
[modify] https://crrev.com/61bdbde851b35f3aea0bdf2a3723d2feb718c0b7/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-amd64.json
[modify] https://crrev.com/61bdbde851b35f3aea0bdf2a3723d2feb718c0b7/recipes/README.recipes.md
[modify] https://crrev.com/61bdbde851b35f3aea0bdf2a3723d2feb718c0b7/recipes/recipe_modules/third_party_packages_ng/api.py
[modify] https://crrev.com/61bdbde851b35f3aea0bdf2a3723d2feb718c0b7/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_windows-amd64.json

Project Member

Comment 62 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b522998808ba5da52c45f51048c4eff49cdaed0c

commit b522998808ba5da52c45f51048c4eff49cdaed0c
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 09 21:17:39 2018

[third_party_packages_ng] Use original tag string for version.

Previously we used the str(parsed_version) as the version; however
`str(parse_version('1.0.0-rc1')) == '1.0.0rc1'`, which results in having
a missing tag when trying to actually fetch from the remote.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: Icaec820fc344aaead2cd84a366ab7a9c56b48667
Reviewed-on: https://chromium-review.googlesource.com/c/1271241
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18196}
[modify] https://crrev.com/b522998808ba5da52c45f51048c4eff49cdaed0c/recipes/recipe_modules/third_party_packages_ng/tests/full.py
[modify] https://crrev.com/b522998808ba5da52c45f51048c4eff49cdaed0c/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-armv6l.json
[modify] https://crrev.com/b522998808ba5da52c45f51048c4eff49cdaed0c/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_mac-amd64.json
[modify] https://crrev.com/b522998808ba5da52c45f51048c4eff49cdaed0c/recipes/recipe_modules/third_party_packages_ng/source.py
[modify] https://crrev.com/b522998808ba5da52c45f51048c4eff49cdaed0c/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-amd64.json
[modify] https://crrev.com/b522998808ba5da52c45f51048c4eff49cdaed0c/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_windows-amd64.json

Project Member

Comment 63 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/184622549bea50d3dcd5916bf963156ea8352882

commit 184622549bea50d3dcd5916bf963156ea8352882
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 09 22:07:21 2018

[dockerbuild] Chmod install-util.sh too.

Some 3pp install scripts need to use it.

TBR=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I4edf3d5cfca505f779025a9509392261c5cd18e9
Reviewed-on: https://chromium-review.googlesource.com/c/1272215
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18200}
[modify] https://crrev.com/184622549bea50d3dcd5916bf963156ea8352882/infra/tools/dockerbuild/dockcross.py
[modify] https://crrev.com/184622549bea50d3dcd5916bf963156ea8352882/infra/tools/dockerbuild/resources/Dockerfile.template

Project Member

Comment 64 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/38875bf49501f5c6dcd08e74a4c66855d2408752

commit 38875bf49501f5c6dcd08e74a4c66855d2408752
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 15 06:55:38 2018

[third_party_packages] Only build autoconf for linux-amd64/mac.

We only use it inside of docker (or for mac), which means we only need
it for linux-amd64. There's something about this that breaks for other
architectures -- probably not unsolvable, but I don't think we need
to solve it now.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: Ie0789db2b9a5273348ed3738355523e02b6f3380
Reviewed-on: https://chromium-review.googlesource.com/c/1280162
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18309}
[modify] https://crrev.com/38875bf49501f5c6dcd08e74a4c66855d2408752/third_party_packages/autoconf/3pp.pb

Project Member

Comment 65 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2c1362dd6448d1c006236c01631293ed3e305dbe

commit 2c1362dd6448d1c006236c01631293ed3e305dbe
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 15 18:44:35 2018

[third_party_packages] Fix cmake on linux-arm64.

This does the same trick we do for python; generate a separate, explicit
bootstrap package first (w/o any dependencies), and then depend on that
for the real target platform.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: If1a8640f7824cd4ce6b14a51e5043e304176535f
Reviewed-on: https://chromium-review.googlesource.com/c/1281362
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18319}
[modify] https://crrev.com/2c1362dd6448d1c006236c01631293ed3e305dbe/third_party_packages/cmake/3pp.pb
[add] https://crrev.com/2c1362dd6448d1c006236c01631293ed3e305dbe/third_party_packages/cmake_bootstrap/3pp.pb
[add] https://crrev.com/2c1362dd6448d1c006236c01631293ed3e305dbe/third_party_packages/cmake_bootstrap/patches/0001-Port-curl-curl-2443-to-allow-cross-compile.patch
[rename] https://crrev.com/2c1362dd6448d1c006236c01631293ed3e305dbe/third_party_packages/cmake_bootstrap/install.sh

Project Member

Comment 66 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b01119c9505927985296a2390456a50a7649d841

commit b01119c9505927985296a2390456a50a7649d841
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 15 19:56:38 2018

[third_party_packages] Actually build ninja.

Previously it just copied the source into the output package :D

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: Ic1e041446012df8fdabea88778c822366cc846e7
Reviewed-on: https://chromium-review.googlesource.com/c/1281365
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18321}
[modify] https://crrev.com/b01119c9505927985296a2390456a50a7649d841/third_party_packages/ninja/3pp.pb

Project Member

Comment 67 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/860081eeaff5e3b390113fab3fa929d7ee9362a6

commit 860081eeaff5e3b390113fab3fa929d7ee9362a6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 15 21:29:24 2018

Project Member

Comment 68 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/84b26f0df31d66abc301b3b53d5bcff9e0af4368

commit 84b26f0df31d66abc301b3b53d5bcff9e0af4368
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 15 21:32:29 2018

[third_party_packages] Fix openssl for arm.

Also upgrade to OpenSSL 1.1.1 (which is the newest, and has at least one
fix for cross-compiling on ARM).

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: Ic514371ce418777d7994ca27bcd0b9c333d0cc42
Reviewed-on: https://chromium-review.googlesource.com/c/1281983
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18327}
[modify] https://crrev.com/84b26f0df31d66abc301b3b53d5bcff9e0af4368/third_party_packages/openssl/3pp.pb
[modify] https://crrev.com/84b26f0df31d66abc301b3b53d5bcff9e0af4368/third_party_packages/openssl/install.sh

Project Member

Comment 69 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/04fec3120e0505b768c5c17f3e7d0a15d472af72

commit 04fec3120e0505b768c5c17f3e7d0a15d472af72
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 15 21:46:40 2018

[third_party_packages] Move cmake_bootstrap under third_party.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: Ie5018c43091411c74cfbefcb3441dfeaaf5ef8bd
Reviewed-on: https://chromium-review.googlesource.com/c/1281984
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18329}
[modify] https://crrev.com/04fec3120e0505b768c5c17f3e7d0a15d472af72/third_party_packages/cmake_bootstrap/3pp.pb

Project Member

Comment 70 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/b2a7c0207082ed3987f233562bc4dff5f285cc7f

commit b2a7c0207082ed3987f233562bc4dff5f285cc7f
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 15 22:54:30 2018

Project Member

Comment 72 by bugdroid1@chromium.org, Oct 16

Project Member

Comment 73 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6ec1999625f2e0aafff9ce14025b231a087ab655

commit 6ec1999625f2e0aafff9ce14025b231a087ab655
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 16 04:42:11 2018

[third_party_packages] Make git work on all linuxes.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: Ib473ad22c32355764c2de6711d000a47ea6c27b8
Reviewed-on: https://chromium-review.googlesource.com/c/1282276
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18343}
[modify] https://crrev.com/6ec1999625f2e0aafff9ce14025b231a087ab655/third_party_packages/git/install.sh

Project Member

Comment 75 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/59310a9845714a93c2d8011ca2396e1db1e301fc

commit 59310a9845714a93c2d8011ca2396e1db1e301fc
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 16 06:45:43 2018

[third_party_packages] Fix cpython with OpenSSL 1.1.1.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: Ie646e3d8b957f3b9600774f0f9f213642caa1956
Reviewed-on: https://chromium-review.googlesource.com/c/1282279
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18347}
[modify] https://crrev.com/59310a9845714a93c2d8011ca2396e1db1e301fc/third_party_packages/cpython/install.sh

Project Member

Comment 76 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/fd55f430989530315c382a840f2d77d38dfda2d6

commit fd55f430989530315c382a840f2d77d38dfda2d6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 16 07:19:36 2018

Project Member

Comment 77 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d6c781ba0e9c6e3e1d84d9e8476ec6846a89a5fc

commit d6c781ba0e9c6e3e1d84d9e8476ec6846a89a5fc
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 16 07:29:16 2018

[third_party_packages] Fix GOARCH variable.

It's `arm`, not `armv6l`, and it's `mipsle`, not 'mips32'.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: I47894beeb518257c47c3e88f240171d7f29b58e8
Reviewed-on: https://chromium-review.googlesource.com/c/1282280
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18350}
[modify] https://crrev.com/d6c781ba0e9c6e3e1d84d9e8476ec6846a89a5fc/recipes/recipe_modules/third_party_packages_ng/run_script.py
[modify] https://crrev.com/d6c781ba0e9c6e3e1d84d9e8476ec6846a89a5fc/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-armv6l.json
[modify] https://crrev.com/d6c781ba0e9c6e3e1d84d9e8476ec6846a89a5fc/recipes/recipe_modules/third_party_packages_ng/create.py

Project Member

Comment 78 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d95c6b86d594239eab52eb9a22248476f3537d71

commit d95c6b86d594239eab52eb9a22248476f3537d71
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 16 08:26:48 2018

[third_party_packages] Just disable dep on mips.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: I304763620ec5db1ab2fbede453e3fad72e334b78
Reviewed-on: https://chromium-review.googlesource.com/c/1282281
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18353}
[modify] https://crrev.com/d95c6b86d594239eab52eb9a22248476f3537d71/third_party_packages/dep/3pp.pb

Project Member

Comment 79 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/31f0d9448ec84033f3a7a7ffd195cbd6ab60d0cd

commit 31f0d9448ec84033f3a7a7ffd195cbd6ab60d0cd
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 16 08:36:42 2018

[third_party_packages] Best-effort race detection.

Do an extra `cipd describe` operation just before uploading to try to
prevent cases where two recipes are racing to build the same packages.

This won't be fully solvable before the CIPD backend supports 'unique'
tags (i.e. enforced by a transaction on the package).

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: I2a6e0005f12ac1144aa2687fc41c18bbc0d20137
Reviewed-on: https://chromium-review.googlesource.com/c/1282862
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18354}
[modify] https://crrev.com/31f0d9448ec84033f3a7a7ffd195cbd6ab60d0cd/recipes/recipe_modules/third_party_packages_ng/cipd_spec.py
[modify] https://crrev.com/31f0d9448ec84033f3a7a7ffd195cbd6ab60d0cd/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_mac-amd64.json
[modify] https://crrev.com/31f0d9448ec84033f3a7a7ffd195cbd6ab60d0cd/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-armv6l.json
[modify] https://crrev.com/31f0d9448ec84033f3a7a7ffd195cbd6ab60d0cd/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_windows-amd64.json
[modify] https://crrev.com/31f0d9448ec84033f3a7a7ffd195cbd6ab60d0cd/recipes/recipe_modules/third_party_packages_ng/tests/full.expected/integration_test_linux-amd64.json

Project Member

Comment 80 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5ae8b024aa5a04c58f2daa79780bd445438a7ee0

commit 5ae8b024aa5a04c58f2daa79780bd445438a7ee0
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 16 17:13:31 2018

[third_party_packages] Fix location of dep tool

Previously it was in go/cmd/github.com/golang/dep/dep/${platform}.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: Ic3ee8cea539aad920aea80cdff1008fe847a0681
Reviewed-on: https://chromium-review.googlesource.com/c/1283454
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18360}
[modify] https://crrev.com/5ae8b024aa5a04c58f2daa79780bd445438a7ee0/third_party_packages/dep/3pp.pb

Project Member

Comment 81 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bed617620aad14b2f61ad46f621da3b565d8bbd3

commit bed617620aad14b2f61ad46f621da3b565d8bbd3
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 16 17:33:36 2018

[third_party_packages] Fix location of pip_bootstrap and cmake_bootstrap.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: Id3fee98ab4f8b8ae15944f5ceb5cf5c038783bbe
Reviewed-on: https://chromium-review.googlesource.com/c/1283455
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18361}
[modify] https://crrev.com/bed617620aad14b2f61ad46f621da3b565d8bbd3/third_party_packages/cmake_bootstrap/3pp.pb
[modify] https://crrev.com/bed617620aad14b2f61ad46f621da3b565d8bbd3/third_party_packages/pip_bootstrap/3pp.pb

Project Member

Comment 82 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/a1307fe487f627a813c13feecc3ee80e4c44f369

commit a1307fe487f627a813c13feecc3ee80e4c44f369
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 16 17:55:05 2018

Project Member

Comment 83 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/aafc4c4761a1bcebd438b8d42f99742dddae4ade

commit aafc4c4761a1bcebd438b8d42f99742dddae4ade
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 16 18:05:36 2018

[3pp] Rename from third_party_packages_ng.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I8ae2922d24aef2e6cb623da66a2e9c785354344b
Reviewed-on: https://chromium-review.googlesource.com/c/1283869
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18364}
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cpython/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/pip_bootstrap/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/sed/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/git/git_test.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/workdir.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/openssl/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/nsl/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipes/3pp.expected/basic.json
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/readline/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/gettext/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cpython/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/nsl/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/go/install_official.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/git/profile.d.vpython.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/git/windows_fetch.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/zlib/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/pcre/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/ncurses/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/pcre/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/tests/full.expected/integration_test_linux-amd64.json
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/gcloud/3pp.pb
[modify] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/README.recipes.md
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cmake_bootstrap/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/verify.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/spec.proto
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/go/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/gsutil/fetch.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipes/3pp.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/__init__.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/automake/patches/0001-Make-automake-relocatable.patch
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/tests/full.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/resources/win_support/git-bash
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/go/install_source.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/re2c/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cmake/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/README.md
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/automake/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/cipd_spec.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/.vpython
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/swig/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/run_script.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/libidn2/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cpython/patches/0002-Enable-manual-version-specification.patch
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/gettext/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/ninja/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/ninja/install_bootstrap.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/tests/full.expected/integration_test_linux-armv6l.json
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/openssl/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cpython/patches/0001-Update-Python-to-build-static-modules.patch
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/build.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/autoconf/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/sqlite/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/resources/mac_support/nproc
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/libidn2/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cpython/python_test.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/pcre2/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/git/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cpython/python_mod_gen.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cmake_bootstrap/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/go/fetch.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/api.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/gcloud/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/sqlite/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/tests/full.expected/bad spec.json
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/dep/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/tests/full.expected/duplicate load.json
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cmake_bootstrap/patches/0001-Port-curl-curl-2443-to-allow-cross-compile.patch
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cpython/example.vpython
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/git/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/ncurses/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cpython/gnu_version_script.txt
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/curl/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/tests/full.expected/integration_test_mac-amd64.json
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/resolved_spec.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/re2c/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/gsutil/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/ninja/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/dep/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/bzip2/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/sed/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/pip_bootstrap/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/resources/linux_support/realpath
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/autoconf/patches/0001-Make-autoconf-relocatable.patch
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/pip_bootstrap/fetch.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/tests/full.expected/integration_test_windows-amd64.json
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cpython/python_ssl_suffix.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/autoconf/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/create.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/exceptions.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/gcloud/fetch.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cmake/patches/0001-Port-curl-curl-2443-to-allow-cross-compile.patch
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/automake/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/swig/patches/0001-Use-relative-path-to-swiglib-on-Darwin-and-Linux.patch
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/pip_bootstrap/pip_bootstrap.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cpython/README.md
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/git/profile.d.python.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/pcre2/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/spec_pb2.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/zlib/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/swig/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/tests/full.expected/empty spec.json
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/readline/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/curl/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipe_modules/support_3pp/source.py
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/bzip2/3pp.pb
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/ncurses/patches/0001-Fixes-bug-where-MKfallback.sh-hangs-on-rm-rf-tmp_inf.patch
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/recipes/recipes/3pp.expected/unsupported.json
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/cmake/install.sh
[rename] https://crrev.com/aafc4c4761a1bcebd438b8d42f99742dddae4ade/3pp/git/build_win.sh

Project Member

Comment 84 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/013024a659018611fa90b33205ca42501dc1a3e5

commit 013024a659018611fa90b33205ca42501dc1a3e5
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 17 02:10:27 2018

[3pp] Require prefix.

Instead of making the prefix optional, I want the builder to say exactly
what prefix everything should be uploaded under. Instead of having packages
splattered all over, I want to make them all relative to an explicit
namespace.

R=tandrii@chromium.org

Bug: 877775
Change-Id: Ia700b114c10631869b03cfb9452f55c691d6cad2
Reviewed-on: https://chromium-review.googlesource.com/c/1285478
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18380}
[modify] https://crrev.com/013024a659018611fa90b33205ca42501dc1a3e5/recipes/recipe_modules/support_3pp/api.py
[modify] https://crrev.com/013024a659018611fa90b33205ca42501dc1a3e5/recipes/recipes/3pp.py
[modify] https://crrev.com/013024a659018611fa90b33205ca42501dc1a3e5/recipes/recipe_modules/support_3pp/tests/full.expected/empty spec.json
[modify] https://crrev.com/013024a659018611fa90b33205ca42501dc1a3e5/recipes/recipe_modules/support_3pp/tests/full.expected/bad spec.json
[modify] https://crrev.com/013024a659018611fa90b33205ca42501dc1a3e5/recipes/README.recipes.md
[modify] https://crrev.com/013024a659018611fa90b33205ca42501dc1a3e5/recipes/recipe_modules/support_3pp/tests/full.expected/duplicate load.json
[modify] https://crrev.com/013024a659018611fa90b33205ca42501dc1a3e5/recipes/recipe_modules/support_3pp/tests/full.py

Project Member

Comment 85 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/80b8c962c52d38bb4097163ae4db109848a7082e

commit 80b8c962c52d38bb4097163ae4db109848a7082e
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 17 02:32:17 2018

Project Member

Comment 86 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33

commit 33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 17 06:39:56 2018

[3pp] Make all package prefixes consistent.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: I92b9105954f140d34c4766f84c9c63c64dfcb1ca
Reviewed-on: https://chromium-review.googlesource.com/c/1286212
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18385}
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/go/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/sqlite/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/libidn2/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/pcre2/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/cmake/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/automake/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/gettext/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/cpython/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/dep/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/nsl/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/git/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/ncurses/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/zlib/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/swig/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/curl/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/pcre/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/readline/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/re2c/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/bzip2/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/gsutil/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/gcloud/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/ninja/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/cmake_bootstrap/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/sed/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/openssl/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/pip_bootstrap/3pp.pb
[modify] https://crrev.com/33ae7dd2200c0cdd35fb168ddb73ca72a76a1a33/3pp/autoconf/3pp.pb

Blockedon: 896386
Owner: iannu...@google.com
Project Member

Comment 89 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a52c03f465b939c59bcbc6d711b7ac2feba529d8

commit a52c03f465b939c59bcbc6d711b7ac2feba529d8
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 19 03:32:51 2018

[3pp] Add Node.js and firebase-tools.

This should get 3pp to parity with the old third_party_packages script.

The `no_docker_env` thing is necessary to allow these to run on the
native (host) machine because our linux-amd64 docker image (what is
normally implied by 'universal: true') is too old to run node (which
links against newer versions of e.g. libc).

R=tandrii@chromium.org

Bug: 877775
Change-Id: I0e7e5659c531edaf1ed4f6b1c53d965e1ff52b44
Reviewed-on: https://chromium-review.googlesource.com/c/1290092
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18471}
[modify] https://crrev.com/a52c03f465b939c59bcbc6d711b7ac2feba529d8/recipes/recipe_modules/support_3pp/spec.proto
[modify] https://crrev.com/a52c03f465b939c59bcbc6d711b7ac2feba529d8/recipes/recipe_modules/support_3pp/spec_pb2.py
[modify] https://crrev.com/a52c03f465b939c59bcbc6d711b7ac2feba529d8/recipes/recipe_modules/support_3pp/resolved_spec.py
[add] https://crrev.com/a52c03f465b939c59bcbc6d711b7ac2feba529d8/3pp/nodejs/fetch.py
[modify] https://crrev.com/a52c03f465b939c59bcbc6d711b7ac2feba529d8/recipes/recipe_modules/support_3pp/api.py
[add] https://crrev.com/a52c03f465b939c59bcbc6d711b7ac2feba529d8/3pp/firebase-tools/fetch.py
[modify] https://crrev.com/a52c03f465b939c59bcbc6d711b7ac2feba529d8/recipes/recipe_modules/support_3pp/build.py
[add] https://crrev.com/a52c03f465b939c59bcbc6d711b7ac2feba529d8/3pp/firebase-tools/3pp.pb
[modify] https://crrev.com/a52c03f465b939c59bcbc6d711b7ac2feba529d8/recipes/README.recipes.md
[modify] https://crrev.com/a52c03f465b939c59bcbc6d711b7ac2feba529d8/recipes/recipe_modules/support_3pp/run_script.py
[add] https://crrev.com/a52c03f465b939c59bcbc6d711b7ac2feba529d8/3pp/nodejs/3pp.pb
[add] https://crrev.com/a52c03f465b939c59bcbc6d711b7ac2feba529d8/3pp/firebase-tools/install.sh

Project Member

Comment 90 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0276b43a8ac3e7e9eb49032f4fd3a8512d20c0f2

commit 0276b43a8ac3e7e9eb49032f4fd3a8512d20c0f2
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 19 06:10:21 2018

[3pp] Restrict Node.js platforms to exclude mips.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: I6b3480c540943e4e6450b73b243ccfb16be40e2b
Reviewed-on: https://chromium-review.googlesource.com/c/1290108
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18473}
[modify] https://crrev.com/0276b43a8ac3e7e9eb49032f4fd3a8512d20c0f2/3pp/nodejs/3pp.pb

Project Member

Comment 91 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/56ae7ce5a13ecd400437802abe23de90121fc520

commit 56ae7ce5a13ecd400437802abe23de90121fc520
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 19 18:13:14 2018

[3pp] Allow packages to express experiments on a per-target basis.

This will be useful for adding new packages once the builders are made
prod.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I8609ccc6ef558b4eb0fac0a8587123c9ed8a361a
Reviewed-on: https://chromium-review.googlesource.com/c/1291732
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18483}
[modify] https://crrev.com/56ae7ce5a13ecd400437802abe23de90121fc520/recipes/recipe_modules/support_3pp/spec.proto
[modify] https://crrev.com/56ae7ce5a13ecd400437802abe23de90121fc520/recipes/recipe_modules/support_3pp/spec_pb2.py
[modify] https://crrev.com/56ae7ce5a13ecd400437802abe23de90121fc520/recipes/recipe_modules/support_3pp/api.py
[modify] https://crrev.com/56ae7ce5a13ecd400437802abe23de90121fc520/recipes/recipes/3pp.py
[modify] https://crrev.com/56ae7ce5a13ecd400437802abe23de90121fc520/recipes/recipe_modules/support_3pp/tests/full.expected/integration_test_mac-amd64.json
[modify] https://crrev.com/56ae7ce5a13ecd400437802abe23de90121fc520/recipes/recipe_modules/support_3pp/tests/full.py
[modify] https://crrev.com/56ae7ce5a13ecd400437802abe23de90121fc520/recipes/recipe_modules/support_3pp/tests/full.expected/integration_test_windows-amd64.json
[modify] https://crrev.com/56ae7ce5a13ecd400437802abe23de90121fc520/recipes/README.recipes.md
[modify] https://crrev.com/56ae7ce5a13ecd400437802abe23de90121fc520/recipes/recipe_modules/support_3pp/tests/full.expected/integration_test_linux-armv6l.json
[modify] https://crrev.com/56ae7ce5a13ecd400437802abe23de90121fc520/recipes/recipe_modules/support_3pp/tests/full.expected/integration_test_linux-amd64.json

Project Member

Comment 92 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/90cd67e7672bfda7b01b080b08917d81754ec2ee

commit 90cd67e7672bfda7b01b080b08917d81754ec2ee
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 19 20:39:55 2018

Project Member

Comment 93 by bugdroid1@chromium.org, Oct 20

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6fc36423caa8b48a888f593428ccc4cf27a6827a

commit 6fc36423caa8b48a888f593428ccc4cf27a6827a
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Oct 20 10:17:02 2018

[3pp] Remove quotes which break glob.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: Ia9dd4a894d5a4826be89be76f1f959120f96dc4d
Reviewed-on: https://chromium-review.googlesource.com/c/1292861
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18518}
[modify] https://crrev.com/6fc36423caa8b48a888f593428ccc4cf27a6827a/3pp/git/build_win.sh

Project Member

Comment 94 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/aed376516d6b982c438422d4b217864b00d6dda8

commit aed376516d6b982c438422d4b217864b00d6dda8
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 23 06:37:30 2018

[3pp] Actually fix git on windows.

This includes making the git test ACTUALLY TEST THE GIT WE JUST BUILT.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: If952de7836ec6e1d534ac1297486557d70526ce0
Reviewed-on: https://chromium-review.googlesource.com/c/1296074
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18535}
[modify] https://crrev.com/aed376516d6b982c438422d4b217864b00d6dda8/3pp/git/git_test.py
[modify] https://crrev.com/aed376516d6b982c438422d4b217864b00d6dda8/3pp/git/build_win.sh

Project Member

Comment 95 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/af5290aad20e0511ac0a1d73d4847f48523bd70d

commit af5290aad20e0511ac0a1d73d4847f48523bd70d
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 23 19:12:01 2018

[3pp] More tweaks

  * Remove patch_version (since we don't patch git any more)
  * Fix arch for windows
  * Normalize windows build script names

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: I80d42c6adf34451611169c8f3d39286d1bab438c
Reviewed-on: https://chromium-review.googlesource.com/c/1296916
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18544}
[rename] https://crrev.com/af5290aad20e0511ac0a1d73d4847f48523bd70d/3pp/git/install_win.sh
[modify] https://crrev.com/af5290aad20e0511ac0a1d73d4847f48523bd70d/3pp/git/3pp.pb
[rename] https://crrev.com/af5290aad20e0511ac0a1d73d4847f48523bd70d/3pp/git/fetch_win.py

Project Member

Comment 96 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/04620158d8f45c68cc8bc39e30ce4a85c368046a

commit 04620158d8f45c68cc8bc39e30ce4a85c368046a
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 23 22:27:43 2018

[archive] Add extended-length path support for windows.

This will allow archives of very long path names, as well as extraction
of archives which result in very long path names.

This came up when trying to extract Node.js 10.12.0 on windows.

R=tandrii@chromium.org

Bug: 877775
Change-Id: I1cb357f3a2298fd4bf4a2aab088a51d46746cd2c
Reviewed-on: https://chromium-review.googlesource.com/c/1296920
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/04620158d8f45c68cc8bc39e30ce4a85c368046a/recipe_modules/archive/resources/extract.py

Project Member

Comment 97 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e2cd012ae96c7827b5ff06516b23a0431086da99

commit e2cd012ae96c7827b5ff06516b23a0431086da99
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 24 16:45:42 2018

[3pp] Add GAE Python/Go SDKs.

This should allow the removal of the gae-sdk-cipd-packager builder/recipe.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I9bf73111908c40f0571c1d30b1d5388040252b8c
Reviewed-on: https://chromium-review.googlesource.com/c/1297523
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18558}
[add] https://crrev.com/e2cd012ae96c7827b5ff06516b23a0431086da99/3pp/gae_go_sdk/3pp.pb
[add] https://crrev.com/e2cd012ae96c7827b5ff06516b23a0431086da99/3pp/gae_go_sdk/fetch.py
[add] https://crrev.com/e2cd012ae96c7827b5ff06516b23a0431086da99/3pp/gae_sdk/fetch.py
[add] https://crrev.com/e2cd012ae96c7827b5ff06516b23a0431086da99/3pp/gae_sdk/3pp.pb

Project Member

Comment 98 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/499be4ba184c71d7e49b32d52d987aea56a834c3

commit 499be4ba184c71d7e49b32d52d987aea56a834c3
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 24 19:30:49 2018

[3pp] Add mandatory original_download_url for cipd sources.

This is so that other folks know where the mirrored sources acutally
came from prior to CIPD. There's room for improvement however:
  * Add a 'source downloader' that ingests the source to the right place
    and tags it.
  * Tag original download url on the CIPD packages themselves.

R=vadimsh@chromium.org

Bug: 877775
Change-Id: I5be77f1862a05a341422e7d51d95d540cbcd7ef0
Reviewed-on: https://chromium-review.googlesource.com/c/1297704
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18563}
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/recipes/recipe_modules/support_3pp/spec.proto
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/sqlite/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/libidn2/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/recipes/recipe_modules/support_3pp/tests/full.py
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/pcre2/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/README.md
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/automake/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/recipes/recipe_modules/support_3pp/api.py
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/gettext/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/cpython/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/nsl/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/recipes/recipe_modules/support_3pp/spec_pb2.py
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/ncurses/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/zlib/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/curl/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/pcre/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/readline/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/re2c/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/bzip2/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/recipes/README.recipes.md
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/sed/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/openssl/3pp.pb
[modify] https://crrev.com/499be4ba184c71d7e49b32d52d987aea56a834c3/3pp/autoconf/3pp.pb

Project Member

Comment 99 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bc570df8ec2f9e736049d8c51ef7282fbc208c96

commit bc570df8ec2f9e736049d8c51ef7282fbc208c96
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 24 19:47:00 2018

[3pp] Add xzutils (py3 dep)

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I998e4b75e7bdd21e419101aee8867c471ed46def
Reviewed-on: https://chromium-review.googlesource.com/c/1297610
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18565}
[add] https://crrev.com/bc570df8ec2f9e736049d8c51ef7282fbc208c96/3pp/xzutils/install.sh
[add] https://crrev.com/bc570df8ec2f9e736049d8c51ef7282fbc208c96/3pp/xzutils/3pp.pb

Project Member

Comment 100 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/71c5163bd47c2cc2d3530bcb9696885ab390a3fe

commit 71c5163bd47c2cc2d3530bcb9696885ab390a3fe
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 24 21:09:13 2018

[3pp] Split OpenSSL headers into separate package (py3 dep).

We'll need real OpenSSL for python 3 on OS X.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I2bad161194a5eb75cbada7d58b2eb74916e381f4
Reviewed-on: https://chromium-review.googlesource.com/c/1297525
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18566}
[modify] https://crrev.com/71c5163bd47c2cc2d3530bcb9696885ab390a3fe/3pp/openssl/3pp.pb
[modify] https://crrev.com/71c5163bd47c2cc2d3530bcb9696885ab390a3fe/3pp/cpython/3pp.pb
[add] https://crrev.com/71c5163bd47c2cc2d3530bcb9696885ab390a3fe/3pp/openssl_headers/install.sh
[add] https://crrev.com/71c5163bd47c2cc2d3530bcb9696885ab390a3fe/3pp/openssl_headers/3pp.pb

Project Member

Comment 101 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/abb0915a35e17453f4521aaeb765c80e45cfc8f6

commit abb0915a35e17453f4521aaeb765c80e45cfc8f6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 24 22:16:36 2018

[3pp] Add local helper script.

This has the accumulation of knowledge that I've gleaned while working on
3pp.

R=vadimsh@chromium.org

Bug: 877775
Change-Id: Ia4e0b99752a754ee472fa992be34f361d13ab215
Reviewed-on: https://chromium-review.googlesource.com/c/1297706
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18567}
[add] https://crrev.com/abb0915a35e17453f4521aaeb765c80e45cfc8f6/3pp/run_locally.sh
[modify] https://crrev.com/abb0915a35e17453f4521aaeb765c80e45cfc8f6/3pp/README.md

Project Member

Comment 102 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4c9e9b2c3ff605714ecc38f6be7a715becf08154

commit 4c9e9b2c3ff605714ecc38f6be7a715becf08154
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 24 22:25:46 2018

[3pp] Remove bogus ncurses dependency from readline.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: Ie5a36dcdc825e320d0839f2c5c0cf3d917961c7b
Reviewed-on: https://chromium-review.googlesource.com/c/1297526
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18568}
[modify] https://crrev.com/4c9e9b2c3ff605714ecc38f6be7a715becf08154/3pp/readline/3pp.pb

Project Member

Comment 103 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8329bd7816f49d9c640cf2314bd0c69cb6dd4af1

commit 8329bd7816f49d9c640cf2314bd0c69cb6dd4af1
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Oct 25 00:58:47 2018

[3pp] Add ncursesw. Now with wiiiiiddddeee charrrsssss.

Because Python3 loooves Unicode.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I9351041f388bf7412d63274ea5aae11c1468381d
Reviewed-on: https://chromium-review.googlesource.com/c/1297689
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18569}
[add] https://crrev.com/8329bd7816f49d9c640cf2314bd0c69cb6dd4af1/3pp/ncursesw/install.sh
[add] https://crrev.com/8329bd7816f49d9c640cf2314bd0c69cb6dd4af1/3pp/ncursesw/3pp.pb
[add] https://crrev.com/8329bd7816f49d9c640cf2314bd0c69cb6dd4af1/3pp/ncursesw/patches/0001-Fixes-bug-where-MKfallback.sh-hangs-on-rm-rf-tmp_inf.patch

Project Member

Comment 104 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3f350972f1a08a6b365d170833dec38dae154d18

commit 3f350972f1a08a6b365d170833dec38dae154d18
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Oct 25 21:14:32 2018

[3pp] Add texinfo.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: Iacc598bf405aae27c0bfbf54d4ae73f4b1e4e171
Reviewed-on: https://chromium-review.googlesource.com/c/1298537
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18583}
[add] https://crrev.com/3f350972f1a08a6b365d170833dec38dae154d18/3pp/texinfo/3pp.pb
[add] https://crrev.com/3f350972f1a08a6b365d170833dec38dae154d18/3pp/texinfo/install.sh

Project Member

Comment 105 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/feab5e9bc92754a23e6a3ef9eed55b29d7374c15

commit feab5e9bc92754a23e6a3ef9eed55b29d7374c15
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 26 01:35:12 2018

[3pp] Add help2man

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: Icdf0447a21bf556f90402a8a0f51f9f727fae833
Reviewed-on: https://chromium-review.googlesource.com/c/1298538
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18587}
[add] https://crrev.com/feab5e9bc92754a23e6a3ef9eed55b29d7374c15/3pp/help2man/install.sh
[add] https://crrev.com/feab5e9bc92754a23e6a3ef9eed55b29d7374c15/3pp/help2man/3pp.pb

Project Member

Comment 107 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9612fd930cf2df6d374ca9586640b5527a10bbef

commit 9612fd930cf2df6d374ca9586640b5527a10bbef
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 26 18:09:39 2018

[3pp] Add libffi

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: Id6f1f7d8a9692e4e2c385bc24e7ed67d69962201
Reviewed-on: https://chromium-review.googlesource.com/c/1298540
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18598}
[add] https://crrev.com/9612fd930cf2df6d374ca9586640b5527a10bbef/3pp/libffi/install.sh
[add] https://crrev.com/9612fd930cf2df6d374ca9586640b5527a10bbef/3pp/libffi/3pp.pb

Project Member

Comment 108 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/39a9b0502ec980238e7dc65f5c20aefae0580494

commit 39a9b0502ec980238e7dc65f5c20aefae0580494
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 26 18:27:17 2018

[3pp] Add binutils

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: Idcb541c6fc93d5e43f0f7a9774dcac2faa1214bb
Reviewed-on: https://chromium-review.googlesource.com/c/1298541
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18599}
[add] https://crrev.com/39a9b0502ec980238e7dc65f5c20aefae0580494/3pp/binutils/install.sh
[add] https://crrev.com/39a9b0502ec980238e7dc65f5c20aefae0580494/3pp/binutils/3pp.pb

Project Member

Comment 109 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8f3dc7cf59ba0d58a25b16efe246784315d52e90

commit 8f3dc7cf59ba0d58a25b16efe246784315d52e90
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 26 18:36:49 2018

[3pp] Disable termcap in ncursesw.

This seems to trigger a bug for ncursesw when using an extensive
fallback (compiled-in) terminfo database. Since we're compiling in the
whole known database as of ncursesw 6.0 (minus some weirdo terminals
which don't play nice with Mkfallback.sh), there's not really a need
to read the terminfo database from disk.

Also, reading the terminfo database from disk seems to trigger an
O(N^2) "conflict detection" routine inside ncurses... so this actually
speeds up launching the python interpreter too. *shrug*.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I2421ebe57d983f7728cc4372edbca066b6298551
Reviewed-on: https://chromium-review.googlesource.com/c/1300873
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18601}
[modify] https://crrev.com/8f3dc7cf59ba0d58a25b16efe246784315d52e90/3pp/ncursesw/install.sh

Project Member

Comment 110 by bugdroid1@chromium.org, Oct 29

Project Member

Comment 111 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fc7a75342b977b7d93d1d45439d16bb4613775c7

commit fc7a75342b977b7d93d1d45439d16bb4613775c7
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 29 19:16:03 2018

[3pp] Add libuuid.

This is one aspect of the util-linux project, but it's the only part
we need for cpython3.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I4c872a180bc0e6341bf9cd640770542098a37fd3
Reviewed-on: https://chromium-review.googlesource.com/c/1303494
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18619}
[add] https://crrev.com/fc7a75342b977b7d93d1d45439d16bb4613775c7/3pp/libuuid/install.sh
[add] https://crrev.com/fc7a75342b977b7d93d1d45439d16bb4613775c7/3pp/libuuid/3pp.pb

Project Member

Comment 112 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/48f8231ded1714a35a870bcd690932c01e2a6522

commit 48f8231ded1714a35a870bcd690932c01e2a6522
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 29 19:37:06 2018

[3pp] Fix pip_bootstrap.

  * Add `if __name__ == '__main__'` incantation. Not sure how this got
    lost, but without it, pip_bootstrap is completely non-functional.
  * Add `-vvv` for extra debugging help.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I14a9d4482c2f601548d3877306084e03d43400f4
Reviewed-on: https://chromium-review.googlesource.com/c/1303495
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18620}
[modify] https://crrev.com/48f8231ded1714a35a870bcd690932c01e2a6522/3pp/pip_bootstrap/pip_bootstrap.py
[modify] https://crrev.com/48f8231ded1714a35a870bcd690932c01e2a6522/3pp/pip_bootstrap/3pp.pb

Project Member

Comment 114 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e0a572cc5a7c280d9b0ced71ddc1d872c5b5923e

commit e0a572cc5a7c280d9b0ced71ddc1d872c5b5923e
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 29 22:51:19 2018

[3pp/pip_bootstrap] Do not try building on windows.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I13f07fb6b70f9ecbabd101606b818f101d0aa5aa
Reviewed-on: https://chromium-review.googlesource.com/c/1306279
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18628}
[modify] https://crrev.com/e0a572cc5a7c280d9b0ced71ddc1d872c5b5923e/3pp/pip_bootstrap/3pp.pb

Project Member

Comment 115 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f21295be865c733ccd94a9f769a49de01fbb03e1

commit f21295be865c733ccd94a9f769a49de01fbb03e1
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 29 23:45:26 2018

[3pp/help2man] Run make before make install.

Because Makefile dependencies are too hard to do correctly, I guess.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I2fe99ddd5273c84fd3970060cbd35a682b73c191
Reviewed-on: https://chromium-review.googlesource.com/c/1306854
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18629}
[modify] https://crrev.com/f21295be865c733ccd94a9f769a49de01fbb03e1/3pp/help2man/install.sh

Project Member

Comment 116 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d284423b1740937fb2d518716fe2f3da71f8dcff

commit d284423b1740937fb2d518716fe2f3da71f8dcff
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 30 20:28:24 2018

[3pp] Only fetch gae_go_sdk on intel architectures.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: Ifa2acf62fde8b60805bbb8f00e88a0a84da3fb05
Reviewed-on: https://chromium-review.googlesource.com/c/1308775
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18663}
[modify] https://crrev.com/d284423b1740937fb2d518716fe2f3da71f8dcff/3pp/gae_go_sdk/3pp.pb
[modify] https://crrev.com/d284423b1740937fb2d518716fe2f3da71f8dcff/3pp/gae_go_sdk/fetch.py

Project Member

Comment 117 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/707385930f38b62c54cd99e49a5b23a9bdbda5ea

commit 707385930f38b62c54cd99e49a5b23a9bdbda5ea
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 30 21:42:37 2018

[3pp] Texinfo not needed on non-intel platforms.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: Iff82e13a627650bc050415384bf86131b03b7bd7
Reviewed-on: https://chromium-review.googlesource.com/c/1308540
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18666}
[modify] https://crrev.com/707385930f38b62c54cd99e49a5b23a9bdbda5ea/3pp/texinfo/3pp.pb

Project Member

Comment 118 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0f7cff23f6efd5e3ccf170881ac78c1dfde147e2

commit 0f7cff23f6efd5e3ccf170881ac78c1dfde147e2
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 30 21:56:47 2018

[3pp] Binutils not needed on non-intel platforms.

TBR=tandrii@chromium.org

Bug: 877775
Change-Id: I7c7fd220852077a712fe44190ec28ac33659eec8
Reviewed-on: https://chromium-review.googlesource.com/c/1308544
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18668}
[modify] https://crrev.com/0f7cff23f6efd5e3ccf170881ac78c1dfde147e2/3pp/binutils/3pp.pb

Project Member

Comment 119 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3504a477dc0725fe867dc66f0079c92ad06f5177

commit 3504a477dc0725fe867dc66f0079c92ad06f5177
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 31 19:11:11 2018

[3pp] Disable cpython3 on windows for now.

TBR=tandrii@chromium.org

Bug: 877775,898348
Change-Id: I49ef14581e530cc87125fb87629fe469960b3016
Reviewed-on: https://chromium-review.googlesource.com/c/1309090
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18700}
[modify] https://crrev.com/3504a477dc0725fe867dc66f0079c92ad06f5177/3pp/cpython3/3pp.pb

Project Member

Comment 120 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8378afda2ed1ac364318b4d6b3038a211d7a6b54

commit 8378afda2ed1ac364318b4d6b3038a211d7a6b54
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 31 19:39:06 2018

[3pp] Fix pip_bootstrap to use correct abspath.

This was previously still picking up the system's version of `pip` :(.

TBR=tandrii@chromium.org

Bug: 877775,898348
Change-Id: If4bd1e581cbea07544a4f08c6a6f917347139b52
Reviewed-on: https://chromium-review.googlesource.com/c/1310522
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18701}
[modify] https://crrev.com/8378afda2ed1ac364318b4d6b3038a211d7a6b54/3pp/cpython/install.sh
[modify] https://crrev.com/8378afda2ed1ac364318b4d6b3038a211d7a6b54/3pp/pip_bootstrap/pip_bootstrap.py
[modify] https://crrev.com/8378afda2ed1ac364318b4d6b3038a211d7a6b54/3pp/cpython3/install.sh

Project Member

Comment 121 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/634ca322988683f78a5a5714c0fb920826ad65f3

commit 634ca322988683f78a5a5714c0fb920826ad65f3
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 31 22:42:25 2018

[3pp] Actually, the interpreter selection was correct before.

Forgot that we can't always use the built interpreter when
cross-compiling.

TBR=tandrii@chromium.org

Bug: 877775,898348
Change-Id: I5accf243d00ea3a2cf6e2873ac4cce599e569ed5
Reviewed-on: https://chromium-review.googlesource.com/c/1311476
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18709}
[modify] https://crrev.com/634ca322988683f78a5a5714c0fb920826ad65f3/3pp/cpython/install.sh
[modify] https://crrev.com/634ca322988683f78a5a5714c0fb920826ad65f3/3pp/cpython3/install.sh

Project Member

Comment 122 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6ba7148b5f37a5bdca97b9a3948db359dd865aa5

commit 6ba7148b5f37a5bdca97b9a3948db359dd865aa5
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 31 23:05:36 2018

[3pp] Backport $PYTHONEXE from cpython3, too.

TBR=tandrii@chromium.org

Bug: 877775,898348
Change-Id: I4485f1bc52fe00a5cccc23b6347d905ae44aa286
Reviewed-on: https://chromium-review.googlesource.com/c/1311735
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18711}
[modify] https://crrev.com/6ba7148b5f37a5bdca97b9a3948db359dd865aa5/3pp/cpython/install.sh

Project Member

Comment 123 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/63116a418913c0f2b4f6838a5c16a74f01bc7d90

commit 63116a418913c0f2b4f6838a5c16a74f01bc7d90
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 31 23:59:34 2018

[3pp] Remove _tkinter from OS X modules.

TBR=tandrii@chromium.org

Bug: 877775,898348
Change-Id: I0696c90fe6ee5d2720bb8f746280110ebe34d368
Reviewed-on: https://chromium-review.googlesource.com/c/1311739
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18715}
[modify] https://crrev.com/63116a418913c0f2b4f6838a5c16a74f01bc7d90/3pp/cpython3/install.sh

Project Member

Comment 124 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6cba6ecc21d1ffacba3b5123c44360339851632a

commit 6cba6ecc21d1ffacba3b5123c44360339851632a
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Nov 02 06:11:57 2018

[3pp] Remove cert.pem file hack from cpython3 on mac.

This is much less hacky than the previous scheme (though the subprocess
bit is still a bit janky). I looked into calling the functions in
Security.framework directly, but it looked like a lot more code than I
was willing to deal with currently.

R=tandrii@chromium.org

Bug: 877775,898348
Change-Id: I879c504a8d6793514b3db8ddce93260860b5810b
Reviewed-on: https://chromium-review.googlesource.com/c/1313661
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18751}
[rename] https://crrev.com/6cba6ecc21d1ffacba3b5123c44360339851632a/3pp/cpython3/python_ssl_suffix.py3
[modify] https://crrev.com/6cba6ecc21d1ffacba3b5123c44360339851632a/3pp/cpython3/install.sh

Project Member

Comment 125 by bugdroid1@chromium.org, Nov 3

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4405276722315f47d916b3bab2418689945b05e6

commit 4405276722315f47d916b3bab2418689945b05e6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Nov 03 00:35:47 2018

[3pp] SSL hack version 3

Using the power of ctypes, we now load the certs directly from the OS
Keychain via Security.framework. This is a modernized version of what
the `security` tool was doing anyway (SecItemCopyMatching is the
modernized version of SecKeychainSearchCreateFromAttributes, which is
how the `security` tool does it).

Source for `security` tool (see `do_keychain_find_certificate`):
https://opensource.apple.com/source/Security/Security-58286.70.7/SecurityTool/keychain_find.c.auto.html

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I43e638f25314209b91eb5aaa94fffcd510f4b7a9
Reviewed-on: https://chromium-review.googlesource.com/c/1315835
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18773}
[modify] https://crrev.com/4405276722315f47d916b3bab2418689945b05e6/3pp/cpython3/python_ssl_suffix.py3

Project Member

Comment 126 by bugdroid1@chromium.org, Nov 3

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3b0d923d5ca1e095f42e73509033c2bdedf93450

commit 3b0d923d5ca1e095f42e73509033c2bdedf93450
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Nov 03 04:45:39 2018

[3pp] Add root certs keychain too.

This adds Apple's root certificate keychain as well. The end result of
this is that it will pick up (in order):
  * Certs defined for the current logged-in user
  * Certs defined for the "System" (i.e. sysadmins add stuff here)
  * Certs defined for the "SystemRoot" (i.e. Apple adds stuff here)

In addition, we now only load certs from the system once per process, caching
them at ssl._system_cert_pem.

This CL refactors the _attach_cacert_bundle() function to factor out the linux
and OS X paths, as they've diverged substantially.

TBR=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: Ia84af00b5257e4609b9e304d02f60559d16f8cc5
Reviewed-on: https://chromium-review.googlesource.com/c/1316421
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18782}
[modify] https://crrev.com/3b0d923d5ca1e095f42e73509033c2bdedf93450/3pp/cpython3/python_ssl_suffix.py3

Project Member

Comment 127 by bugdroid1@chromium.org, Nov 3

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/46b441a5dafe101672ab0b8fdd29a0ad0cba6210

commit 46b441a5dafe101672ab0b8fdd29a0ad0cba6210
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Nov 03 07:22:07 2018

[3pp/cpython3] Fixups to python_ssl_suffix.py3.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I39f28b3751d4495eab2018dd9edf6eab8b1c302c
Reviewed-on: https://chromium-review.googlesource.com/c/1316426
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18783}
[modify] https://crrev.com/46b441a5dafe101672ab0b8fdd29a0ad0cba6210/3pp/cpython3/python_ssl_suffix.py3

Project Member

Comment 128 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/525d4f7425ef5fd636241fd1f9cd8426349b726a

commit 525d4f7425ef5fd636241fd1f9cd8426349b726a
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Nov 12 23:48:45 2018

[3pp] Work around `git cl issue --json -` brokenness.

R=tandrii@chromium.org

Bug: 877775
Change-Id: I6311f3c196b163af13ac9c17a0fa5163a67dc4eb
Reviewed-on: https://chromium-review.googlesource.com/c/1330872
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18936}
[modify] https://crrev.com/525d4f7425ef5fd636241fd1f9cd8426349b726a/3pp/run_remotely.sh

Blocking: 879378
Labels: -Pri-2 Pri-1
Raising to P1, as this blocks P1 Issue 879378, which blocks P1  Issue 869557 .

Thanks in advance for fixing this.

As a detailed update, we do actually have a cpython package for arm (and cpython3, for bonus points). The only work blocking parity between 3pp and the old builder is a cpython package for windows (which I've completed as of yesterday and will be sending for review today).
Robbie, could you please take a look at https://chromium-swarm.appspot.com/task?id=41289b4ce2a19910&refresh=10&show_raw=1?
Looks like the platform that we need cpython for is armv6l, and it's missing there.
Failed to resolve package infra/python/cpython/linux-armv6l@version:2.7.14.chromium14: no such package
We don't have that package deployed yet. It will indeed fail until we do.
Project Member

Comment 134 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/afb73e25494edc5b251d3214095f8e0d54f33ded

commit afb73e25494edc5b251d3214095f8e0d54f33ded
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Nov 15 22:47:09 2018

[3pp] Add lessmsi.

This will be used for cpython for windows to extract files from the .msi
installer without having to run it.

R=tandrii@chromium.org

Bug: 877775,898348
Change-Id: I3bb710bfa7c4043507badfdddc853f74d4a9fbd8
Reviewed-on: https://chromium-review.googlesource.com/c/1335178
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19031}
[add] https://crrev.com/afb73e25494edc5b251d3214095f8e0d54f33ded/3pp/lessmsi/3pp.pb
[add] https://crrev.com/afb73e25494edc5b251d3214095f8e0d54f33ded/3pp/lessmsi/fetch_win.py

Project Member

Comment 135 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/522debceb9aeba7dbce7f811687a640656d4e8cd

commit 522debceb9aeba7dbce7f811687a640656d4e8cd
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Nov 16 01:20:59 2018

[3pp] Add cpython support on windows.

R=tandrii@chromium.org

Change-Id: I5fbe461275e5a311161a5e8c1be676fc7ab80cf5
Bug: 877775,898348
Reviewed-on: https://chromium-review.googlesource.com/c/1318711
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19039}
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/run_remotely.sh
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/cpython3/python_test.py
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/cpython/3pp.pb
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/git/git_test.py
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/pip_bootstrap/pip_bootstrap.py
[add] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/cpython/fetch.py
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/cpython/python_test.py
[add] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/cpython/install_win.sh
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/pip_bootstrap/3pp.pb

Project Member

Comment 136 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2c6cb2caf5deaab82849c7f3f3d5ed035352f28a

commit 2c6cb2caf5deaab82849c7f3f3d5ed035352f28a
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Nov 22 01:31:12 2018

[dockerbuild] Fix lacking autogen.sh invocation in libffi build

The libffi source changed (because of my own stupidity), and I didn't
update the dockcross scripts to account for that.

In particular, the version of the libffi source previously uploaded
was a derived 'dist' version which didn't work with OS X. I re-uploaded
the non-derived source tarball, but it requires an 'automake' step which
the baked distribution doesn't (incedentally, this is the reason why the
baked version DOESN'T work on OS X).

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I074b7a167e2562ae936af41e33a8c1242b909d6a
Reviewed-on: https://chromium-review.googlesource.com/c/1347303
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19134}
[modify] https://crrev.com/2c6cb2caf5deaab82849c7f3f3d5ed035352f28a/infra/tools/dockerbuild/resources/install-00-packages.sh
[modify] https://crrev.com/2c6cb2caf5deaab82849c7f3f3d5ed035352f28a/infra/tools/dockerbuild/dockcross.py
[modify] https://crrev.com/2c6cb2caf5deaab82849c7f3f3d5ed035352f28a/infra/tools/dockerbuild/resources/install-02-cross-lib.sh

Labels: LUCI-Afterglow

Comment 138 by iannu...@google.com, Jan 16 (6 days ago)

Blockedon: 914572

Comment 139 by iannu...@google.com, Jan 16 (6 days ago)

Blocking: 887141
Showing comments 40 - 139 of 139 Older

Sign in to add a comment