New issue
Advanced search Search tips

Issue 877766 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in fxcrt::UnownedPtr<unsigned char>::ProbeForLowSeverityLifetimeIssue

Project Member Reported by ClusterFuzz, Aug 25

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5147696374218752

Fuzzer: libFuzzer_pdf_codec_gif_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Heap-use-after-free READ 1
Crash Address: 0x602000001210
Crash State:
  fxcrt::UnownedPtr<unsigned char>::ProbeForLowSeverityLifetimeIssue
  fxcrt::UnownedPtr<unsigned char>::~UnownedPtr
  pdfium::span<unsigned char>::~span
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=586043:586054

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5147696374218752

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 25

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by ClusterFuzz, Aug 25

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Aug 25

Labels: Test-Predator-Auto-Owner
Owner: tsepez@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/16d18d935d055b74e05f615c0325318a329a7fe1 (Use span<uint8_t> in more fxcodec code.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 25

Labels: Pri-1
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 26

Labels: Target-70 M-70
Cc: thestig@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4dc206954d7c88823930d881b457ed8a6d93513

commit f4dc206954d7c88823930d881b457ed8a6d93513
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Aug 28 21:43:45 2018

Roll src/third_party/pdfium f2615a38d963..7e4fff716338 (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/f2615a38d963..7e4fff716338


git log f2615a38d963..7e4fff716338 --date=short --no-merges --format='%ad %ae %s'
2018-08-28 tsepez@chromium.org Let CCodec_ProgressiveDecoder::m_pSrcBuf outlive contexts


Created with:
  gclient setdep -r src/third_party/pdfium@7e4fff716338

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:877766 
TBR=dsinclair@chromium.org

Change-Id: I592a37dc83bc9386200ccc2a79189d735be8a04d
Reviewed-on: https://chromium-review.googlesource.com/1194267
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586862}
[modify] https://crrev.com/f4dc206954d7c88823930d881b457ed8a6d93513/DEPS

Project Member

Comment 8 by ClusterFuzz, Aug 29

ClusterFuzz has detected this issue as fixed in range 586859:586865.

Detailed report: https://clusterfuzz.com/testcase?key=5147696374218752

Fuzzer: libFuzzer_pdf_codec_gif_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Heap-use-after-free READ 1
Crash Address: 0x602000001210
Crash State:
  fxcrt::UnownedPtr<unsigned char>::ProbeForLowSeverityLifetimeIssue
  fxcrt::UnownedPtr<unsigned char>::~UnownedPtr
  pdfium::span<unsigned char>::~span
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=586043:586054
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=586859:586865

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5147696374218752

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Aug 29

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5147696374218752 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 29

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 5

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment