New issue
Advanced search Search tips

Issue 877761 link

Starred by 1 user
Status: Fixed
Owner:
sadrul@chromium.org
Closed: Aug 27
Cc:
chiniforooshan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Many rendering tests are failing

Project Member Reported by nednguyen@chromium.org, Aug 25 
Build: https://ci.chromium.org/buildbot/chromium.perf/android-nexus5x-perf/291

The error message is:

https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/b34c012c-a836-11e8-a116-0242ac110006

(WARNING) 2018-08-25 07:02:13,452 model._CreateImporters:259  No importer found for TraceDataPart("telemetry")
(ERROR) 2018-08-25 07:02:21,369 page_test_results.Fail:540  Failure recorded: TypeError: Cannot read property 'process' of undefined
    at getDisplayCompositorThread_ (/tracing/metrics/rendering/pipeline.html:84:25)
    at Object.addPipelineHistograms (/tracing/metrics/rendering/pipeline.html:114:22)
    at new renderingMetric (/tracing/metrics/rendering/rendering_metric.html:87:26)
    at runMetrics (/b/swarming/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:61:16)
    at metricMapFunction (/b/swarming/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:190:24)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:39:7)
    at eval (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:24:10)
    at mapSingleTraceWithResult (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:77:20)

Comment 1 by chiniforooshan@chromium.org, Aug 26

Cc: -sadrul@chromium.org chiniforooshan@chromium.org
Owner: sadrul@chromium.org
Status: Assigned (was: Untriaged)
sadrul@, could you please take a look at this.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/b6bda5336f20ee25e35e76ec8b1313d1c8b567c4

commit b6bda5336f20ee25e35e76ec8b1313d1c8b567c4
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Mon Aug 27 02:02:36 2018

rendering: Fix for null browser thread.

It turns out the browser may not be emitting any trace events,
and so the helper may not find any browser process/thread.

BUG= chromium:877761 

Change-Id: Ia5c9f2e1c41f5910a1427b67c11cd0bf19706740
Reviewed-on: https://chromium-review.googlesource.com/1188394
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/b6bda5336f20ee25e35e76ec8b1313d1c8b567c4/tracing/tracing/metrics/rendering/pipeline.html
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecb219610389380bc08bc35a54f3231f7ca903e2

commit ecb219610389380bc08bc35a54f3231f7ca903e2
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Aug 27 05:20:51 2018

Roll src/third_party/catapult bc2c0a930728..b6bda5336f20 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/bc2c0a930728..b6bda5336f20


git log bc2c0a930728..b6bda5336f20 --date=short --no-merges --format='%ad %ae %s'
2018-08-27 sadrul@chromium.org rendering: Fix for null browser thread.


Created with:
  gclient setdep -r src/third_party/catapult@b6bda5336f20

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:877761 
TBR=sullivan@chromium.org

Change-Id: I693be47b4ca1ab080ad61d54051c782c77c2f69f
Reviewed-on: https://chromium-review.googlesource.com/1188807
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586196}
[modify] https://crrev.com/ecb219610389380bc08bc35a54f3231f7ca903e2/DEPS

Comment 4 by sadrul@chromium.org, Aug 27

Status: Fixed (was: Assigned)
Looks like the rendering.mobile benchmark is no longer failing on the bots (e.g. https://ci.chromium.org/buildbot/chromium.perf/android-nexus5x-perf/307) So marking as fixed.
►

Sign in to add a comment