New issue
Advanced search Search tips

Issue 877754 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: false in texture_manager.cc

Project Member Reported by ClusterFuzz, Aug 25

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6555029214068736

Fuzzer: libFuzzer_gpu_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false in texture_manager.cc
  gpu::gles2::Texture::SetParameterf
  gpu::gles2::TextureManager::SetParameterf
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=512661:512688

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6555029214068736

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 25

Components: Internals>GPU>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Aug 25

Labels: Test-Predator-Auto-Owner
Owner: piman@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/72bb29070e415e215e2a0095b9266c3ec1c75599 (gpu fuzzers: take configuration bits from input data).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
This crash happens quite often. It would be really awesome to fix it and unblock the fuzzer. Please feel free to submit the fix as go/fuzzathon participation!
Will look at it.
Cc: zmo@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1343357 should fix this.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7afae31e2f46d8234c541cf137f6b8ae8b8a7eb7

commit 7afae31e2f46d8234c541cf137f6b8ae8b8a7eb7
Author: Antoine Labour <piman@chromium.org>
Date: Mon Nov 19 23:16:08 2018

Correctly handle some invalid enums in TexParameterf

GL_REQUIRED_TEXTURE_IMAGE_UNITS_OES is a "get"-only enum, so even though
it may be accepted by the texture_paramter validator (which has both
"set" and "get" enums, as they are mostly the same), we need to handle
it in Texture::SetParameter* and return GL_INVALID_ENUM.
Some enums (e.g. GL_TEXTURE_SRGB_DECODE_EXT) were only handled in

Texture::SetParameteri, so rework this a bit so that SetParameterf
always delegates everything (including error cases) to SetParameteri,
except for float params (which are only a handful), to avoid most of the
duplication.

Bug:  877754 
Change-Id: I15c52f81e62544f90a15b914113c5c4816530cdb
Reviewed-on: https://chromium-review.googlesource.com/c/1343357
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609492}
[modify] https://crrev.com/7afae31e2f46d8234c541cf137f6b8ae8b8a7eb7/gpu/command_buffer/service/texture_manager.cc

Project Member

Comment 7 by ClusterFuzz, Nov 20

ClusterFuzz has detected this issue as fixed in range 609491:609495.

Detailed report: https://clusterfuzz.com/testcase?key=6555029214068736

Fuzzer: libFuzzer_gpu_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false in texture_manager.cc
  gpu::gles2::Texture::SetParameterf
  gpu::gles2::TextureManager::SetParameterf
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=512661:512688
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=609491:609495

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6555029214068736

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Nov 20

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6555029214068736 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment