New issue
Advanced search Search tips

Issue 877750 link

Starred by 1 user
Status: Verified
Owner:
alemate@chromium.org
Closed: Aug 28
Cc:
wzang@chromium.org
ovanieva@chromium.org
kathrelk...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 812037



Sign in to add a comment

Hide Discover app in public sessions

Project Member Reported by michae...@chromium.org, Aug 25 
Chrome Version: 70.0.3533.0

The built-in "Discover" app shouldn't be available in public sessions or Demo Mode, since there's no signed-in user and nothing to set up.

Is it available in guest sessions too?

Comment 1 by michae...@chromium.org, Aug 25

Cc: -ovanieva@google.com ovanieva@chromium.org

Comment 2 by alemate@chromium.org, Aug 27

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46865d18791b2b3089ae0afb3c7573b39751332e

commit 46865d18791b2b3089ae0afb3c7573b39751332e
Author: Alexander Alekseev <alemate@chromium.org>
Date: Tue Aug 28 05:13:42 2018

Chrome OS launcher app list: show Discover app for non-ephemeral users only.

This CL makes GetInternalAppList() receive Profile*, and then decide
on its own whether to add particular app.

Discover app is now shown to non-Ephemeral sessions only.

TBR=vitaliii@chromium.org

Bug:  877750 
Change-Id: Ieb93fc8d4cdd91d1e5161355c33f1af7cc017784
Reviewed-on: https://chromium-review.googlesource.com/1190124
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586587}
[modify] https://crrev.com/46865d18791b2b3089ae0afb3c7573b39751332e/chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc
[modify] https://crrev.com/46865d18791b2b3089ae0afb3c7573b39751332e/chrome/browser/ui/app_list/app_context_menu_unittest.cc
[modify] https://crrev.com/46865d18791b2b3089ae0afb3c7573b39751332e/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc
[modify] https://crrev.com/46865d18791b2b3089ae0afb3c7573b39751332e/chrome/browser/ui/app_list/internal_app/internal_app_metadata.h
[modify] https://crrev.com/46865d18791b2b3089ae0afb3c7573b39751332e/chrome/browser/ui/app_list/internal_app/internal_app_model_builder.cc
[modify] https://crrev.com/46865d18791b2b3089ae0afb3c7573b39751332e/chrome/browser/ui/app_list/internal_app/internal_app_model_builder_unittest.cc
[modify] https://crrev.com/46865d18791b2b3089ae0afb3c7573b39751332e/chrome/browser/ui/app_list/search/app_search_provider.cc
[modify] https://crrev.com/46865d18791b2b3089ae0afb3c7573b39751332e/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/46865d18791b2b3089ae0afb3c7573b39751332e/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

Comment 4 by alemate@chromium.org, Aug 28

Status: Fixed (was: Started)

Comment 5 by chchakrapani@chromium.org, Aug 30 

Michael, 
Could you share link for the Discover app.?

Comment 6 by chchakrapani@chromium.org, Sep 4

Cc: kathrelk...@chromium.org

Comment 7 by chchakrapani@chromium.org, Sep 6

Status: Verified (was: Fixed)
Thanks Michael,

Checked on Google Chrome:70.0.3538.7 Platform: 11021.5.0 and observed Discover app is not seen in Demo mode session. 
Hence, closing the bug as verified.
Screenshot 2018-09-05 at 4.52.49 PM.png
384 KB View Download
►

Sign in to add a comment