chromeos-chrome ebuild: allow syncing in ebuild on bots |
|||||||
Issue descriptionAt Request of Don Garrett I believe we have a change in behavior in the chomeos-chrome ebuild that requires you to explictly set the "sync_chrome=True" in your build config. You are the second person to have a similar issue recently. I believe it is correct behavior for chromeos-chrome to automatically fetch the chrome source if the builder does not do so, and I'm not certain why it doesn't. I would appreciate a bug asking for the chromeos-chrome ebuild to fetch chrome source if necessary.
,
Aug 25
,
Aug 25
Submitting to the Build team bug triage.
,
Aug 25
doesn't seem like a recent change. it's been this way since Aug 2014: https://chromium-review.googlesource.com/214263 seems like we want to keep the behavior where chrome sync must happen outside the ebuild, especially for infra hermetic reasons
,
Sep 4
,
Sep 25
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/7d1a38e701bf05413717481b5c637510591d1467 commit 7d1a38e701bf05413717481b5c637510591d1467 Author: Bob Moragues <moragues@google.com> Date: Tue Sep 25 16:53:54 2018 nocturne: set up factory branch PFQ Add sync_chrome=True as a work around BUG=b:77727564, chromium:877721 TEST=none Change-Id: I15971e0a75e38038bfaa4a4e6d39179d0955809f Reviewed-on: https://chromium-review.googlesource.com/1243687 Reviewed-by: Nick Sanders <nsanders@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org> Commit-Queue: Bob Moragues <moragues@chromium.org> Tested-by: Bob Moragues <moragues@chromium.org> [modify] https://crrev.com/7d1a38e701bf05413717481b5c637510591d1467/config/chromeos_config.py [modify] https://crrev.com/7d1a38e701bf05413717481b5c637510591d1467/config/config_dump.json |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by moragues@chromium.org
, Aug 25