New issue
Advanced search Search tips

Issue 877709 link

Starred by 1 user
Status: Fixed
Owner:
jzw@chromium.org
Closed: Oct 12
Cc:
droger@chromium.org
eugene...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove performance placeholder

Project Member Reported by jzw@chromium.org, Aug 24 
In js_translate_manager.mm:

// The translation script uses performance.now() for metrics, which is not
// supported except on iOS 8.0. To make the translation script work on these
// iOS versions, add some JavaScript to |script| that defines an
// implementation of performance.now().

Doubt we support iOS 8 anymore, so let's just remove this.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0571166a1973122db34bb249e69bab3bc2210db

commit c0571166a1973122db34bb249e69bab3bc2210db
Author: John Z Wu <jzw@chromium.org>
Date: Fri Aug 31 15:36:17 2018

Clean up Performance placeholder API for translate.

performance.now() is in WKWebView now.

Bug:  877709 
Change-Id: I2717df09894049105e159e50b62a91bf12faf929
Reviewed-on: https://chromium-review.googlesource.com/1188491
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588029}
[modify] https://crrev.com/c0571166a1973122db34bb249e69bab3bc2210db/components/translate/ios/browser/js_translate_manager.mm
[modify] https://crrev.com/c0571166a1973122db34bb249e69bab3bc2210db/components/translate/ios/browser/js_translate_manager_unittest.mm

Comment 2 by jzw@chromium.org, Oct 12

Status: Fixed (was: Available)
►

Sign in to add a comment