New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 877705 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility

Blocked on:
issue 839035


Participants' hotlists:
Hotlist-3


Sign in to add a comment

Chrome://accessibility links collapse tree instead of re-rerendering in place

Project Member Reported by leberly@chromium.org, Aug 24

Issue description

Google Chrome	70.0.3524.2 (Official Build) dev (64-bit)
Firmware Version Google_Lulu.6301.136.57

# Navigate to chrome://accessibility
# Click "show accessibility tree" for any tab
# Tree expands
# Click on any of the links such as native:false
Expected: tree is re-rendered in place
Actual: tree region collapses 

This may be contributing to the screen reader user confusion around these links mentioned in bug 842891. 
 
Labels: a11y-WebUI a11y-internals
Blockedon: 839035
Like 839035, this is caused by the fact that we do a page refresh in each case. We could probably do something smarter since "showTree()" (https://cs.chromium.org/chromium/src/chrome/browser/resources/accessibility/accessibility.js?type=cs&q=toggleAccessibility&sq=package:chromium&g=0&l=250) rewrites the tree anyway.
(Not actually blocked by 839035, just wanted to link them together)
Labels: pm-markchang
Labels: pm-markchang
Labels: -PM-markchang
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c409c0daecbfb353ca9fb64c1791284065724481

commit c409c0daecbfb353ca9fb64c1791284065724481
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Fri Oct 19 22:54:29 2018

chrome://accessibility: Don't refresh page on ToggleAccessibility

When the accessibility mode is toggled for individual pages, update the
single row by calling showTree rather than refreshing the whole page.

Bug:  877705 
Change-Id: I5c7986fc970f9789bb421525ccea5f68f5fd57e9
Reviewed-on: https://chromium-review.googlesource.com/c/1269236
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601338}
[modify] https://crrev.com/c409c0daecbfb353ca9fb64c1791284065724481/chrome/browser/accessibility/accessibility_ui.cc
[modify] https://crrev.com/c409c0daecbfb353ca9fb64c1791284065724481/chrome/browser/resources/accessibility/accessibility.js

Owner: jamwalla@chromium.org
Status: Fixed (was: Available)
Cc: shrijap@google.com
Labels: -Pri-2 Pri-1
Repro the above bug in Canary channel with the below details:

Google Chrome: 72.0.3618.0 (Official Build) canary (64-bit)
Revision: 473cb3615ccd757dbfd816963e699299a0732b59-refs/branch-heads/3618@{#1}
Platform: 11298.0.0 (Official Build) canary-channel samus
Firmware Version:Google_Samus.6300.276.0
ARC: 5143797
JavaScript:V8 7.2.391
Flash:	31.0.0.153 /opt/google/chrome/pepper/libpepflashplayer.so
User Agent: Mozilla/5.0 (X11; CrOS x86_64 11298.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3618.0 Safari/537.36
 

# Navigate to chrome://accessibility
# Click "show accessibility tree" for any tab
# Tree expands
# Click on any of the links such as native:false
Expected: tree is re-rendered in place

Actual: Chrome Crashes completely

So bumping up this bug to P1 

Cc: dmazzoni@google.com lpalmaro@chromium.org
++ Dominic and Laura A

Sign in to add a comment