[Harmony Cast Dialog] Use the correct stop icon |
||
Issue descriptionWe need to get the stop icon used in mocks (square inside a circle), and use it here: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc?type=cs&q=%22todo(takumif)%22&l=92
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51682ae080e81a4f8e406fba817d59eae19434b0 commit 51682ae080e81a4f8e406fba817d59eae19434b0 Author: John Williams <jrw@google.com> Date: Wed Oct 03 23:25:04 2018 Added correct "stop" icon for Media Router. Bug: 877702 Change-Id: Ifdd3355c2d9d0fb46fed19c21cbe2a066abf6ad4 Reviewed-on: https://chromium-review.googlesource.com/c/1239010 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#596417} [modify] https://crrev.com/51682ae080e81a4f8e406fba817d59eae19434b0/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/51682ae080e81a4f8e406fba817d59eae19434b0/chrome/app/vector_icons/stop.icon [modify] https://crrev.com/51682ae080e81a4f8e406fba817d59eae19434b0/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d46559eedc2224b24718c9c62ac21b3799d49861 commit d46559eedc2224b24718c9c62ac21b3799d49861 Author: Daniel Bratell <bratell@opera.com> Date: Thu Oct 04 10:05:42 2018 kStopIcon is a constant in the OSX APIs so rename kGenericStopIcon Jumbo Mac fyi builder broke when a kStopIcon was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1239010 because the OSX API has a kStopIcon in .../MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/Dialogs.h This renames it to kGenericStopIcon to make the builds go again. TBR=jrw@chromium.org,estade@chromium.org Bug: 877702 Change-Id: Id6c675b539f8e3161ef322bf008174ec2911d4be Reviewed-on: https://chromium-review.googlesource.com/c/1261042 Reviewed-by: Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#596571} [modify] https://crrev.com/d46559eedc2224b24718c9c62ac21b3799d49861/chrome/app/vector_icons/BUILD.gn [rename] https://crrev.com/d46559eedc2224b24718c9c62ac21b3799d49861/chrome/app/vector_icons/generic_stop.icon [modify] https://crrev.com/d46559eedc2224b24718c9c62ac21b3799d49861/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc
,
Oct 4
The CL landed, so I'm going to close this bug.
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c36f440d1e01957f741bbf0f3d91be43ec10caa3 commit c36f440d1e01957f741bbf0f3d91be43ec10caa3 Author: Daniel Bratell <bratell@opera.com> Date: Tue Oct 09 15:51:40 2018 Add a comment to generic_stop.icon to explain why it's not stop.icon The file was added as stop.icon which broke some builds, was renamed generic_stop.icon to unbreak those builds. See https://chromium-review.googlesource.com/c/chromium/src/+/1261042 R=estade@chromium.org Bug: 877702 Change-Id: If90932dac4868053748e25f2d0f0dd15876087cc Reviewed-on: https://chromium-review.googlesource.com/c/1269730 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#597928} [modify] https://crrev.com/c36f440d1e01957f741bbf0f3d91be43ec10caa3/chrome/app/vector_icons/generic_stop.icon |
||
►
Sign in to add a comment |
||
Comment 1 by jrw@chromium.org
, Sep 21