New issue
Advanced search Search tips

Issue 877660 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Run WCT tests in catapult

Project Member Reported by benjhayden@chromium.org, Aug 24

Issue description

Chromeperf dashboard V2 depends on Polymer2, so its tests cannot use the existing UI test framework, which only supports Polymer1.

ChOps provides a wct runner that could replace catapult's run_dev_server_tests.
A new script dashboard/bin/run_wct_tests would run the wct runner.
Catapult can install web-component-tester in third_party via bower.
https://chromium-review.googlesource.com/c/catapult/+/1184050

Devs can install ChOps' wct runner in our PATHs, but Catapult's trybot recipe needs to provide the wct runner to run_wct_tests.
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1183891
See also https://bugs.chromium.org/p/chromium/issues/detail?id=836455

The wct runner needs to be extended to support multiple dependency directories.
https://chromium-review.googlesource.com/c/infra/infra/+/1188536


 
Components: Speed>Dashboard
Labels: -Pri-3 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/468bbea6fa23668b0e542d67f1ea66f59f48c591

commit 468bbea6fa23668b0e542d67f1ea66f59f48c591
Author: benshayden <benjhayden@chromium.org>
Date: Mon Aug 27 17:19:44 2018

Add web-component-tester to third_party.

This is required to test V2SPA. This is split out of
https://chromium-review.googlesource.com/c/catapult/+/1184050

Bug:  chromium:877660 
Change-Id: I691b61d3690fdeff8ec28d9e6a185373388bef64
Reviewed-on: https://chromium-review.googlesource.com/1188388
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>

[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/chai/karma.sauce.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/accessibility-developer-tools/bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/stacky/lib/index.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/chai/bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/CHANGELOG.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/lodash/.bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/test/common.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/lodash/lodash.min.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/web-component-tester/data/a11ySuite-npm-header.txt
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/web-component-tester/.bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/chai/CONTRIBUTING.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/.eslintrc.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/lib/sinon-chai.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/.eslintignore
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/test/callArguments.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/mocha/mocha.css
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/.travis.yml
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/stacky/lib/parsing.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/karma.conf.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/stacky/bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/LICENSE.txt
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/stacky/browser.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/web-component-tester/data/index.html
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/chai/package.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/lodash/LICENSE
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinonjs/sinon.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/README.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/mocha/bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/chai/README.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/mocha/LICENSE
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/web-component-tester/package.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/.gitignore
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/chai/chai.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/web-component-tester/data/a11ySuite.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/.bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/package-lock.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinonjs/.bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/chai/.bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/test-fixture.html
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/mocha_test/support/is_browser.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/lodash/bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/test/callingWithNew.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/stacky/LICENSE
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/chai/sauce.browsers.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/test-fixture-mocha.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/test/test-fixture.html
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/package.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/test/callOrder.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/chai/ReleaseNotes.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/.travis.yml
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/web-component-tester/bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/dist/async.min.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/deps/nodeunit.css
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/.editorconfig
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/package.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/chai/karma.conf.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/lib/async.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinonjs/README.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/accessibility-developer-tools/main.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/CONTRIBUTING.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/test/returning.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/mocha/.bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/perf/memory.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/web-component-tester/browser.js.map
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/test/callCount.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/.github/ISSUE_TEMPLATE.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/stacky/lib/formatting.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/test/index.html
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/dist/async.min.map
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/mocha_test/forever.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/chai/History.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/test/messages.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/stacky/.bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/mocha/mocha.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/dist/async.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/mocha_test/compose.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/accessibility-developer-tools/.bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinonjs/bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/deps/nodeunit.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/test/throwing.js
[modify] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/mocha/CHANGELOG.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/lodash/lodash.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/accessibility-developer-tools/LICENSE
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/web-component-tester/browser.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/package.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/accessibility-developer-tools/Changelog.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/accessibility-developer-tools/README.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/accessibility-developer-tools/dist/js/axs_testing.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/support/sync-package-managers.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/.bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/wct.conf.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/.gitignore
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/README.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/stacky/lib/normalization.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/LICENSE
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/chai/CODE_OF_CONDUCT.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/component.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/test/callContext.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/Makefile
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/mocha/README.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/README.md
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/test/regressions.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/perf/benchmark.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/perf/suites.js
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/async/.bower.json
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/test-fixture/test/handle-multiple-registrations.html
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/test/mocha.opts
[add] https://crrev.com/468bbea6fa23668b0e542d67f1ea66f59f48c591/third_party/polymer2/bower_components/sinon-chai/test/.eslintrc.json

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d4e3adf79b5ab9fc063c7e10dd6230bd522ed78

commit 5d4e3adf79b5ab9fc063c7e10dd6230bd522ed78
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Aug 28 00:09:06 2018

Roll src/third_party/catapult 9b4fbc6e4341..d0d714d0f2fc (4 commits)

https://chromium.googlesource.com/catapult.git/+log/9b4fbc6e4341..d0d714d0f2fc


git log 9b4fbc6e4341..d0d714d0f2fc --date=short --no-merges --format='%ad %ae %s'
2018-08-27 benjhayden@chromium.org Define CSS vars for V2SPA.
2018-08-27 dtu@chromium.org [pinpoint] Ignore comparison_magnitude == 'None' for patch jobs.
2018-08-27 zmo@chromium.org Hook up generate_telemetry_build.py to PRESUBMIT.py
2018-08-27 benjhayden@chromium.org Add web-component-tester to third_party.


Created with:
  gclient setdep -r src/third_party/catapult@d0d714d0f2fc

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:877096, chromium:872521 , chromium:877660 
TBR=sullivan@chromium.org

Change-Id: Iac0ca8d5f207af61bf173c68d57778ce1c6b91b7
Reviewed-on: https://chromium-review.googlesource.com/1192244
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586511}
[modify] https://crrev.com/5d4e3adf79b5ab9fc063c7e10dd6230bd522ed78/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9523f44056023d991fca3aadfb70ee1163c90548

commit 9523f44056023d991fca3aadfb70ee1163c90548
Author: Ben Hayden <benjhayden@chromium.org>
Date: Thu Aug 30 04:51:15 2018

Add WCT to catapult recipe.

The Chromeperf Dashboard V2 prototype currently uses Polymer2.
Catapult's UI test framework only supports Polymer1.
This CL provides WCT to catapult's trybot recipe to facilitate testing
V2SPA using WCT instead of catapult's existing UI test framework.

See also dashboard/bin/run_wct_tests:
https://chromium-review.googlesource.com/c/catapult/+/1184050

Bug:  877660 

Change-Id: I0bfb37b888050b3d1fad78fb4013360af1d6c6ff
Reviewed-on: https://chromium-review.googlesource.com/1183891
Commit-Queue: Ben Hayden <benjhayden@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>

[add] https://crrev.com/9523f44056023d991fca3aadfb70ee1163c90548/scripts/slave/recipe_modules/wct/OWNERS
[modify] https://crrev.com/9523f44056023d991fca3aadfb70ee1163c90548/scripts/slave/recipes/catapult.expected/basic.json
[add] https://crrev.com/9523f44056023d991fca3aadfb70ee1163c90548/scripts/slave/recipe_modules/wct/tests/full.expected/linux.json
[modify] https://crrev.com/9523f44056023d991fca3aadfb70ee1163c90548/scripts/slave/recipes/catapult.expected/android.json
[add] https://crrev.com/9523f44056023d991fca3aadfb70ee1163c90548/scripts/slave/recipe_modules/wct/tests/full.py
[add] https://crrev.com/9523f44056023d991fca3aadfb70ee1163c90548/scripts/slave/recipe_modules/wct/api.py
[modify] https://crrev.com/9523f44056023d991fca3aadfb70ee1163c90548/scripts/slave/README.recipes.md
[modify] https://crrev.com/9523f44056023d991fca3aadfb70ee1163c90548/scripts/slave/recipes/catapult.py
[add] https://crrev.com/9523f44056023d991fca3aadfb70ee1163c90548/scripts/slave/recipe_modules/wct/__init__.py
[add] https://crrev.com/9523f44056023d991fca3aadfb70ee1163c90548/scripts/slave/recipe_modules/wct/tests/full.expected/notlinux.json

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f274ebf2ef0b3981b2cff1d607e9ad9823675a2a

commit f274ebf2ef0b3981b2cff1d607e9ad9823675a2a
Author: Ben Hayden <benjhayden@chromium.org>
Date: Thu Aug 30 18:37:01 2018

Pass multiple directories of dependencies to wct.go

Currently, wct.go accepts baseDir and bowerDir. There is no way to serve files
from more than those 2 directories to tests.
Catapult needs to serve files from several directories:
https://chromium-review.googlesource.com/c/catapult/+/1184050
This CL generalizes `-bower` to a repeated flag `-dep`.

Bug:  877660 

Change-Id: I8a2dd81f6c0d6943d8fe5b78600140c07989dce3
Reviewed-on: https://chromium-review.googlesource.com/1188536
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17319}
[modify] https://crrev.com/f274ebf2ef0b3981b2cff1d607e9ad9823675a2a/go/src/infra/tools/wct/wct.go

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/bc3b5719c6b0b3a12fe23bc6813895ebf9f0fde6

commit bc3b5719c6b0b3a12fe23bc6813895ebf9f0fde6
Author: Ben Hayden <benjhayden@chromium.org>
Date: Thu Aug 30 19:06:38 2018

Revert "Add WCT to catapult recipe."

This reverts commit 9523f44056023d991fca3aadfb70ee1163c90548.

Reason for revert: Catapult CQ bots broken:
https://bugs.chromium.org/p/chromium/issues/detail?id=879116

Original change's description:
> Add WCT to catapult recipe.
>
> The Chromeperf Dashboard V2 prototype currently uses Polymer2.
> Catapult's UI test framework only supports Polymer1.
> This CL provides WCT to catapult's trybot recipe to facilitate testing
> V2SPA using WCT instead of catapult's existing UI test framework.
>
> See also dashboard/bin/run_wct_tests:
> https://chromium-review.googlesource.com/c/catapult/+/1184050
>
> Bug:  877660 
>
> Change-Id: I0bfb37b888050b3d1fad78fb4013360af1d6c6ff
> Reviewed-on: https://chromium-review.googlesource.com/1183891
> Commit-Queue: Ben Hayden <benjhayden@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Simon Hatch <simonhatch@chromium.org>

TBR=benjhayden@chromium.org,simonhatch@chromium.org,seanmccullough@chromium.org,tandrii@chromium.org

Change-Id: I449e2e41ae88fabf3488bc0a1a34fbe3caaed6bb
Bug:  877660 
Reviewed-on: https://chromium-review.googlesource.com/1196694
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[delete] https://crrev.com/4ac424b70ef6933da5db47221f9c44dfdcc4dda7/scripts/slave/recipe_modules/wct/OWNERS
[modify] https://crrev.com/bc3b5719c6b0b3a12fe23bc6813895ebf9f0fde6/scripts/slave/recipes/catapult.expected/basic.json
[delete] https://crrev.com/4ac424b70ef6933da5db47221f9c44dfdcc4dda7/scripts/slave/recipe_modules/wct/tests/full.expected/linux.json
[modify] https://crrev.com/bc3b5719c6b0b3a12fe23bc6813895ebf9f0fde6/scripts/slave/recipes/catapult.expected/android.json
[delete] https://crrev.com/4ac424b70ef6933da5db47221f9c44dfdcc4dda7/scripts/slave/recipe_modules/wct/tests/full.py
[delete] https://crrev.com/4ac424b70ef6933da5db47221f9c44dfdcc4dda7/scripts/slave/recipe_modules/wct/api.py
[modify] https://crrev.com/bc3b5719c6b0b3a12fe23bc6813895ebf9f0fde6/scripts/slave/README.recipes.md
[modify] https://crrev.com/bc3b5719c6b0b3a12fe23bc6813895ebf9f0fde6/scripts/slave/recipes/catapult.py
[delete] https://crrev.com/4ac424b70ef6933da5db47221f9c44dfdcc4dda7/scripts/slave/recipe_modules/wct/__init__.py
[delete] https://crrev.com/4ac424b70ef6933da5db47221f9c44dfdcc4dda7/scripts/slave/recipe_modules/wct/tests/full.expected/notlinux.json

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/159eb9513da675e0840f250f42b15d0728c528e9

commit 159eb9513da675e0840f250f42b15d0728c528e9
Author: Ben Hayden <benjhayden@chromium.org>
Date: Thu Aug 30 20:06:45 2018

Reland Add WCT to catapult recipe.

The Chromeperf Dashboard V2 prototype currently uses Polymer2.
Catapult's UI test framework only supports Polymer1.
This CL provides WCT to catapult's trybot recipe to facilitate testing
V2SPA using WCT instead of catapult's existing UI test framework.

See also dashboard/bin/run_wct_tests:
https://chromium-review.googlesource.com/c/catapult/+/1184050

Reverted: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1196694

Bug:  877660 
Change-Id: Ia67735b9ac0869f1b8c3cafa9744ed4d52059e50
Reviewed-on: https://chromium-review.googlesource.com/1197068
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>

[add] https://crrev.com/159eb9513da675e0840f250f42b15d0728c528e9/scripts/slave/recipe_modules/wct/OWNERS
[modify] https://crrev.com/159eb9513da675e0840f250f42b15d0728c528e9/scripts/slave/recipes/catapult.expected/basic.json
[add] https://crrev.com/159eb9513da675e0840f250f42b15d0728c528e9/scripts/slave/recipe_modules/wct/tests/full.expected/linux.json
[modify] https://crrev.com/159eb9513da675e0840f250f42b15d0728c528e9/scripts/slave/recipes/catapult.expected/android.json
[add] https://crrev.com/159eb9513da675e0840f250f42b15d0728c528e9/scripts/slave/recipe_modules/wct/tests/full.py
[add] https://crrev.com/159eb9513da675e0840f250f42b15d0728c528e9/scripts/slave/recipe_modules/wct/api.py
[modify] https://crrev.com/159eb9513da675e0840f250f42b15d0728c528e9/scripts/slave/README.recipes.md
[modify] https://crrev.com/159eb9513da675e0840f250f42b15d0728c528e9/scripts/slave/recipes/catapult.py
[add] https://crrev.com/159eb9513da675e0840f250f42b15d0728c528e9/scripts/slave/recipe_modules/wct/__init__.py
[add] https://crrev.com/159eb9513da675e0840f250f42b15d0728c528e9/scripts/slave/recipe_modules/wct/tests/full.expected/notlinux.json

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/812417abca093941db88caf432e8b7097f632699

commit 812417abca093941db88caf432e8b7097f632699
Author: Ben Hayden <benjhayden@chromium.org>
Date: Thu Aug 30 22:54:16 2018

Fix catapult recipe to only run wct on luci.

This recipe is still failing on android trybots because they haven't been
migrated to LUCI yet so they're using a service account that is not permitted to
access dart/browsers/chrome cipd package.

Bug:  877660 
Change-Id: Iab7224fe79adc218e6a59fff53bd87f0136ffa1f
Reviewed-on: https://chromium-review.googlesource.com/1198143
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>

[modify] https://crrev.com/812417abca093941db88caf432e8b7097f632699/scripts/slave/README.recipes.md
[modify] https://crrev.com/812417abca093941db88caf432e8b7097f632699/scripts/slave/recipes/catapult.expected/android.json
[modify] https://crrev.com/812417abca093941db88caf432e8b7097f632699/scripts/slave/recipes/catapult.py

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/7f458630fcb22045d8b8c7bbc19eebf925b987fb

commit 7f458630fcb22045d8b8c7bbc19eebf925b987fb
Author: benshayden <benjhayden@chromium.org>
Date: Thu Sep 06 16:48:39 2018

dashboard/bin/run_wct_tests

The Chromeperf Dashboard V2 prototype currently uses Polymer2.
Catapult's UI test framework only supports Polymer1.
This CL adds web-component-tester to third_party,
and a script to run V2SPA tests with Polymer2.
Bots install cipd via the recipe. Developers must install wct via cipd.

Bug:  chromium:877660 
Change-Id: If7f0bf5c76b635711b96bd83fda8f099b9c30f7d
Reviewed-on: https://chromium-review.googlesource.com/1184050
Commit-Queue: Ben Hayden <benjhayden@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/7f458630fcb22045d8b8c7bbc19eebf925b987fb/catapult_build/build_steps.py
[add] https://crrev.com/7f458630fcb22045d8b8c7bbc19eebf925b987fb/dashboard/test/index.html
[add] https://crrev.com/7f458630fcb22045d8b8c7bbc19eebf925b987fb/dashboard/bin/run_wct_tests
[modify] https://crrev.com/7f458630fcb22045d8b8c7bbc19eebf925b987fb/BUILD.gn
[add] https://crrev.com/7f458630fcb22045d8b8c7bbc19eebf925b987fb/catapult_build/run_wct.py
[add] https://crrev.com/7f458630fcb22045d8b8c7bbc19eebf925b987fb/dashboard/wct.conf.json
[modify] https://crrev.com/7f458630fcb22045d8b8c7bbc19eebf925b987fb/dashboard/dashboard_build/dashboard_dev_server_config.py
[modify] https://crrev.com/7f458630fcb22045d8b8c7bbc19eebf925b987fb/dashboard/dashboard/spa/utils-test.html

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79f8b4dcb67bf6bcc2f26bbae15746b90458d0c2

commit 79f8b4dcb67bf6bcc2f26bbae15746b90458d0c2
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Sep 07 18:49:21 2018

Roll src/third_party/catapult bcc3e491fb2e..32654a45d3da (16 commits)

https://chromium.googlesource.com/catapult.git/+log/bcc3e491fb2e..32654a45d3da


git log bcc3e491fb2e..32654a45d3da --date=short --no-merges --format='%ad %ae %s'
2018-09-07 nednguyen@google.com Remove common/battor/
2018-09-07 simonhatch@chromium.org Dashboard - Simplify find_anomalies by removing benchmark_duration
2018-09-07 simonhatch@chromium.org Dashboard - Generate stats on alert #'s
2018-09-07 nednguyen@google.com Fix BUILD.gn by running generate_telemetry_build.py
2018-09-07 ulan@chromium.org Add a metric that tracks the number of console error messages
2018-09-07 wangge@google.com Reformat the `run_benchmark` help message.
2018-09-06 benjhayden@chromium.org Fix flaky dashboard tests: timeseries2_test, file_bug_test, others.
2018-09-06 wangge@google.com Update help message for `run_benchmark.py`.
2018-09-06 benjhayden@chromium.org dashboard/bin/run_wct_tests
2018-09-06 nastasoiuf@google.com Stacked bar plot integration
2018-09-06 simonhatch@chromium.org Dashboard - Fix stats generation for chrome health metrics
2018-09-06 rmcilroy@chromium.org [Tracing] Add support for Optimize-Background bucket to V8's runtime call stats table
2018-09-06 anthonyalridge@google.com Add back bar chart interaction
2018-09-06 mattm@chromium.org netlog_viewer: rename |global| in cr.js to |cr_global|
2018-09-05 mattm@chromium.org netlog_viewer: Apply chromium changes up to 940b87bb7cb870e5d441
2018-09-05 jbudorick@chromium.org Fix systrace/bin/OWNERS.


Created with:
  gclient setdep -r src/third_party/catapult@32654a45d3da

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:881543 , chromium:881379 , chromium:881361 , chromium:881543 ,chromium:880432, chromium:863390 , chromium:877660 ,chromium:866423,chromium:879229,chromium:866423
TBR=sullivan@chromium.org

Change-Id: I2206a43b38a09c7427d4d4ef02fe4c820dbaee98
Reviewed-on: https://chromium-review.googlesource.com/1213476
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589610}
[modify] https://crrev.com/79f8b4dcb67bf6bcc2f26bbae15746b90458d0c2/DEPS

Cc: perezju@chromium.org
Linux Tryserver in Catapult CQ appears to be consistently failing with:

  Starting WCT: ['/b/s/w/ir/kitchen-workdir/packages/wct', '-chrome', u'/b/s/w/ir/kitchen-workdir/catapult/common/py_utils/py_utils/bin/reference_build/chrome_stable_linux_x86_64_aab60e4a4ee4f3d638aa6a33e52ffb6423fa7080/chrome-linux64/chrome', '-dir', '/b/s/w/ir/tmp/t/tmpAvnla2', '-base', '/b/s/w/ir/kitchen-workdir/catapult/dashboard', '-dep', '/b/s/w/ir/kitchen-workdir/catapult/third_party/polymer2', '-dep', '/b/s/w/ir/kitchen-workdir/catapult/third_party/redux', '-dep', '/b/s/w/ir/kitchen-workdir/catapult/tracing/third_party', '-dep', '/b/s/w/ir/kitchen-workdir/catapult/tracing/third_party/gl-matrix/dist', '-dep', '/b/s/w/ir/kitchen-workdir/catapult/tracing']
  flag provided but not defined: -dep
  Usage of /b/s/w/ir/kitchen-workdir/packages/wct:
    -base string
      	location of elements to test (default "./")
    -bower string
      	location of bower compoenents (default "bower_components/")
    -chrome string
      	location of chrome binary
    -debug-port string
      	chrome debugger port (default "9222")
    -dir string
      	user directory (default "/tmp/")
    -persist
      	keep server running
    -prefix string
      	path prefix for test runner URL (default "/test/")
    -timeout int
      	timeout seconds (default 60)
  step returned non-zero exit code: 2
https://logs.chromium.org/logs/catapult/buildbucket/cr-buildbucket.appspot.com/8934154768256773360/+/steps/Dashboard_WCT_Tests/0/stdout

Any clue why is that?
I set the infra/testing/wct CIPD package to the new build with this command yesterday:

cipd set-ref infra/testing/wct/linux-amd64 -version BoHf5DkpKDor0wSIEUTjZ2VZFqMWtM0Q7wPOYsqgLCYC -ref prod

I'll roll it back to the previous version 6afc3c447c5ca107369306896fd4334fe263e79e and see if that fixes the build for now.

bjhayden@: It looks like a recipe or recipe module needs to be updated for catapult before we can roll the CIPD package forward again.

Sorry for the breakage!

(y) thanks!
> flag provided but not defined: -dep

Support for the dep flag was landed on August 30: https://chromium-review.googlesource.com/c/infra/infra/+/1188536

Sean, can you check that the version hash that you set to prod is for a new build?
I just ran 

cipd set-ref infra/testing/wct/linux-amd64 -version 0bJ1imIfx8FkbL53wCZYcczd8ZY-CKewX3X00v5i-T8C -ref prod

With a fresh build of wct.go, in case it was an older build I pushed previously. Will watch infra and catapult builders for a bit and roll back if necessary.
The issue on Infra WCT Tester looks like it's probably how it's interpreting the --base flag:

xvfb-run -a /b/s/w/ir/kitchen-workdir/packages/wct --base /b/s/w/ir/kitchen-workdir/infra/crdx/chopsui [yadda yadda...]

leads to:

[{"method":"Log.entryAdded","params":{"entry":{"source":"network","level":"error","text":"Failed to load resource: the server responded with a status of 404 (Not Found)","timestamp":1538498227271.72,"url":"http://127.0.0.1:34583/b/s/w/ir/kitchen-workdir/infra/crdx/chopsui/test/chops-bug-input_test.html?wct=go"

When it should be looking for http://127.0.0.1:34583/test/chops-bug-input_test.html?wct=go instead.

Repro for local debugging here: https://chromium-review.googlesource.com/c/infra/infra/+/1258583 

Owner: seanmccullough@chromium.org
Added a fix to that repro CL but I need to test it out on both infra and catapult CI, which I'll do tomorrow.
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7db6f4eb7bab24f013d7c515470d1389d00baf0e

commit 7db6f4eb7bab24f013d7c515470d1389d00baf0e
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Thu Oct 04 18:39:49 2018

[crdx, wct.go]

Repro (locally, using crdx/chopsui as an example) + fix

Runs with a full path for -base parameter, which reproduces the
timeout when running locally.

Also includes a fix, which trims the absolute path prefix from
test paths requested by the client.

Bug:  877660 
Change-Id: I74e4ae01560fe47d387003f312a64a1193475cd7
Reviewed-on: https://chromium-review.googlesource.com/c/1258583
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18056}
[modify] https://crrev.com/7db6f4eb7bab24f013d7c515470d1389d00baf0e/go/src/infra/tools/wct/wct.go
[modify] https://crrev.com/7db6f4eb7bab24f013d7c515470d1389d00baf0e/crdx/chopsui/Makefile

Status: Fixed (was: Started)
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/8760a9b10aca468607debce9010523c73c67e592

commit 8760a9b10aca468607debce9010523c73c67e592
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Thu Oct 11 13:47:51 2018

[chromeperf] add prefix to wct script so tests get found.

Limited to running just tests under dashboard/spa FYI.

Bug: chromium:877660 
Change-Id: I69d77ea1016b393eed1cfc4c1a959a99cc938cdd
Reviewed-on: https://chromium-review.googlesource.com/c/1263285
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Auto-Submit: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>

[modify] https://crrev.com/8760a9b10aca468607debce9010523c73c67e592/dashboard/bin/run_wct_tests
[modify] https://crrev.com/8760a9b10aca468607debce9010523c73c67e592/catapult_build/run_wct.py

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb11cbc66e56a475bdf0f5bf3d962cf80c3afe27

commit bb11cbc66e56a475bdf0f5bf3d962cf80c3afe27
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Oct 12 22:54:58 2018

Roll src/third_party/catapult c8b97e37ec9c..99b88b0a2d58 (21 commits)

https://chromium.googlesource.com/catapult.git/+log/c8b97e37ec9c..99b88b0a2d58


git log c8b97e37ec9c..99b88b0a2d58 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 simonhatch@chromium.org Pinpoint - Merge bugs with same root cause.
2018-10-12 benjhayden@chromium.org Change deprecation warnings in /api/alerts to errors.
2018-10-12 benjhayden@chromium.org Cache report names, test suites, and descriptors in v2spa service worker
2018-10-12 chiniforooshan@chromium.org Telemetry: process all rendering pipeline events
2018-10-12 benjhayden@chromium.org Cache session ids in v2spa service worker.
2018-10-12 benjhayden@chromium.org Fix links in rollback.md
2018-10-12 benjhayden@chromium.org Add KeyValueCacheRequest for v2spa service worker.
2018-10-12 benjhayden@chromium.org Add ts_mon metrics to common/timing.py
2018-10-12 benjhayden@chromium.org Add CacheRequestBase for v2spa service worker.
2018-10-12 nednguyen@google.com [Telemetry] Add --test-filter flag that support exact matching of multiple tests
2018-10-12 sadrul@chromium.org rendering: Generate metrics at the 95%ile.
2018-10-12 pasko@chromium.org androidStartupMetric: re-introduce First Contentful Paint
2018-10-12 chrishtr@chromium.org Clean up categories to match current tracing in Blink.
2018-10-11 jbudorick@chromium.org Revert "Enable orderfile memory optimization in benchmarks"
2018-10-11 benjhayden@chromium.org Add task queue for v2spa service worker.
2018-10-11 benjhayden@chromium.org Remove unnecessary file dashboard/test/index.html
2018-10-11 perezju@chromium.org [soundwave] Allow points with missing r_chromium
2018-10-11 chiniforooshan@chromium.org Telemetry: migrate frame_times & percentage_smooth
2018-10-11 ulan@chromium.org [tracing] Restore the minimum mutator utilization metric.
2018-10-11 seanmccullough@chromium.org [chromeperf] add prefix to wct script so tests get found.
2018-10-11 pasko@chromium.org Enable orderfile memory optimization in benchmarks


Created with:
  gclient setdep -r src/third_party/catapult@99b88b0a2d58

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:840872, chromium:893199 ,chromium:867060,chromium:894261,chromium:894287, chromium:886621 ,chromium:893514,chromium:758566, chromium:879526 , chromium:890757 , chromium:892385 , chromium:877660 ,chromium:758566
TBR=sullivan@chromium.org

Change-Id: I469ed20d66790fa12e290ad65e2ea51c16cfdba7
Reviewed-on: https://chromium-review.googlesource.com/c/1279078
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599392}
[modify] https://crrev.com/bb11cbc66e56a475bdf0f5bf3d962cf80c3afe27/DEPS

Sign in to add a comment