New issue
Advanced search Search tips

Issue 877650 link

Starred by 3 users
Status: Fixed
Owner:
saklein@chromium.org
Closed: Aug 29
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove unused Chromite code

Project Member Reported by saklein@chromium.org, Aug 24 
The generate_delta_sysroot script has had a typo that breaks the script for about 3.5 years. It's apparently not been a problem, so the script and build config related to it are being removed.

update_manafest_remotes is from an old transition and is no longer needed.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6655c327da0125e3ab78698d2bf8194ef7c622a9

commit 6655c327da0125e3ab78698d2bf8194ef7c622a9
Author: Alex Klein <saklein@chromium.org>
Date: Wed Aug 29 18:15:21 2018

generate_delta_sysroot: Remove obsolete script.

Remove unused generate_delta_sysroot script and tests.
Remove related build config flag, create_delta_sysroot,
that was never set.
Remove usages of each in the artifact ArchiveStage.

BUG= chromium:877650 
TEST=run_tests

Change-Id: I8543a514f77c55bb3dee34ec1351b0b8555d7413
Reviewed-on: https://chromium-review.googlesource.com/1188982
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/6655c327da0125e3ab78698d2bf8194ef7c622a9/cbuildbot/stages/artifact_stages_unittest.py
[modify] https://crrev.com/6655c327da0125e3ab78698d2bf8194ef7c622a9/config/config_dump.json
[modify] https://crrev.com/6655c327da0125e3ab78698d2bf8194ef7c622a9/lib/config_lib.py
[delete] https://crrev.com/df4880942b7d64a42b38050ff740ae839da68f7a/scripts/generate_delta_sysroot_unittest.py
[delete] https://crrev.com/df4880942b7d64a42b38050ff740ae839da68f7a/scripts/generate_delta_sysroot_unittest
[delete] https://crrev.com/df4880942b7d64a42b38050ff740ae839da68f7a/scripts/generate_delta_sysroot.py
[modify] https://crrev.com/6655c327da0125e3ab78698d2bf8194ef7c622a9/cbuildbot/stages/artifact_stages.py
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/fd98c246fe1c9486d27e5dae8145aa65fdeebff0

commit fd98c246fe1c9486d27e5dae8145aa65fdeebff0
Author: Alex Klein <saklein@chromium.org>
Date: Wed Aug 29 18:15:55 2018

update_manifest_remotes: remove obsolete script.

It is from an old transition phase and is no
longer needed.

BUG= chromium:877650 
TEST=precq

Change-Id: If0f48bc7646690ef7ad7e2e40ad65a4d67b904a6
Reviewed-on: https://chromium-review.googlesource.com/1188983
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[delete] https://crrev.com/6655c327da0125e3ab78698d2bf8194ef7c622a9/bin/update_manifest_remotes
[delete] https://crrev.com/6655c327da0125e3ab78698d2bf8194ef7c622a9/scripts/update_manifest_remotes.py

Comment 3 by saklein@chromium.org, Aug 29

Components: Infra>Client>ChromeOS>Build
Status: Fixed (was: Started)
►

Sign in to add a comment