New issue
Advanced search Search tips

Issue 877647 link

Starred by 3 users
Status: Verified
Owner:
thomasanderson@chromium.org
Closed: Sep 20
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

GM2: Incorrect tab border size on certain fractional scale factors

Project Member Reported by thomasanderson@chromium.org, Aug 24 
The below screenshot is a result of running:
$ google-chrome-beta --user-data-dir=/tmp/chrome-beta --no-first-run --force-device-scale-factor=1.8

The border around the tab and above the toolbar should be consistent.

Comment 1 by thomasanderson@chromium.org, Aug 24

Screenshot from 2018-08-24 13-46-37.png
27.5 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04

commit 2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Sep 20 19:36:22 2018

[GM2] Take pixel offsets into account when drawing toolbar top stroke

BUG= 877647 
R=pkasting

Change-Id: I37b7d06209890a59262b0363c30fc70e809329ed
Reviewed-on: https://chromium-review.googlesource.com/1194674
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592904}
[modify] https://crrev.com/2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04/chrome/browser/ui/views/frame/browser_root_view.cc
[modify] https://crrev.com/2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04/chrome/browser/ui/views/frame/browser_root_view.h
[modify] https://crrev.com/2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/2e0e1f8c6001fa69a7c26fad8a6ba72fc36b6a04/chrome/browser/ui/views/tabs/tab_strip.cc

Comment 3 by thomasanderson@chromium.org, Sep 20

Labels: Merge-Request-70
Status: Fixed (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 21

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by abdulsyed@chromium.org, Sep 21 

Please mark which OS's this is impacting.

Comment 6 by thomasanderson@chromium.org, Sep 21

Labels: OS-Linux OS-Mac OS-Windows

Comment 7 by abdulsyed@chromium.org, Sep 24

Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 24

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7ccedc271d54a906021b05cca0c0955a4fb2983

commit e7ccedc271d54a906021b05cca0c0955a4fb2983
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Sep 24 18:31:22 2018

[Merge to M70] [GM2] Take pixel offsets into account when drawing toolbar top stroke

> BUG= 877647 
> R=pkasting
>
> Change-Id: I37b7d06209890a59262b0363c30fc70e809329ed
> Reviewed-on: https://chromium-review.googlesource.com/1194674
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592904}

BUG= 877647 
TBR=pkasting
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: Ifde58ce10727b439ccdb6300e83fe0e52b1aa67a
Reviewed-on: https://chromium-review.googlesource.com/1240738
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#592}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/e7ccedc271d54a906021b05cca0c0955a4fb2983/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/e7ccedc271d54a906021b05cca0c0955a4fb2983/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/e7ccedc271d54a906021b05cca0c0955a4fb2983/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/e7ccedc271d54a906021b05cca0c0955a4fb2983/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/e7ccedc271d54a906021b05cca0c0955a4fb2983/chrome/browser/ui/views/frame/browser_root_view.cc
[modify] https://crrev.com/e7ccedc271d54a906021b05cca0c0955a4fb2983/chrome/browser/ui/views/frame/browser_root_view.h
[modify] https://crrev.com/e7ccedc271d54a906021b05cca0c0955a4fb2983/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/e7ccedc271d54a906021b05cca0c0955a4fb2983/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/e7ccedc271d54a906021b05cca0c0955a4fb2983/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/e7ccedc271d54a906021b05cca0c0955a4fb2983/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/e7ccedc271d54a906021b05cca0c0955a4fb2983/chrome/browser/ui/views/tabs/tab_strip.cc
Project Member

Comment 9 by cr-audit...@appspot.gserviceaccount.com, Sep 24

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/e7ccedc271d54a906021b05cca0c0955a4fb2983

Commit: e7ccedc271d54a906021b05cca0c0955a4fb2983
Author: thomasanderson@chromium.org
Commiter: thomasanderson@chromium.org
Date: 2018-09-24 18:31:22 +0000 UTC

[Merge to M70] [GM2] Take pixel offsets into account when drawing toolbar top stroke

> BUG= 877647 
> R=pkasting
>
> Change-Id: I37b7d06209890a59262b0363c30fc70e809329ed
> Reviewed-on: https://chromium-review.googlesource.com/1194674
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592904}

BUG= 877647 
TBR=pkasting
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: Ifde58ce10727b439ccdb6300e83fe0e52b1aa67a
Reviewed-on: https://chromium-review.googlesource.com/1240738
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#592}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}

Comment 10 by viswa.karala@chromium.org, Sep 26

Labels: Needs-Feedback
Tried verifying the fix on chrome version# 70.0.3538.35 using Ubuntu 14.04, launched chrome from terminal with $ google-chrome-beta --user-data-dir=/tmp/chrome-beta --no-first-run --force-device-scale-factor=1., observed the behaviour of tab border size and compared it with chrome version# 70.0.3530.0 but didn't find any difference.
Observations: Also tested the issue by enabling the GTK theme on Linux

@Thomas Anderson: Please find the above information and attached screenshots for your reference, let us know if we missed anything in verifying the fix and help in verifying the fix.

Thanks!
70.0.3530.0 - Linux.png
196 KB View Download
70.0.3538.35 - Linux.png
193 KB View Download

Comment 11 by thomasanderson@chromium.org, Sep 26

Status: Verified (was: Fixed)
Verified on 71.0.3559.6
Screenshot from 2018-09-26 10-40-43.png
280 KB View Download
►

Sign in to add a comment