New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 877643 link

Starred by 2 users
Status: Assigned
Owner:
█ nednguyen@chromium.org
Last visit > 30 days ago
Cc:
perezju@chromium.org
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 863768
Blocking:
issue 877669



Sign in to add a comment

Adding a new perf waterfall Telemetry benchmark is confusing

Project Member Reported by nednguyen@chromium.org, Aug 24 
See https://chromium-review.googlesource.com/c/chromium/src/+/1188777 which adds a new Telemetry benchmarks. The user get a very confusing error message which is:
"AssertionError: Please update NON_TELEMETRY_BENCHMARKS as below:
Remove blink_perf.accessibility from NON_TELEMETRY_BENCHMARKS"


Also with this bug, we also need to make sure the sharding maps for user when they add new benchmark is properly handled (which is related to issue 863768)

Comment 1 by nednguyen@chromium.org, Aug 24

Blockedon: 863768

Comment 2 by nednguyen@chromium.org, Aug 26

Blocking: 877669
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6818ca8f1d19ebe081353799e91a8de365c89075

commit 6818ca8f1d19ebe081353799e91a8de365c89075
Author: Ned Nguyen <nednguyen@google.com>
Date: Sat Sep 01 09:54:04 2018

Reshard perf benchmarks to include blink_perf.accessibility benchmark

** PERF SHERIFFS: this CL will cause regressions on many bots that are
non bisectable **

Run:
./tools/perf/generate_perf_sharding
./tools/perf/generate_perf_data

Bug:  877669 , 877643
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ifcd60511ce3647616672056d7f46e9ac53b00c54
Reviewed-on: https://chromium-review.googlesource.com/1199934
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588278}
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/benchmark.csv
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/bot_platforms.py
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/shard_maps/android_go_shard_map.json
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/shard_maps/android_nexus5_16_shard_map.json
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/shard_maps/android_nexus5x_16_shard_map.json
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/shard_maps/android_nexus5x_webview_16_shard_map.json
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/shard_maps/android_nexus6_webview_shard_map.json
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/shard_maps/linux_perf_shard_map.json
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/shard_maps/mac_1012_low_end_26_shard_map.json
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/shard_maps/mac_1013_high_end_26_shard_map.json
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/shard_maps/win10_shard_map.json
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/shard_maps/win7_nvidia_shard_map.json
[modify] https://crrev.com/6818ca8f1d19ebe081353799e91a8de365c89075/tools/perf/core/shard_maps/win7_shard_map.json

Comment 4 by benhenry@google.com, Jan 11

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
►

Sign in to add a comment