Issue metadata
Sign in to add a comment
|
Don't call |StoragePartition::ClearHttpAndMediaCaches| with Network Service enabled |
||||||||||||||||||||||||
Issue description(See issue 721398 #c23 for more backgrounds) Network Service doesn't have the concept of media cache, and |NetworkContext::ClearHttpCache()| will clear both HTTP and 'media' cache. Currently the following code calls |StoragePartition::ClearHttpAndMediaCaches| to try to clear media cache when Network Service was enabled, which should be unnecessary: https://cs.chromium.org/chromium/src/content/browser/browsing_data/browsing_data_remover_impl.cc?rcl=9aeecc40704b65ff20988cdcb1f32c76c28b0184&l=429
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f06b391129b3041101dda3d82871c8693052998 commit 8f06b391129b3041101dda3d82871c8693052998 Author: Chong Zhang <chongz@chromium.org> Date: Mon Aug 27 22:10:21 2018 NetworkService: Don't call StoragePartition::ClearHttpAndMediaCaches We've deprecated the concept of a media cache, and are now using a single cache for both purposes. |NetworkContext::ClearHttpCache()| does the job to clear the cache when Network Service was enabled, and we should only call |StoragePartition::ClearHttpAndMediaCaches()| when Network Service was disabled. Bug: 877639 Change-Id: Id227322b9b2d64b76a53a45147010227b620468f Reviewed-on: https://chromium-review.googlesource.com/1187571 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#586440} [modify] https://crrev.com/8f06b391129b3041101dda3d82871c8693052998/content/browser/browsing_data/browsing_data_remover_impl.cc
,
Aug 27
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dxie@chromium.org
, Aug 24