New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 877619 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression

Blocking:
issue 876539



Sign in to add a comment

GPU.FYI Android bots fail angle_perftests

Project Member Reported by ynovikov@chromium.org, Aug 24

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20(Nexus%205)/8273
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20(Nexus%205X)/8161
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20(Nexus%206P)/7074
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20(Nexus%209)/7441
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%2032%20Vk%20Release%20(Nexus%205X)/21631
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%2064%20Vk%20Release%20(Nexus%205X)/20677
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%2032%20Vk%20Release%20(Pixel%202)/11151
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%2064%20Vk%20Release%20(Pixel%202)/10666

Failure is:

[ 24%] /data/local/tmp/temp_file-2ac1f83013f50.zip
[ 24%] /data/loc<truncated>
I   11.794s TimeoutThread-1-for-individual_device_set_up(FA7BN1A04423)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s FA7BN1A04423 push /b/swarming/w/iti2ubUb/tmpHQuUss /data/local/tmp/temp_file-eb696dde53a38.sh
D   11.805s TimeoutThread-1-for-individual_device_set_up(FA7BN1A04423)  STDOUT+STDERR: [100%] /data/local/tmp/temp_file-eb696dde53a38.sh
/b/swarming/w/iti2ubUb/tmpHQuUss: 1 file pushed. 0.5 MB/s (1543 bytes in 0.003s)
I   11.805s TimeoutThread-1-for-individual_device_set_up(FA7BN1A04423)  Large shell command will be run from file: PATH="/data/local/tmp/bin:$PATH" unzip /data/local/tmp/temp_file-2ac1f83013f50.zip&&chmod -R 777 /sdcard/chromium_tests_root/icudtl.dat /sdcard/chromium_tests_root/gen.runtime/third_party/angle/src/tests/angle_perftests__test_runner_script.runtime_deps /sdcard/chromium_tests_root/build/android/devil_chromium.json /sdcard/chromium_tests_root/build/android/pylib/gtest/filter /sdcard/chromium_tests_root/build/android/pylib/instrumentation/render_test.html.jinja /sdcard/chromium_tests_root/third_party/android_t ...
I   11.805s TimeoutThread-1-for-individual_device_set_up(FA7BN1A04423)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s FA7BN1A04423 shell '( sh /data/local/tmp/temp_file-eb696dde53a38.sh );echo %$?'
D   13.877s TimeoutThread-1-for-individual_device_set_up(FA7BN1A04423)  STDOUT+STDERR: chmod: /sdcard/chromium_tests_root/third_party/proguard/lib/proguard.jar: No such file or directory
%1
I   13.877s TimeoutThread-1-for-delete_temporary_file(FA7BN1A04423)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s FA7BN1A04423 shell 'rm -f /data/local/tmp/temp_file-eb696dde53a38.sh'
I   13.878s TimeoutThread-1-for-delete_temporary_file(FA7BN1A04423)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s FA7BN1A04423 shell 'rm -f /data/local/tmp/temp_file-2ac1f83013f50.zip'
E   13.893s individual_device_set_up(FA7BN1A04423)  Shard failed: individual_device_set_up(FA7BN1A04423)
Traceback (most recent call last):
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_environment.py", line 66, in wrapper
    return f(dev, *args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_gtest_run.py", line 349, in individual_device_set_up
    step()
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_gtest_run.py", line 340, in <lambda>
    return lambda: crash_handler.RetryOnSystemCrash(step, dev)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/crash_handler.py", line 32, in RetryOnSystemCrash
    return f(device)
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_gtest_run.py", line 320, in push_test_data
    delete_device_stale=True)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 57, in timeout_retry_wrapper
    retry_if_func=retry_if_func)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/timeout_retry.py", line 158, in Run
    error_log_func=error_log_func)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 189, in JoinAll
    self._JoinAll(watcher, timeout)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 161, in _JoinAll
    thread.ReraiseIfException()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 84, in run
    self._ret = self._func(*self._args, **self._kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/timeout_retry.py", line 151, in <lambda>
    child_thread = reraiser_thread.ReraiserThread(lambda: func(*args, **kwargs),
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 47, in impl
    return f(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1516, in PushChangedFiles
    self._PushFilesImpl(host_device_tuples, all_changed_files)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1706, in _PushFilesImpl
    files, [d for _, d in host_device_tuples]):
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1780, in _PushChangedFilesZipped
    check_return=True)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 51, in timeout_retry_wrapper
    return impl()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 47, in impl
    return f(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1150, in RunShellCommand
    output = handle_large_output(cmd, large_output)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1119, in handle_large_output
    return handle_large_command(cmd)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1107, in handle_large_command
    return handle_check_return('sh %s' % script.name_quoted)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1092, in handle_check_return
    return run(cmd)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1088, in run
    return self.adb.Shell(cmd)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/sdk/adb_wrapper.py", line 538, in Shell
    command, output, status=status, device_serial=self._device_serial)
AdbShellCommandFailedError: (device: FA7BN1A04423) shell command run via adb failed on the device:
  command: sh /data/local/tmp/temp_file-eb696dde53a38.sh
  exit status: 1
  output:
  - chmod: /sdcard/chromium_tests_root/third_party/proguard/lib/proguard.jar: No such file or directory

Looks like this is due to https://chromium-review.googlesource.com/1187003 changing something proguard related.
agrieve@, PTAL
 
Blocking: 876539
Cc: bpastene@chromium.org
Looking... For some reason this tests thinks that it should be pushing proguard.jar onto the device, which I'm sure is not desired.
I am surprised that something is expecting the proguard jar to be pushed to the device...
Still not sure why it's trying to push the file to device, but figured out enough to see that I've got the wrong path configured for swarming in my change, so going to revert & re-land.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78561f5b9dca2d5e742a43ddf0f553eaf4a76c70

commit 78561f5b9dca2d5e742a43ddf0f553eaf4a76c70
Author: agrieve <agrieve@chromium.org>
Date: Fri Aug 24 19:55:43 2018

Revert "Android: Update version of retrace.jar to 6.0.3"

This reverts commit bd3c0e676955a999600b966e2c02bec00dbacabf.

Reason for revert: Broke angle_perftests

Original change's description:
> Android: Update version of retrace.jar to 6.0.3
> 
> The existing version was found to infinite loop at times.
> Also moves the jars to CIPD
> 
> NOTRY=true # windows bot failing
> 
> Bug:  876539 
> Change-Id: If822837f4958434372ef0cb40799aec32ec7cd37
> Reviewed-on: https://chromium-review.googlesource.com/1187003
> Commit-Queue: agrieve <agrieve@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585887}

TBR=agrieve@chromium.org,jbudorick@chromium.org

Change-Id: Icd2cf44c9e48390f6b13641d6fac97fd0f75df5d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  876539 ,  877619 
Reviewed-on: https://chromium-review.googlesource.com/1188866
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585955}
[modify] https://crrev.com/78561f5b9dca2d5e742a43ddf0f553eaf4a76c70/DEPS
[modify] https://crrev.com/78561f5b9dca2d5e742a43ddf0f553eaf4a76c70/build/android/pylib/utils/proguard.py
[modify] https://crrev.com/78561f5b9dca2d5e742a43ddf0f553eaf4a76c70/third_party/.gitignore
[modify] https://crrev.com/78561f5b9dca2d5e742a43ddf0f553eaf4a76c70/third_party/proguard/BUILD.gn
[modify] https://crrev.com/78561f5b9dca2d5e742a43ddf0f553eaf4a76c70/third_party/proguard/README.chromium
[delete] https://crrev.com/daeda01281efc0810df252157bcf623f1faac38c/third_party/proguard/cipd.yaml
[add] https://crrev.com/78561f5b9dca2d5e742a43ddf0f553eaf4a76c70/third_party/proguard/lib/proguard.jar
[add] https://crrev.com/78561f5b9dca2d5e742a43ddf0f553eaf4a76c70/third_party/proguard/lib/retrace.jar

Status: Fixed (was: Assigned)
green after revert.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40dece27d6b58fb916aa8d27aadaa5def856584f

commit 40dece27d6b58fb916aa8d27aadaa5def856584f
Author: Andrew Grieve <agrieve@chromium.org>
Date: Mon Aug 27 17:59:40 2018

Reland "Android: Update version of retrace.jar to 6.0.3"

Reverted in: 78561f5b9dca2d5e742a43ddf0f553eaf4a76c70

Reason for reland:
 * Should now work with swarming
 * Contains fix for angle_perftest (ran locally)

The existing version was found to infinite loop at times.
Also moves the jars to CIPD

Bug:  876539 ,  877619 
Change-Id: I9564c9b5dd6339abd1ded62d9bba98f9692a601d
Reviewed-on: https://chromium-review.googlesource.com/1188601
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586312}
[modify] https://crrev.com/40dece27d6b58fb916aa8d27aadaa5def856584f/DEPS
[modify] https://crrev.com/40dece27d6b58fb916aa8d27aadaa5def856584f/build/android/BUILD.gn
[modify] https://crrev.com/40dece27d6b58fb916aa8d27aadaa5def856584f/build/android/pylib/constants/__init__.py
[modify] https://crrev.com/40dece27d6b58fb916aa8d27aadaa5def856584f/build/android/pylib/utils/device_dependencies.py
[modify] https://crrev.com/40dece27d6b58fb916aa8d27aadaa5def856584f/build/android/pylib/utils/proguard.py
[modify] https://crrev.com/40dece27d6b58fb916aa8d27aadaa5def856584f/third_party/.gitignore
[modify] https://crrev.com/40dece27d6b58fb916aa8d27aadaa5def856584f/third_party/proguard/BUILD.gn
[modify] https://crrev.com/40dece27d6b58fb916aa8d27aadaa5def856584f/third_party/proguard/README.chromium
[add] https://crrev.com/40dece27d6b58fb916aa8d27aadaa5def856584f/third_party/proguard/cipd.yaml
[delete] https://crrev.com/25113733c29967022d59118621aabe491a7bcc13/third_party/proguard/lib/proguard.jar
[delete] https://crrev.com/25113733c29967022d59118621aabe491a7bcc13/third_party/proguard/lib/retrace.jar

Sign in to add a comment