New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 877617 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Cleaner Messaging about pretty_print.py versus git cl format

Project Member Reported by mpear...@chromium.org, Aug 24

Issue description


We should be consistent about what we suggestion.  See this message below:

>>>
git cl upload
Running presubmit upload checks ...
Done processing D:\src\chrome2\src\chrome\browser\metrics\process_memory_metrics_emitter.cc
ERROR:root:histograms.xml is not formatted correctly; run pretty_print.py to fix.

** Presubmit Messages **
Missing OWNER reviewers for these files:
    tools\metrics\histograms\histograms.xml

Suggested OWNERS: (Use "git-cl owners" to interactively select owners.)
    isherman@chromium.org

** Presubmit ERRORS **
histograms.xml is not formatted correctly; please run git cl format D:\src\chrome2\src\tools\metrics\histograms to fix.

---
First confusing thing above is that it says to both use pretty_print and git cl format. Shouldn't it be just one tool?
>>>
 

Sign in to add a comment