New issue
Advanced search Search tips

Issue 877610 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.7%-25.7% regression in rendering.desktop at 585726:585756

Project Member Reported by m...@chromium.org, Aug 24

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=877610

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=14260069af91b31150de68f70e8bccf997269f830de29e6f64e52af6b5ff51a7


Bot(s) for this bug's original alert(s):

mac-10_12_laptop_low_end-perf
mac-10_13_laptop_high_end-perf

system_health.memory_desktop - Benchmark documentation link:
  https://bit.ly/system-health-benchmarks

rendering.desktop - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: bsalo...@google.com
Owner: bsalo...@google.com
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16ddccb6640000

Add support for dynamic state GP textures in Vulkan backend. by bsalomon@google.com
https://skia.googlesource.com/skia/+/5e81a123f22c309ebe790904345d54de4cba2ab5
20.77 → 24.83 (+4.057)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/fdec6f469a44b19e3d77ed313c5b79fb72982603

commit fdec6f469a44b19e3d77ed313c5b79fb72982603
Author: Brian Salomon <bsalomon@google.com>
Date: Mon Aug 27 17:55:01 2018

Disable GrTextureOp Chaining

Two chrome perf regressions and bad image-surface GM on S7/MaliT880

Bug:  chromium:877610 
Bug:  chromium:877598 
Change-Id: Ibca66a936739ad0c452a0da155439c5ed8f1da39
Reviewed-on: https://skia-review.googlesource.com/149621
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/fdec6f469a44b19e3d77ed313c5b79fb72982603/src/gpu/ops/GrTextureOp.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c62b00356c0b273aab67b16dccf73535fe9332dd

commit c62b00356c0b273aab67b16dccf73535fe9332dd
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Aug 27 20:41:05 2018

Roll src/third_party/skia adb4bfef0cd8..22b21ea25b29 (17 commits)

https://skia.googlesource.com/skia.git/+log/adb4bfef0cd8..22b21ea25b29


git log adb4bfef0cd8..22b21ea25b29 --date=short --no-merges --format='%ad %ae %s'
2018-08-27 brianosman@google.com Stop blacklisting some critical unit tests on Metal
2018-08-27 reed@google.com textonpath util
2018-08-27 caryclark@skia.org fix pathops unsortable angles
2018-08-27 brianosman@google.com Remove MSAA from Metal caps
2018-08-27 bsalomon@google.com Disable GrTextureOp Chaining
2018-08-27 brianosman@google.com Don't assert trying to make an MSAA surface with Metal, just fail
2018-08-27 scroggo@google.com Reland "Switch SkCodec to use skcms plus fixes""
2018-08-27 halcanary@google.com SkPDF/Type1:  fix BUG: skia:8285 
2018-08-27 bsalomon@google.com Make GrGLInterface great for Win32 x86 again
2018-08-27 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 8707af516c46..89664843c656 (1 commits)
2018-08-27 reed@google.com use nothingToDraw more often
2018-08-27 kjlubick@google.com Add a renderer key to lottie gold digests
2018-08-27 scroggo@google.com Ignore PLTE chunks in non-palette PNGs
2018-08-27 robertphillips@google.com Always render GPU masks with AA rendering
2018-08-27 brianosman@google.com Add a version of the skbug6653 unit test that disables explicit resource allocation
2018-08-27 ethannicholas@google.com Revert "Revert "added support for sk_Dimensions to SkSL""
2018-08-27 fmalita@chromium.org [skottie] Add support for keyframed text nodes


Created with:
  gclient setdep -r src/third_party/skia@22b21ea25b29

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:877610 , chromium:877598 
TBR=stephana@chromium.org

Change-Id: I0ae8d4005beb6391aa2f8c29fb5e618f13431278
Reviewed-on: https://chromium-review.googlesource.com/1191147
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586401}
[modify] https://crrev.com/c62b00356c0b273aab67b16dccf73535fe9332dd/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/cd7907b57d7624c9bb60cd914d175ed72d9b1365

commit cd7907b57d7624c9bb60cd914d175ed72d9b1365
Author: Brian Salomon <bsalomon@google.com>
Date: Thu Aug 30 13:20:57 2018

Revert "Reland "Add ability to specify different GP textures for each mesh in a draw.""

This reverts commit 2d0a6a1f989dbe02e5eaff5b8ae9ed9dc216a3e6.

Revert "Add support for dynamic state GP textures in Vulkan backend."

This reverts commit 5e81a123f22c309ebe790904345d54de4cba2ab5.

Revert "Disable GrTextureOp Chaining"

This reverts commit fdec6f469a44b19e3d77ed313c5b79fb72982603.

Bug:  chromium:877598 
Bug: chromium:877602
Bug:  chromium:877610 
Change-Id: Iabf2971b27bcf7728785903f1d7f47d1148a2e63
Reviewed-on: https://skia-review.googlesource.com/150461
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/gl/GrGLGpu.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/GrGpuCommandBuffer.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/gl/GrGLProgram.h
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/gl/GrGLProgram.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/vk/GrVkUniformHandler.h
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/gl/GrGLPathRendering.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/GrPipeline.h
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/GrOpFlushState.h
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/vk/GrVkPipelineState.h
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/gl/GrGLCaps.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/gl/GrGLGpu.h
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/ops/GrAAConvexPathRenderer.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/ops/GrMeshDrawOp.h
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/GrCaps.h
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/vk/GrVkCaps.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/vk/GrVkPipelineState.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/vk/GrVkGpuCommandBuffer.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/ops/GrMeshDrawOp.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/vk/GrVkCommandBuffer.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/GrOpFlushState.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/ops/GrTextureOp.cpp
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/GrRenderTargetOpList.h
[modify] https://crrev.com/cd7907b57d7624c9bb60cd914d175ed72d9b1365/src/gpu/GrCaps.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b2b2222704f038491bcdd2942a9d3fad4d1343c

commit 6b2b2222704f038491bcdd2942a9d3fad4d1343c
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Aug 30 15:06:13 2018

Roll src/third_party/skia f7c723c93d26..cd7907b57d76 (1 commits)

https://skia.googlesource.com/skia.git/+log/f7c723c93d26..cd7907b57d76


git log f7c723c93d26..cd7907b57d76 --date=short --no-merges --format='%ad %ae %s'
2018-08-30 bsalomon@google.com Revert "Reland "Add ability to specify different GP textures for each mesh in a draw.""


Created with:
  gclient setdep -r src/third_party/skia@cd7907b57d76

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:877598 ,chromium:877602, chromium:877610 
TBR=stephana@chromium.org

Change-Id: If6695aa3f072747f8fd260b043e208214be01188
Reviewed-on: https://chromium-review.googlesource.com/1196842
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587578}
[modify] https://crrev.com/6b2b2222704f038491bcdd2942a9d3fad4d1343c/DEPS

Status: Fixed (was: Assigned)
Change was reverted prior to M70 branch.

Sign in to add a comment