Issue metadata
Sign in to add a comment
|
19.4%-31.1% regression in rendering.desktop at 585001:585026 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 24
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11c07fce640000
,
Aug 24
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/11c07fce640000 Add PassiveDocumentWheelEventListeners to fieldtrial_testing_config by sahel@chromium.org https://chromium.googlesource.com/chromium/src/+/9187c7d059b7aa6342b39a19c7c32ba5aedd92cf 0.1412 → 0.1821 (+0.04091) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Oct 10
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19a66a429489c8eb9fec304198548c18de59e5d2 commit 19a66a429489c8eb9fec304198548c18de59e5d2 Author: Sahel Sharify <sahel@chromium.org> Date: Tue Nov 13 02:09:56 2018 Fix perf regression of PassiveDocumentWheelEventListeners. JS_SCROLL_TEXT_ONLY and JS_SCROLL_200_LAYER_GRID both add event listeners to the document that preventDefault wheel/touch events and call JS scrolling. The tests regressed after landing the following cl: https://chromium-review.googlesource.com/1183538 This is because with passive document level event listeners interventions the wheel/mousewheel and touchstart/touchmove event listeners on a document level target are treated as passive if not requested otherwise. This cl changes the event listeners in both tests to passive:false to make sure that they actually prevent scrolling. Bug: 877586 Change-Id: I25fb5c0563534b1d67f124bd43272d02d849fa23 Reviewed-on: https://chromium-review.googlesource.com/c/1329447 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#607441} [modify] https://crrev.com/19a66a429489c8eb9fec304198548c18de59e5d2/tools/perf/page_sets/data/rendering_desktop.json [add] https://crrev.com/19a66a429489c8eb9fec304198548c18de59e5d2/tools/perf/page_sets/data/rendering_desktop_05c1f9e507.wprgo.sha1 [add] https://crrev.com/19a66a429489c8eb9fec304198548c18de59e5d2/tools/perf/page_sets/data/rendering_desktop_a2106b0095.wprgo.sha1 [modify] https://crrev.com/19a66a429489c8eb9fec304198548c18de59e5d2/tools/perf/page_sets/rendering/tough_compositor_cases.py
,
Nov 13
The graphs show that the regression has recovered after landing the fix in comment #5. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 24