GoogleUpdateSetup.exe includes "Dummy Certificate" with missing NULL in AlgorithmIdentifier
Reported by
awill...@sourcefire.com,
Aug 24
|
||||||
Issue description
Chrome Version : 68.0.3440.106
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
Safari: OK
Firefox: OK
Edge: OK
What steps will reproduce the problem?
(1) Extract the PKCS7 signature block from GoogleUpdateSetup.exe. There's a python script that will do it on Linux - https://github.com/recvfrom/verify-sigs. Invoke with 'python print_pe_certs.py /path/to/GoogleUpdateSetup.exe'. The output file will be in /tmp. Alternatively, I've attached the extracted file.
(2) Load the p7b file into a parser like https://lapo.it/asn1js/
(3) Viewing the ASN.1 section associated with the "Dummy Certificate", you can see it's missing the required ASN.1 NULL type in the AlgorithmIdentifier section
What is the expected result?
Each x509 certificate using sha-1WithRSAEncryption must have an ASN.1 NULL type following the OID to strictly conform with the RFCs.
Reference:
- https://tools.ietf.org/html/rfc5280#section-4.1.1.2
- https://tools.ietf.org/html/rfc3279#section-2.2.1
What happens instead?
The "Dummy Certificate" doesn't have the required ASN.1 NULL type, though, which may break some parsers (for instance, it currently causes the ClamAV authenticode parser to stop signature verification). It doesn't seem to interfere with signature validation on Windows, though.
Does this Dummy Certificate serve a purpose, and if not, can it be removed from the authenticode header? Or can it be updated to include the NULL value?
,
Aug 26
,
Aug 27
awillia2@ Thanks for the issue. This issue is out of scope of triaging at TE end. Hence adding 'TE-NeedsTriageHelp' and requesting 'Internals>Installer' team to look into the issue and help in further triaging. Thanks..
,
Aug 27
Sorin: this sounds related to tagging the stub installer. Would you please triage appropriately? Thanks.
,
Aug 27
We will take a look.
,
Nov 14
agl@, can you comment on this?
,
Nov 14
The reporter is correct that the NULL is required. I can believe that the stub cert is missing it. I can probably fix it if someone can point me at the code to generate it. But I no longer have any context on where that code is, what it's used for etc. Omaha folks: want to contact me internally?
,
Nov 30
This is fixed internally. However the release process for this bit of code will take ~3 months given that it's the holiday season. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dtapu...@chromium.org
, Aug 24