New issue
Advanced search Search tips

Issue 877548 link

Starred by 1 user
Status: Fixed
Owner:
sky@chromium.org
Closed: Aug 24
Cc:
jamescook@chromium.org
sky@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

SingleProcessMash: Memory leak detected in browser_tests

Project Member Reported by rcui@chromium.org, Aug 24 
Tests failing on 'Linux Chromium OS ASan LSan Tests' bot:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28724

Failures in these tests caused CL:1175222 which adds the tests to the main waterfall to be reverted:

LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentialsCancelled
LoginPromptBrowserTest.TestTwoAuths
LoginPromptBrowserTest.ShowCorrectUrlForCrossOriginMainFrameRedirects
LoginPromptBrowserTest.CancelRedundantAuths
LoginPromptBrowserTest.CancelLoginInterstitialOnRedirect
LoginPromptBrowserTest.ShouldReplaceExistingInterstitialWhenNavigated
LoginUtilsTest.MashLogin
LoginPromptBrowserTest.IncorrectConfirmation
LoginPromptBrowserTest.TestBasicAuth
LoginPromptBrowserTest.TestCancelAuth_Manual
LoginPromptBrowserTest.NoLoginPromptForXHRWithBadCredentials
LoginPromptBrowserTest.SupplyRedundantAuths
LoginPromptBrowserTest.SupplyRedundantAuthsMultiProfile
LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentials
LoginPromptBrowserTest.TestDigestAuth
LoginPromptBrowserTest.AllowCrossdomainPromptForSubframes
LoginPromptBrowserTest.ShouldNotProceedExistingInterstitial
LoginPromptBrowserTest.TestCancelAuth_OnBack
LoginPromptBrowserTest.TestCancelAuth_OnForward
LoginPromptBrowserTest.BlockCrossdomainPromptForSubresources
LoginPromptBrowserTest.TestCancelAuth_OnNavigation
LoginPromptBrowserTest.ShowCorrectUrlForCrossOriginMainFrameRequests

Reversion CL: https://chromium-review.googlesource.com/c/chromium/src/+/1188165

Comment 1 by sky@chromium.org, Aug 24

Labels: OS-Chrome
Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daeda01281efc0810df252157bcf623f1faac38c

commit daeda01281efc0810df252157bcf623f1faac38c
Author: Scott Violet <sky@chromium.org>
Date: Fri Aug 24 19:55:40 2018

window-service: fix leak in PropertyConverter

If an unguessable token was empty, we would leak the newly allocated token.

BUG= 877548 
TEST=covered by bots

Change-Id: Ice7715d4cc2faff51769377e3de30aa0f6378542
Reviewed-on: https://chromium-review.googlesource.com/1188584
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585954}
[modify] https://crrev.com/daeda01281efc0810df252157bcf623f1faac38c/ui/aura/mus/property_converter.cc

Comment 3 by sky@chromium.org, Aug 24

Status: Fixed (was: Started)
►

Sign in to add a comment