New issue
Advanced search Search tips

Issue 877540 link

Starred by 2 users
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Aug 29
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Enable NQE tests for Network Service

Project Member Reported by dxie@chromium.org, Aug 24 
We've migrated over NQE to Network Service. We should reenable the tests.

-IOThreadEctCommandLineBrowserTest.ForceECTFromCommandLine
-IOThreadEctFieldTrialAndCommandLineBrowserTest.ECTFromCommandLineOverridesFieldTrial
-IOThreadEctFieldTrialBrowserTest.ForceECTUsingFieldTrial

Comment 1 by dxie@chromium.org, Aug 24

Components: Internals>Services>Network

Comment 2 by tbansal@chromium.org, Aug 27

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfb6467be2ff116c24d6987e07958c0faefb18e1

commit bfb6467be2ff116c24d6987e07958c0faefb18e1
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Aug 29 05:06:31 2018

Enable NQE browser tests when network service is enabled

Enable the NQE (Network Quality Estimator) browser tests when
network service is enabled.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I7976556adbff4e6ca18b6b9f8250f92a15df5a98
Bug:  877540 
Reviewed-on: https://chromium-review.googlesource.com/1189710
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587016}
[modify] https://crrev.com/bfb6467be2ff116c24d6987e07958c0faefb18e1/chrome/browser/io_thread_browsertest.cc
[modify] https://crrev.com/bfb6467be2ff116c24d6987e07958c0faefb18e1/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 4 by tbansal@chromium.org, Aug 29

Labels: M-70
Status: Fixed (was: Started)
►

Sign in to add a comment