New issue
Advanced search Search tips

Issue 877521 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Feature
Rollout-Type: Default



Sign in to add a comment

Remove PaymentAddress.languageCode field.

Project Member Reported by rouslan@chromium.org, Aug 24

Issue description

Please provide a link to your UX implementation review here before requesting review.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e106362e0688dae13492f027665cfbe5f289dd00

commit e106362e0688dae13492f027665cfbe5f289dd00
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Thu Sep 06 20:52:12 2018

[Payment Request] Measure usage of languageCode.

This patch adds a use counter for PaymentAddress.languageCode to
validate that it's rarely used and can be be removed. Latest discussions
in W3C have placed it at risk in the spec:
https://github.com/w3c/payment-request/pull/764

Firefox and Safari have removed languageCode from their implementations.

Bug: 877521
Change-Id: I9e137d768be87c6dbc8affd3db3c2d6260ada46b
Reviewed-on: https://chromium-review.googlesource.com/1188489
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589289}
[modify] https://crrev.com/e106362e0688dae13492f027665cfbe5f289dd00/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/e106362e0688dae13492f027665cfbe5f289dd00/third_party/blink/renderer/modules/payments/payment_address.idl
[modify] https://crrev.com/e106362e0688dae13492f027665cfbe5f289dd00/tools/metrics/histograms/enums.xml

Waiting for results...
Usage is negligible. OK to remove.
Labels: -Type-Bug Type-Launch-OWP
Labels: -Type-Launch-OWP Type-Launch
Type-Launch-OWP is deprecated.
Labels: MovedFromTypeLaunchOWP
Labels: Rollout-Type-Default
Bulk Edit: Updating Rollout-Type to Default since no Launch/Target Exp bits are set. 
Please update Rollout-Type to Finch and include Launch/Target Exp bits if not intended be launched as default  

Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Labels: -Type-Launch Type-FLT-Launch FLT-Conversion
Automatic generating of FLT Launch data.
Labels: Restrict-View-Google
Labels: FLT-Conversion-1
Please do not modify this value.
Updating this issue's FLT-Conversion label.
Labels: Type-Feature
Labels: -Restrict-View-Google
Bulk updating old OWP-Launch bugs to once again be public. OWP-Launch (previously used as public/transparent blink launch process) was not supposed to have been remapped to Type=Launch.
Labels: Type-FLT-Launch
Preparing this issue to be converted back into the old format.

Will change Type back to 'Feature' after.
Labels: FLT-Conversion
Labels: Type-Feature
Labels: Type-FLT-Launch
Labels: Type-Feature

Sign in to add a comment