New issue
Advanced search Search tips

Issue 877507 link

Starred by 1 user
Status: Fixed
Owner:
lanwei@chromium.org
Closed: Jan 7
Cc:
nzolghadr@chromium.org
Components:
EstimatedDays: 7
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Change the GpuBenchmarking.PointerActionSequence's input format to match with Webdriver spec

Project Member Reported by lanwei@chromium.org, Aug 24 
The dictionary format of GpuBenchmarking.PointerActionSequence's input does not match with the Webdriver's Actions API, we need to make some change, such as adding pointer id for each pointer and duration for each action.

The format is for each action:
{id, type of the pointer, action type, target or x/y, duration} normal actions down/up/move.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f

commit ae5352b91ee09c54feb9bd91fc915eef5fb29e9f
Author: Lan Wei <lanwei@chromium.org>
Date: Mon Sep 17 18:18:59 2018

Add id in GpuBenchmarking.PointerActionSequence's input

In order to match with Webdriver's Actions API, we need to add an id
for each pointer.

The format is for each action:
{id, type of the pointer, action type, target or x/y, duration}

Bug:  877507 
Change-Id: I507326882de92777485c425f87b7e614ac6ac363
Reviewed-on: https://chromium-review.googlesource.com/1188428
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591743}
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/browser/renderer_host/input/synthetic_mouse_driver.cc
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/browser/renderer_host/input/synthetic_pointer_action.cc
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/browser/renderer_host/input/synthetic_touch_driver.cc
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/browser/renderer_host/input/synthetic_touch_driver.h
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/common/input/synthetic_pointer_action_params.cc
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/common/input/synthetic_pointer_action_params.h
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/common/input/synthetic_web_input_event_builders_unittest.cc
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/common/input_messages.h
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/renderer/gpu/actions_parser.cc
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/renderer/gpu/actions_parser.h
[add] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/renderer/gpu/actions_parser_unittest.cc
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/content/test/BUILD.gn
[modify] https://crrev.com/ae5352b91ee09c54feb9bd91fc915eef5fb29e9f/third_party/WebKit/LayoutTests/fast/events/pointerevents/multi-touch-events.html

Comment 2 by lanwei@chromium.org, Jan 7

Status: Fixed (was: Started)
►

Sign in to add a comment