blink feature BlinkGenPropertyTrees doesn't set use_layer_lists |
|||
Issue description./third_party/blink/tools/run_web_tests.py --debug --additional-driver-flag="--enable-blink-features=BlinkGenPropertyTrees" virtual/gpu/fast/canvas/imagebitmap/bitmaprenderer-as-imagesource.html causes a DCHECK: [1:1:0824/105511.903128:FATAL:paint_artifact_compositor.cc(713)] Check failed: !RuntimeEnabledFeatures::BlinkGenPropertyTreesEnabled() || host->GetSettings().use_layer_lists.
,
Aug 24
I see that now - but how is the rollout going to work? If we can end up with the runtime feature set without the settings matching there will be trouble, no?
,
Aug 24
We'll launch via finch which will control the --enable-blink-gen-property-trees option which turns on both the BlinkGenPropertyTrees runtime enabled feature (for blink) and the use_layer_lists flag for cc. I think it'll all just work. Do you see any issues with the approach? You're hitting the check I added in https://crrev.com/568012 for when the runtime enabled feature flag is used without the use_layer_lists setting. Before that check was added, this situation was suuper confusing.
,
Aug 24
I was looking at the way web API features are rolled out. So if finch can give us command-line switches only, then I think we can get it done. I wonder if we can nerf --enable-blink-features=BlinkGenPropertyTrees so that the error message is appropriate, or the DCHECK more direct.
,
Dec 5
https://chromium-review.googlesource.com/c/chromium/src/+/1355852 looks like it took the first step here. Assigning to pdr@ to finish up, delegate or defer as appropriate.
,
Dec 5
This has been done and --enable-blink-features=BlinkGenPropertyTrees now enables the cc layer list setting. |
|||
►
Sign in to add a comment |
|||
Comment 1 by pdr@chromium.org
, Aug 24