Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/72d438ee5563db3087ea1f6630834343bdb8fb65 (Implement Element#innerText to conform the spec).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

We should use InlineBox::IsInlineTextBox() instead of InlineBox::IsText() before type casting.

In review: http://crrev.com/c/1189242

This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c02e02c4352b0328dc2590afc0d9afa05cbe5012

commit c02e02c4352b0328dc2590afc0d9afa05cbe5012
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Mon Aug 27 09:51:56 2018

Make ElementInnerTextCollector::IsAfterWhiteSpace() to use IsInlineTextBox()

This patch changes  |ElementInnerTextCollector::IsAfterWhiteSpace()| to use
|IsInlineTextBox()| instead of |InlineBox::IsText()| to detect |InlineTextBox|
type properly.

Note: |InlineBox::IsText()| is used for handling <br> in quirk mode, and list
marker.

This patch is follow-up of the patch[1] to fix the bug found by Cluster Fuzz.

[1] http://crrev.com/c/1114673 Implement Element#innerText to conform the spec

Bug:  877498 
Change-Id: I484a93afba351b74a8b3cae0c6736e3ccdfde45d
Reviewed-on: https://chromium-review.googlesource.com/1189242
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586222}
[modify] https://crrev.com/c02e02c4352b0328dc2590afc0d9afa05cbe5012/third_party/blink/renderer/core/editing/BUILD.gn
[modify] https://crrev.com/c02e02c4352b0328dc2590afc0d9afa05cbe5012/third_party/blink/renderer/core/editing/element_inner_text.cc
[add] https://crrev.com/c02e02c4352b0328dc2590afc0d9afa05cbe5012/third_party/blink/renderer/core/editing/element_inner_text_test.cc

Issue 877944 has been merged into this issue.

This is the #1 renderer crash in Windows and Mac, we need the fix to be merged to  3534 branch. Planning to have the dev RC from this branch.

+Sheriff, for merge since committer and reviewers are not in PST time zone.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b45f0ee4c1a5aad340133a553220f66668460e9a

commit b45f0ee4c1a5aad340133a553220f66668460e9a
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Mon Aug 27 19:24:17 2018

Make ElementInnerTextCollector::IsAfterWhiteSpace() to use IsInlineTextBox()

This patch changes  |ElementInnerTextCollector::IsAfterWhiteSpace()| to use
|IsInlineTextBox()| instead of |InlineBox::IsText()| to detect |InlineTextBox|
type properly.

Note: |InlineBox::IsText()| is used for handling <br> in quirk mode, and list
marker.

This patch is follow-up of the patch[1] to fix the bug found by Cluster Fuzz.

[1] http://crrev.com/c/1114673 Implement Element#innerText to conform the spec

Bug:  877498 
Change-Id: I484a93afba351b74a8b3cae0c6736e3ccdfde45d
Reviewed-on: https://chromium-review.googlesource.com/1189242
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#586222}(cherry picked from commit c02e02c4352b0328dc2590afc0d9afa05cbe5012)
Reviewed-on: https://chromium-review.googlesource.com/1191406
Reviewed-by: Alex Mineer <amineer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3534@{#3}
Cr-Branched-From: 5c1309f3276665c501e62f79a3bfb9244b3dca26-refs/heads/master@{#586175}
[modify] https://crrev.com/b45f0ee4c1a5aad340133a553220f66668460e9a/third_party/blink/renderer/core/editing/BUILD.gn
[modify] https://crrev.com/b45f0ee4c1a5aad340133a553220f66668460e9a/third_party/blink/renderer/core/editing/element_inner_text.cc
[add] https://crrev.com/b45f0ee4c1a5aad340133a553220f66668460e9a/third_party/blink/renderer/core/editing/element_inner_text_test.cc

I've merge the change in #9 to today's canary. Yosin@ can you confirm if this is the only fix thats needed?

>#c16, yes, it is the only patch to need to fix this bad-cast.

Issue 878197 has been merged into this issue.

ClusterFuzz testcase 4537013915877376 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

ClusterFuzz has detected this issue as fixed in range 586217:586222.

Detailed report: https://clusterfuzz.com/testcase?key=6120487676280832

Fuzzer: inferno_twister
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x55e48519b240
Crash State:
  Bad-cast to blink::InlineTextBox from blink::InlineBox
  blink::ToInlineTextBox
  blink::ElementInnerTextCollector::IsAfterWhiteSpace
  
Sanitizer: cfi (CFI)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=585744:585770
Fixed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=586217:586222

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6120487676280832

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot