webkit_unit_tests failing on chromium.memory/Linux MSan Tests |
|||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of sahel@chromium.org webkit_unit_tests failing on chromium.memory/Linux MSan Tests Builders failed on: - Linux MSan Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests
,
Aug 24
I'm looking into this now.
,
Aug 24
How close are we to a fix? Should we just disable the failing test in the meantime?
,
Aug 24
,
Aug 24
And its in the CQ now.
,
Aug 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aae4c07adf99290b243707ab75c7f0c3d94bdb14 commit aae4c07adf99290b243707ab75c7f0c3d94bdb14 Author: Khushal <khushalsagar@chromium.org> Date: Sat Aug 25 01:11:07 2018 blink: Use external memory allocator in tests using MockImageDecoder. The caller expects the decoder to populate memory in the allocator if set, but the MockImageDecoder was not doing this. This causes failures in MSAN where the memory remains unitinitialized. Fix MockImageDecoder to respect this expectation. R=chrishtr@chromium.org Bug: 877497 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I441095eb3fb89c90cf3b9bf592438cd20b126391 Reviewed-on: https://chromium-review.googlesource.com/1188877 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#586090} [modify] https://crrev.com/aae4c07adf99290b243707ab75c7f0c3d94bdb14/third_party/blink/renderer/platform/graphics/image_decoder_wrapper.cc [modify] https://crrev.com/aae4c07adf99290b243707ab75c7f0c3d94bdb14/third_party/blink/renderer/platform/graphics/test/mock_image_decoder.h [modify] https://crrev.com/aae4c07adf99290b243707ab75c7f0c3d94bdb14/third_party/blink/renderer/platform/image-decoders/image_decoder.h
,
Aug 25
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sahel@chromium.org
, Aug 24Status: Assigned (was: Available)