New issue
Advanced search Search tips

Issue 877497 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

webkit_unit_tests failing on chromium.memory/Linux MSan Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 24

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of sahel@chromium.org

webkit_unit_tests failing on chromium.memory/Linux MSan Tests

Builders failed on: 
- Linux MSan Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests


 
Owner: khushals...@chromium.org
Status: Assigned (was: Available)
DeferredImageDecoderTest.decodedSize is the test that is failing.

Findit found https://chromium-review.googlesource.com/c/chromium/src/+/1185629 to be the suspected cl, however reverting it has a merge conflict, and https://chromium-review.googlesource.com/c/chromium/src/+/1185793 seems related too.

khushalsagar@ please revert the related cl(s) or land a fix.
I'm looking into this now.
How close are we to a fix? Should we just disable the failing test in the meantime?
Components: Internals>Images
And its in the CQ now.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aae4c07adf99290b243707ab75c7f0c3d94bdb14

commit aae4c07adf99290b243707ab75c7f0c3d94bdb14
Author: Khushal <khushalsagar@chromium.org>
Date: Sat Aug 25 01:11:07 2018

blink: Use external memory allocator in tests using MockImageDecoder.

The caller expects the decoder to populate memory in the allocator if
set, but the MockImageDecoder was not doing this. This causes failures
in MSAN where the memory remains unitinitialized.

Fix MockImageDecoder to respect this expectation.

R=chrishtr@chromium.org

Bug:  877497 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I441095eb3fb89c90cf3b9bf592438cd20b126391
Reviewed-on: https://chromium-review.googlesource.com/1188877
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586090}
[modify] https://crrev.com/aae4c07adf99290b243707ab75c7f0c3d94bdb14/third_party/blink/renderer/platform/graphics/image_decoder_wrapper.cc
[modify] https://crrev.com/aae4c07adf99290b243707ab75c7f0c3d94bdb14/third_party/blink/renderer/platform/graphics/test/mock_image_decoder.h
[modify] https://crrev.com/aae4c07adf99290b243707ab75c7f0c3d94bdb14/third_party/blink/renderer/platform/image-decoders/image_decoder.h

Status: Fixed (was: Assigned)

Sign in to add a comment