New issue
Advanced search Search tips

Issue 877493 link

Starred by 3 users
Status: Fixed
Owner:
lgrey@chromium.org
Closed: Sep 18
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 832676



Sign in to add a comment

MacViews: remove #show-all-dialogs-with-views-toolkit

Project Member Reported by lgrey@chromium.org, Aug 24 
Follow-up from  Issue 838119 

Cocoa secondary UI is non-functional in ToT, so we should remove the flag.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9768c16744f8cb13eebd077afb5c8bf1b19cf96

commit c9768c16744f8cb13eebd077afb5c8bf1b19cf96
Author: Leonard Grey <lgrey@chromium.org>
Date: Tue Aug 28 13:11:11 2018

Mac: Remove Cocoa password reuse dialog

Bug:  877493 
Change-Id: Ifd6be6e313729738546f51164de91febe792281d
Reviewed-on: https://chromium-review.googlesource.com/1191282
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586672}
[modify] https://crrev.com/c9768c16744f8cb13eebd077afb5c8bf1b19cf96/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/c9768c16744f8cb13eebd077afb5c8bf1b19cf96/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc
[modify] https://crrev.com/c9768c16744f8cb13eebd077afb5c8bf1b19cf96/chrome/browser/ui/cocoa/browser_dialogs_views_mac.h
[delete] https://crrev.com/2788e8c958bd4d9e5900acf2f48dddebc5ac5283/chrome/browser/ui/cocoa/password_reuse_warning_dialog_cocoa.h
[delete] https://crrev.com/2788e8c958bd4d9e5900acf2f48dddebc5ac5283/chrome/browser/ui/cocoa/password_reuse_warning_dialog_cocoa.mm
[delete] https://crrev.com/2788e8c958bd4d9e5900acf2f48dddebc5ac5283/chrome/browser/ui/cocoa/password_reuse_warning_view_controller.h
[delete] https://crrev.com/2788e8c958bd4d9e5900acf2f48dddebc5ac5283/chrome/browser/ui/cocoa/password_reuse_warning_view_controller.mm
[modify] https://crrev.com/c9768c16744f8cb13eebd077afb5c8bf1b19cf96/chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7409c04c148b118bd4d8029ac44e8f946d54a9af

commit 7409c04c148b118bd4d8029ac44e8f946d54a9af
Author: Leonard Grey <lgrey@chromium.org>
Date: Tue Aug 28 14:38:57 2018

Mac: Remove Cocoa-dialog path in Cocoa app menu anchoring code

Bug:  877493 
Change-Id: Iba8ba4941c2751fc6a77edc258e066cfc8ecb5ca
Reviewed-on: https://chromium-review.googlesource.com/1191248
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586690}
[modify] https://crrev.com/7409c04c148b118bd4d8029ac44e8f946d54a9af/chrome/browser/ui/cocoa/app_menu/app_menu_controller.h
[modify] https://crrev.com/7409c04c148b118bd4d8029ac44e8f946d54a9af/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm
[modify] https://crrev.com/7409c04c148b118bd4d8029ac44e8f946d54a9af/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47421c6017f558f53945d65ffc509305932a2345

commit 47421c6017f558f53945d65ffc509305932a2345
Author: Leonard Grey <lgrey@chromium.org>
Date: Fri Sep 14 15:14:32 2018

Mac: Remove pre-Harmony/Polychrome tab dialogs code

We can't remove TabDialogsCocoa yet because TabDialogsMac uses it.

Bug:  877493 
Change-Id: I07d1f203fb0e0868167a4a65cbcd661bb118a7c5
Reviewed-on: https://chromium-review.googlesource.com/1226300
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591348}
[modify] https://crrev.com/47421c6017f558f53945d65ffc509305932a2345/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
[modify] https://crrev.com/47421c6017f558f53945d65ffc509305932a2345/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cd833dcdd2fa9141c586b5367ef5c646bb588d4

commit 7cd833dcdd2fa9141c586b5367ef5c646bb588d4
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Sep 17 16:07:30 2018

Mac: Remove Cocoa toolbar action bubble path

Bug:  877493 
Change-Id: I388f9889016b9288cd8c18def7e86debc59b1509
Reviewed-on: https://chromium-review.googlesource.com/1226000
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591694}
[modify] https://crrev.com/7cd833dcdd2fa9141c586b5367ef5c646bb588d4/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/7cd833dcdd2fa9141c586b5367ef5c646bb588d4/chrome/browser/ui/cocoa/extensions/browser_actions_controller.h
[modify] https://crrev.com/7cd833dcdd2fa9141c586b5367ef5c646bb588d4/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
[delete] https://crrev.com/af96b5268a067e00808bc75701e2381f2fc2bb7d/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h
[delete] https://crrev.com/af96b5268a067e00808bc75701e2381f2fc2bb7d/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm
[delete] https://crrev.com/af96b5268a067e00808bc75701e2381f2fc2bb7d/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac_unittest.mm
[modify] https://crrev.com/7cd833dcdd2fa9141c586b5367ef5c646bb588d4/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_views_presenter.mm
[modify] https://crrev.com/7cd833dcdd2fa9141c586b5367ef5c646bb588d4/chrome/test/BUILD.gn
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f091ed970c021da17bc0dbabb198dfea03e23aea

commit f091ed970c021da17bc0dbabb198dfea03e23aea
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Sep 17 17:02:27 2018

Mac: Secondary UI cleanup in content setting decoration

Bug:  877493 
Change-Id: Ia449b73674ebc896ae1dd42f736206d7873dd38a
Reviewed-on: https://chromium-review.googlesource.com/1227250
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591712}
[modify] https://crrev.com/f091ed970c021da17bc0dbabb198dfea03e23aea/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm

Comment 11 by lgrey@chromium.org, Sep 18

Status: Fixed (was: Assigned)

Comment 12 by thakis@chromium.org, Sep 20

Blocking: 832676
►

Sign in to add a comment