[Android] Custom dividers in preferences look different from the standard ones |
||
Issue descriptionHorisontalDivider[1] looks thicker than the standard ones on all supported Android versions (at least from Android K to Android P). In the attached screenshots first two dividers are standard, but the third one uses HorisontalDivider (via divider_preference). The difference isn't drastic, so it may require some zooming in to spot. [1] https://cs.chromium.org/chromium/src/chrome/android/java/res/values-v17/styles.xml?l=224&rcl=825da604d1333757aaf6988200909104ab9d0c25
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8870a40c710ade20dce7ff19801a4b2bd92fcb6 commit d8870a40c710ade20dce7ff19801a4b2bd92fcb6 Author: Boris Sazonov <bsazonov@chromium.org> Date: Tue Aug 28 18:16:55 2018 [Android] Use listDivider theme attribute for dividers Previous divider implementation looked thicker than the standard ones (see the bug for screenshots). This CL fixes the issue by using listDivider theme attribute instead of explicitly specifying divider size and color. This CL also introduces a couple of textApperance styles to overcome presubmit errors. Bug: 877482 Change-Id: Iab448228ca34cd1d6fd443768fe009b14d7f9e3e Reviewed-on: https://chromium-review.googlesource.com/1191703 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#586789} [modify] https://crrev.com/d8870a40c710ade20dce7ff19801a4b2bd92fcb6/chrome/android/java/res/values-v17/styles.xml
,
Sep 11
|
||
►
Sign in to add a comment |
||
Comment 1 by bsazonov@chromium.org
, Aug 27