Issue metadata
Sign in to add a comment
|
SVG element can cause bad-cast to LayoutTableCell |
||||||||||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=4547399130021888 Fuzzer: inferno_twister_c Job Type: linux_ubsan_vptr_content_shell_drt Platform Id: linux Crash Type: Bad-cast Crash Address: 0x3fbf79430000 Crash State: Bad-cast to const blink::LayoutTableCell from blink::LayoutSVGRect blink::ElementInnerTextCollector::ProcessNode blink::ElementInnerTextCollector::ProcessNode Sanitizer: undefined (UBSAN) Recommended Security Severity: High Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=585755:585756 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4547399130021888 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Aug 24
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/72d438ee5563db3087ea1f6630834343bdb8fb65 (Implement Element#innerText to conform the spec). If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
,
Aug 24
,
Aug 24
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it. If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 24
,
Aug 25
In review: http://crrev.com/c/1189262 e.g. <svg><rect style="display:table-cell"></rect></svg>
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65f45f33e67c11337337bb511e62a939ac8f2b7e commit 65f45f33e67c11337337bb511e62a939ac8f2b7e Author: Yoshifumi Inoue <yosin@chromium.org> Date: Mon Aug 27 11:00:16 2018 Make ElementInnerTextCollector::ProcessNode() to check LayoutTabelCell This patch changes |ElementInnerTextCollector::ProcessNode()| to check object type before casting to |LayoutTableCell|. The issue is caused by |LayoutSVGRect|'s computed style of "display" property is "table-cell". This patch is follow-up of the patch[1] to fix the bug found by Cluster Fuzz. [1] http://crrev.com/c/1114673 Implement Element#innerText to conform the spec Bug: 877470 Change-Id: I8bf833c66770f1f0dbace7c45bc22f6a5c0cfa26 Reviewed-on: https://chromium-review.googlesource.com/1189262 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#586229} [modify] https://crrev.com/65f45f33e67c11337337bb511e62a939ac8f2b7e/third_party/blink/renderer/core/editing/element_inner_text.cc [modify] https://crrev.com/65f45f33e67c11337337bb511e62a939ac8f2b7e/third_party/blink/renderer/core/editing/element_inner_text_test.cc
,
Aug 27
,
Aug 27
,
Aug 28
ClusterFuzz has detected this issue as fixed in range 586228:586229. Detailed report: https://clusterfuzz.com/testcase?key=4547399130021888 Fuzzer: inferno_twister_c Job Type: linux_ubsan_vptr_content_shell_drt Platform Id: linux Crash Type: Bad-cast Crash Address: 0x3fbf79430000 Crash State: Bad-cast to const blink::LayoutTableCell from blink::LayoutSVGRect blink::ElementInnerTextCollector::ProcessNode blink::ElementInnerTextCollector::ProcessNode Sanitizer: undefined (UBSAN) Recommended Security Severity: High Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=585755:585756 Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=586228:586229 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4547399130021888 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Aug 28
ClusterFuzz testcase 4547399130021888 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Sep 25
,
Dec 3
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ClusterFuzz
, Aug 24Labels: Test-Predator-Auto-Components