New issue
Advanced search Search tips

Issue 877461 link

Starred by 1 user
Status: Assigned
Owner:
wychen@chromium.org
Cc:
mlippautz@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DomDistillerJsTest.RunJsTests flaky when executing ImageExtractor tests

Project Member Reported by mlippautz@chromium.org, Aug 24 
Images are loaded asynchronously, event when loading from a base64 source.

This makes the ImageExtractor tests that are part of DomDistillerJsTest.RunJsTests flaky. 

The flakiness was observed when changing V8's garbage collection heuristics to schedule slightly more GCs during test execution.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/587c45991d705ba135d4af9da4f1a22d0614aade

commit 587c45991d705ba135d4af9da4f1a22d0614aade
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue Aug 28 07:47:53 2018

dom-distiller: Filter flaky tests

The tests rely on synchronous image construction and flake if
construction is delayed by e.g. garbage collection.

Bug: 877461
Change-Id: I976af5b362687839dba091322c4682719ddf84dc
Reviewed-on: https://chromium-review.googlesource.com/1190623
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586613}
[modify] https://crrev.com/587c45991d705ba135d4af9da4f1a22d0614aade/components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc
►

Sign in to add a comment