New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 877460 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 18 days ago
Closed: Aug 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Down Arrow key input hold and release cause wallpaper page to scroll back to original position

Reported by khushal....@etouch.net, Aug 24

Issue description

Chrome Version: 70.0.3532.0 (Official Build) Revision 9370f7bac1142a9288e4c29f9e659c5dc63858f3-refs/branch-heads/3532@{#1} (32/64-bit)

OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS)

Pre-condition: Enable the flag 'Enable using the Google local NTP' and 'New Tab Page Background Selection' from chrome://flags/

What steps will reproduce the problem?
(1) Launch chrome, open NTP and click on gear icon then select 'Choose background' option ('Select a collection' overlay will open).
(2) Select any collection and bring focus on wallpaper.
(3) Now to scroll wallpapers hold the down arrow key and release after few scrolls and Observe.

Actual Result: Down Arrow key input hold and release cause wallpaper page to scroll back to original position.

Expected Result: Wallpaper page should scroll to the position where Down Arrow key hold is released.

This is a Regression issue seen from 'M-70' and providing the bisect info below:
Good Build: 70.0.3503.0 (Revision: 578160)
Bad Build:  70.0.3504.0 (Revision: 578510)

You are probably looking for a change made after 578169 (known good), but no later than 578170 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/7637ae87b8e8ef651fdcd15e8ace6da78053e6b0..b315c20043e0a5ad29ed29ce7d47aaba043b8204

Suspect: https://chromium.googlesource.com/chromium/src/+/b315c20043e0a5ad29ed29ce7d47aaba043b8204

@kmilka: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: Issue is also seen on M-70 Dev (build #70.0.3528.4).

Kindly refer the attached screen-cast.

Thank You..!!

 
Actual Video.mov
12.8 MB View Download
Expected Video.mov
10.2 MB View Download
Cc: sweilun@chromium.org
+sweilun: I think https://crrev.com/c/1187236 will fix this? Or make it obsolete.
Owner: sweilun@chromium.org
Weilun - can you check if this is related to https://chromium-review.googlesource.com/c/chromium/src/+/1186073?
Cc: kristip...@chromium.org
Another thing to note here: enabling ntp-backgrounds should enable icons instead of thumbnails. This is the case in M69Beta, but that doesn't occur in the screencast. Please take a look at what's changed there.
This should not related to https://chromium-review.googlesource.com/c/chromium/src/+/1186073?. That cl only modify the "customized this page" dialog's event listener. However, once https://crrev.com/c/1187236 landed, this problem should be obsolete.
That CL has landed. Please check if the issue still exists and change to the appropriate status.
Labels: TE-Verified-M70 TE-Verified-70.0.3534.0
With respect to comment #5,

Rechecked the above issue on Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS) using latest canary version 70.0.3534.0 and the issue is found FIXED.
Hence, adding respective labels.

Please refer the attached screen-cast.

Thank You..!!
Fixed Video.mov
10.8 MB View Download
Status: WontFix (was: Assigned)
Status: Fixed (was: WontFix)
Weilun - I'm assuming you meant to tag this as "Fixed" not "WontFix" :)

Sign in to add a comment