Consider redirecting Dailymotion old flash embed to the html video player
Reported by
florian....@dailymotion.com,
Aug 24
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36 Example URL: http://flashembed.surge.sh/ Steps to reproduce the problem: Load http://flashembed.surge.sh/ What is the expected behavior? Dailymotion old flash embeds should be redirected to the html video player when the MIME type application/x-shockwave-flash is specified. Same as old flash YouTube embeds What went wrong? Dailymotion old flash embed are not redirected. Did this work before? N/A Is it a problem with Flash or HTML5? Flash Does this work in other browsers? Yes Chrome version: 68.0.3440.106 Channel: stable OS Version: OS X 10.12.6 Flash Version: Contents of chrome://gpu: Graphics Feature Status Canvas: Hardware accelerated Flash: Hardware accelerated Flash Stage3D: Hardware accelerated Flash Stage3D Baseline profile: Hardware accelerated Compositing: Hardware accelerated Multiple Raster Threads: Enabled Native GpuMemoryBuffers: Hardware accelerated Hardware Protected Video Decode: Unavailable Rasterization: Hardware accelerated Skia Deferred Display List: Disabled Skia Renderer: Disabled Surface Synchronization: Enabled Video Decode: Hardware accelerated Viz Service Display Compositor: Disabled WebGL: Hardware accelerated WebGL2: Hardware accelerated Driver Bug Workarounds add_and_true_to_loop_condition adjust_src_dst_region_for_blitframebuffer decode_encode_srgb_for_generatemipmap disable_2d_canvas_auto_flush disable_framebuffer_cmaa disable_webgl_rgb_multisampling_usage dont_use_loops_to_initialize_variables emulate_abs_int_function emulate_isnan_on_float flush_on_framebuffer_change get_frag_data_info_bug init_two_cube_map_levels_before_copyteximage max_msaa_sample_count_4 msaa_is_slow pack_parameters_workaround_with_pack_buffer rebind_transform_feedback_before_resume regenerate_struct_names remove_invariant_and_centroid_for_essl3 reset_teximage2d_base_level rewrite_texelfetchoffset_to_texelfetch scalarize_vec_and_mat_constructor_args set_zero_level_before_generating_mipmap unfold_short_circuit_as_ternary_operation unpack_alignment_workaround_with_unpack_buffer unpack_image_height_workaround_with_unpack_buffer use_intermediary_for_copy_texture_image use_unused_standard_shared_blocks Problems Detected Protected video decoding with swap chain is for Windows and Intel only Disabled Features: protected_video_decode Unfold short circuit on Mac OS X: 307751 Applied Workarounds: unfold_short_circuit_as_ternary_operation Always rewrite vec/mat constructors to be consistent: 398694 Applied Workarounds: scalarize_vec_and_mat_constructor_args Mac drivers handle struct scopes incorrectly: 403957 Applied Workarounds: regenerate_struct_names On Intel GPUs MSAA performance is not acceptable for GPU rasterization: 527565 Applied Workarounds: msaa_is_slow glGenerateMipmap fails if the zero texture level is not set on some Mac drivers: 560499 Applied Workarounds: set_zero_level_before_generating_mipmap Pack parameters work incorrectly with pack buffer bound: 563714 Applied Workarounds: pack_parameters_workaround_with_pack_buffer Alignment works incorrectly with unpack buffer bound: 563714 Applied Workarounds: unpack_alignment_workaround_with_unpack_buffer copyTexImage2D fails when reading from IOSurface on multiple GPU types.: 581777 Applied Workarounds: use_intermediary_for_copy_texture_image Multisample renderbuffers with format GL_RGB8 have performance issues on Intel GPUs.: 607130 Applied Workarounds: disable_webgl_rgb_multisampling_usage Use GL_INTEL_framebuffer_CMAA on ChromeOS: 535198 Applied Workarounds: disable_framebuffer_cmaa glGetFragData{Location|Index} works incorrectly on Max: 638340 Applied Workarounds: get_frag_data_info_bug glResumeTransformFeedback works incorrectly on Intel GPUs: 638514 Applied Workarounds: rebind_transform_feedback_before_resume Result of abs(i) where i is an integer in vertex shader is wrong: 642227 Applied Workarounds: emulate_abs_int_function Rewrite texelFetchOffset to texelFetch for Intel Mac: 642605 Applied Workarounds: rewrite_texelfetchoffset_to_texelfetch Rewrite condition in for and while loops for Intel Mac: 644669 Applied Workarounds: add_and_true_to_loop_condition Emulate GLSL function isnan() on Intel Mac: 650547 Applied Workarounds: emulate_isnan_on_float Decode and encode before generateMipmap for srgb format textures on macosx: 634519 Applied Workarounds: decode_encode_srgb_for_generatemipmap Init first two levels before CopyTexImage2D for cube map texture on Intel Mac 10.12: 648197 Applied Workarounds: init_two_cube_map_levels_before_copyteximage Insert statements to reference all members in unused std140/shared blocks on Mac: 618464 Applied Workarounds: use_unused_standard_shared_blocks Tex(Sub)Image3D performs incorrectly when uploading from unpack buffer with GL_UNPACK_IMAGE_HEIGHT greater than zero on Intel Macs: 654258 Applied Workarounds: unpack_image_height_workaround_with_unpack_buffer adjust src/dst region if blitting pixels outside read framebuffer on Mac: 644740 Applied Workarounds: adjust_src_dst_region_for_blitframebuffer Mac driver GL 4.1 requires invariant and centroid to match between shaders: 639760, 641129 Applied Workarounds: remove_invariant_and_centroid_for_essl3 Disable KHR_blend_equation_advanced until cc shaders are updated: 661715 Applied Workarounds: disable(GL_KHR_blend_equation_advanced), disable(GL_KHR_blend_equation_advanced_coherent) Reset TexImage2D base level to 0 on Intel Mac 10.12.4: 705865 Applied Workarounds: reset_teximage2d_base_level Switching framebuffers without a flush can lead to crashes on Intel 9th Generation GPU Macs.: 783979 Applied Workarounds: flush_on_framebuffer_change Don't expose disjoint_timer_query extensions to WebGL: 808744 Shader variable initialization in a loop caused perf regression on Mac Intel.: 809422 Applied Workarounds: dont_use_loops_to_initialize_variables 8x MSAA is slow for alpha:false WebGL contexts on Mac Intel: 812071 Applied Workarounds: max_msaa_sample_count_4 glFlush error on Mac: 841755 Applied Workarounds: disable_2d_canvas_auto_flush Viz service display compositor is not enabled by default. Disabled Features: viz_display_compositor Skia renderer is not used by default. Disabled Features: skia_renderer Skia deferred display list is not used by default. Disabled Features: skia_deferred_display_list Version Information Data exported 2018-08-24T11:00:25.500Z Chrome version Chrome/68.0.3440.106 Operating system Mac OS X 10.12.6 Software rendering list URL https://chromium.googlesource.com/chromium/src/+/1c32c539ce0065a41cb79da7bfcd2c71af1afe62/gpu/config/software_rendering_list.json Driver bug list URL https://chromium.googlesource.com/chromium/src/+/1c32c539ce0065a41cb79da7bfcd2c71af1afe62/gpu/config/gpu_driver_bug_list.json ANGLE commit id ba1627086779 2D graphics backend Skia/68 1e419fead7ff3b5247102b29b982b6472a60cd4d- Command Line /Applications/Google Chrome.app/Contents/MacOS/Google Chrome --flag-switches-begin --flag-switches-end Driver Information Initialization time 55 In-process GPU false Passthrough Command Decoder false Direct Composition false Supports overlays false Sandboxed true GPU0 VENDOR = 0x8086 [Intel Inc.], DEVICE= 0x1927 [Intel(R) Iris(TM) Graphics 550] *ACTIVE* Optimus false AMD switchable false Driver vendor INTEL Driver version 10.25.19 Driver date Pixel shader version 4.10 Vertex shader version 4.10 Max. MSAA samples 16 Machine model name MacBookPro Machine model version 13.2 GL_VENDOR Intel Inc. GL_RENDERER Intel(R) Iris(TM) Graphics 550 GL_VERSION 4.1 INTEL-10.25.19 GL_EXTENSIONS GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier Disabled Extensions GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent Disabled WebGL Extensions EXT_disjoint_timer_query EXT_disjoint_timer_query_webgl2 Window system binding vendor Window system binding version Window system binding extensions Direct rendering Yes Reset notification strategy 0x0000 GPU process crash count 0 Compositor Information Tile Update Mode Zero-copy Partial Raster Enabled GpuMemoryBuffers Status ATC Software only ATCIA Software only DXT1 Software only DXT5 Software only ETC1 Software only R_8 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT R_16 Software only RG_88 Software only BGR_565 Software only RGBA_4444 Software only RGBX_8888 Software only RGBA_8888 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT BGRX_8888 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE BGRX_1010102 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT RGBX_1010102 Software only BGRA_8888 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT RGBA_F16 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT YVU_420 Software only YUV_420_BIPLANAR GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT UYVY_422 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT Display(s) Information Info Display[69733568] bounds=[0,0 1440x900], workarea=[0,23 1440x797], scale=2, external. Color space information {primaries_d50_referred: [[0.6818, 0.3196], [0.2846, 0.6747], [0.1576, 0.0554]], transfer:0.0777*x + 0.0000 if x < 0.0450 else (0.9478*x + 0.0521)**2.4000 + -0.0000, matrix:RGB, range:FULL} Bits per color component 8 Bits per pixel 24 Info Display[725376205] bounds=[-1680,-60 1680x1050], workarea=[-1680,-37 1680x1027], scale=1, external. Color space information {primaries_d50_referred: [[0.6502, 0.3407], [0.3277, 0.6130], [0.1576, 0.0642]], transfer:0.0777*x + 0.0000 if x < 0.0450 else (0.9478*x + 0.0521)**2.4000 + -0.0000, matrix:RGB, range:FULL} Bits per color component 8 Bits per pixel 24 Video Acceleration Information Decode h264 baseline up to 4096x2160 pixels Decode h264 extended up to 4096x2160 pixels Decode h264 main up to 4096x2160 pixels Decode h264 high up to 4096x2160 pixels Encode h264 baseline up to 4096x2160 pixels and/or 30.000 fps Encode h264 main up to 4096x2160 pixels and/or 30.000 fps Encode h264 high up to 4096x2160 pixels and/or 30.000 fps Log Messages [618:775:0824/112015.027920:ERROR:gles2_cmd_decoder.cc(18008)] : [.DisplayCompositor-0x7fa8d79a0000]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name [618:775:0824/112015.028016:ERROR:gles2_cmd_decoder.cc(12468)] : [.DisplayCompositor-0x7fa8d79a0000]GL ERROR :GL_INVALID_VALUE : glScheduleCALayerCHROMIUM: unsupported texture format [618:775:0824/112015.028041:ERROR:gles2_cmd_decoder.cc(18008)] : [.DisplayCompositor-0x7fa8d79a0000]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name [618:775:0824/112015.028062:ERROR:gles2_cmd_decoder.cc(12468)] : [.DisplayCompositor-0x7fa8d79a0000]GL ERROR :GL_INVALID_VALUE : glScheduleCALayerCHROMIUM: unsupported texture format [618:775:0824/112015.921020:ERROR:gles2_cmd_decoder.cc(18008)] : [.DisplayCompositor-0x7fa8d79a0000]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name [618:775:0824/112015.921127:ERROR:gles2_cmd_decoder.cc(12468)] : [.DisplayCompositor-0x7fa8d79a0000]GL ERROR :GL_INVALID_VALUE : glScheduleCALayerCHROMIUM: unsupported texture format [618:775:0824/112015.921164:ERROR:gles2_cmd_decoder.cc(18008)] : [.DisplayCompositor-0x7fa8d79a0000]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name [618:775:0824/112015.921188:ERROR:gles2_cmd_decoder.cc(12468)] : [.DisplayCompositor-0x7fa8d79a0000]GL ERROR :GL_INVALID_VALUE : glScheduleCALayerCHROMIUM: unsupported texture format [618:775:0824/120550.516214:ERROR:gles2_cmd_decoder.cc(18008)] : [.DisplayCompositor-0x7fa8df96ee00]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name [618:775:0824/120550.516321:ERROR:gles2_cmd_decoder.cc(12468)] : [.DisplayCompositor-0x7fa8df96ee00]GL ERROR :GL_INVALID_VALUE : glScheduleCALayerCHROMIUM: unsupported texture format [618:775:0824/120550.516351:ERROR:gles2_cmd_decoder.cc(18008)] : [.DisplayCompositor-0x7fa8df96ee00]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name [618:775:0824/120550.516373:ERROR:gles2_cmd_decoder.cc(12468)] : [.DisplayCompositor-0x7fa8df96ee00]GL ERROR :GL_INVALID_VALUE : glScheduleCALayerCHROMIUM: unsupported texture format [618:775:0824/122830.773542:ERROR:gles2_cmd_decoder.cc(18008)] : [.DisplayCompositor-0x7fa8df96ee00]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name [618:775:0824/122830.773673:ERROR:gles2_cmd_decoder.cc(12468)] : [.DisplayCompositor-0x7fa8df96ee00]GL ERROR :GL_INVALID_VALUE : glScheduleCALayerCHROMIUM: unsupported texture format [618:775:0824/122830.773715:ERROR:gles2_cmd_decoder.cc(18008)] : [.DisplayCompositor-0x7fa8df96ee00]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name [618:775:0824/122830.773748:ERROR:gles2_cmd_decoder.cc(12468)] : [.DisplayCompositor-0x7fa8df96ee00]GL ERROR :GL_INVALID_VALUE : glScheduleCALayerCHROMIUM: unsupported texture format Chrome has implemeted a built in rewrite rule to automatically use the html5 YouTube embed instead of their old Flash embed. See https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/BW8g1iB0jLs/uddWuBroBAAJ My question is do you plan to implement this kind of rules for other video platforms like Dailymotion or Vimeo ? A more generic approach would probably even be better. At the moment, on Chrome, even with a redirection server side from the swf endpoint to the html endpoint as long as the MIME type application/x-shockwave-flash is specified in the old embed it will prevent all request and any redirection. On Firefox, http://flashembed.surge.sh/ is able to display the html Dailymotion embed meaning that the browser is able to follow the server redirection.
,
Aug 24
,
Aug 26
,
Aug 27
Hi there, The spec are quite simple: - There is only one domain => "dailymotion.com" - 2 paths to the dailymotion swf embed are possible => "/swf/" or "/swf/video/" and they should be rewrite in "/embed/video/" - the query string can simply be transferred For instance https://www.dailymotion.com/swf/VIDEOID?autoplay=1&api=1 or https://www.dailymotion.com/swf/video/VIDEOID?autoplay=1&api=1 will become https://www.dailymotion.com/embed/video/VIDEOID?autoplay=1&api=1 Thanks for your precious help.
,
Aug 31
Able to reproduce the issue on reported chromium version 68.0.3440.106 also on latest chrome 70.0.3538.0 using Mac 10.13.6, Ubuntu 17.10 and Windows 10. Same behavior is seen on M60(60.0.3112.113) hence considering it as non-regression and marking it as Untriaged. Thanks!
,
Aug 31
,
Aug 31
=>mlamouri since he is most familiar here.
,
Dec 16
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a85eb7444ffd5f37205472aa55e2520cf96faa0a commit a85eb7444ffd5f37205472aa55e2520cf96faa0a Author: Mounir Lamouri <mlamouri@chromium.org> Date: Tue Dec 18 13:10:49 2018 Flash Embed Rewrite: refactor code to make it simpler to add support for other websites. Bug: 877439 Change-Id: I25c23fc0328bfeb5fbc9e1f09174120593b8ca42 Reviewed-on: https://chromium-review.googlesource.com/c/1379522 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#617461} [modify] https://crrev.com/a85eb7444ffd5f37205472aa55e2520cf96faa0a/chrome/renderer/BUILD.gn [modify] https://crrev.com/a85eb7444ffd5f37205472aa55e2520cf96faa0a/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/a85eb7444ffd5f37205472aa55e2520cf96faa0a/chrome/renderer/chrome_content_renderer_client.h [modify] https://crrev.com/a85eb7444ffd5f37205472aa55e2520cf96faa0a/chrome/renderer/chrome_content_renderer_client_unittest.cc [modify] https://crrev.com/a85eb7444ffd5f37205472aa55e2520cf96faa0a/chrome/renderer/media/OWNERS [add] https://crrev.com/a85eb7444ffd5f37205472aa55e2520cf96faa0a/chrome/renderer/media/flash_embed_rewrite.cc [add] https://crrev.com/a85eb7444ffd5f37205472aa55e2520cf96faa0a/chrome/renderer/media/flash_embed_rewrite.h [add] https://crrev.com/a85eb7444ffd5f37205472aa55e2520cf96faa0a/chrome/renderer/media/flash_embed_rewrite_unittest.cc [modify] https://crrev.com/a85eb7444ffd5f37205472aa55e2520cf96faa0a/chrome/test/BUILD.gn
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bb0d7f300c5c14d2abf9c8bff28ab0a99b363f6 commit 1bb0d7f300c5c14d2abf9c8bff28ab0a99b363f6 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Wed Jan 02 14:40:28 2019 Flash Embed Rewrite: implement feature for Dailymotion embeds. Bug: 877439 Change-Id: I59b543b55281dda5b77cfebd1115a1b43e2fc810 Reviewed-on: https://chromium-review.googlesource.com/c/1379523 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#619399} [modify] https://crrev.com/1bb0d7f300c5c14d2abf9c8bff28ab0a99b363f6/chrome/renderer/media/flash_embed_rewrite.cc [modify] https://crrev.com/1bb0d7f300c5c14d2abf9c8bff28ab0a99b363f6/chrome/renderer/media/flash_embed_rewrite.h [modify] https://crrev.com/1bb0d7f300c5c14d2abf9c8bff28ab0a99b363f6/chrome/renderer/media/flash_embed_rewrite_unittest.cc [modify] https://crrev.com/1bb0d7f300c5c14d2abf9c8bff28ab0a99b363f6/tools/metrics/histograms/histograms.xml
,
Jan 3
Tested on 73.0.3660.0 and it's working. Thanks for filing the bug and sorry for the delay. I filed bug 918826 for vimeo.
,
Jan 3
,
Jan 3
,
Jan 14
A huge thank you for the fix :clap:. This is really awesome. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mlamouri@chromium.org
, Aug 24