Issue metadata
Sign in to add a comment
|
Regression: Weird blue patch is seen over tab strip area after applying theme.
Reported by
db...@etouch.net,
Aug 24
|
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3532.0 Revision 9370f7bac1142a9288e4c29f9e659c5dc63858f3-refs/branch-heads/3532@{#1}(64 bit) OS: Mac(10.12.6, 10.13.1, 10.13.6,10.14) URL: https://chrome.google.com/webstore/detail/dark-theme-v3/djlgdeklopcjagknhlchbdjekgpgenad What steps will reproduce the problem? (1) Launch chrome, navigate to above url and click on 'ADD TO CHROME' button. (2) After applying theme, toggle browser to Fullscreen mode and hover mouse over tab strip area (3) Observe. Actual: Weird blue patch is seen over tab strip area after appling theme. Expected: No such a patch should seen. This is a regression issue, broken in 'M-69', below is bisect info: Good Build:69.0.3496.0(Revision:576217) Bad Build:69.0.3497.0(Revision:576753) You are probably looking for a change made after 576532 (known good), but no later than 576533 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/ed9ddcaef93429474b18266245e9662cb375cb0b..1406837c85633743729c75ec61f02e45b852f1f2 Suspect: https://chromium.googlesource.com/chromium/src/+/1406837c85633743729c75ec61f02e45b852f1f2 weili@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: This is Mac OS specific issue and same is not reproducible on Windows(7,8,8.1,10) & Linux(14.04 LTS) OS.
,
Aug 24
Pretty sure this is the same root cause as: https://www.reddit.com/r/chrome/comments/99sv2k/please_test_your_custom_systemchrome_themes_in/e4qbirn/?context=3 It's possible we're not painting this area at all. Not sure. Would be good to try and avoid regressing this in M69 if possible, which gives it a very tight timeframe to be fixed.
,
Aug 24
,
Aug 24
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1da75893a70709938668f553889d7a6be0fd47d0 commit 1da75893a70709938668f553889d7a6be0fd47d0 Author: Wei Li <weili@chromium.org> Date: Mon Aug 27 21:26:52 2018 Paint theme background correctly on Mac fullscreen In fullscreen, the top menu bar may slide down on Mac. Chrome shift the top UI under the menu bar. In such case, we should paint the theme according to the new location. This CL fixes this by taking that Y offset shift into account. BUG= 877438 Change-Id: I073fe3641b0d37af1d87b73fea79cebc8f71c94f Reviewed-on: https://chromium-review.googlesource.com/1188834 Reviewed-by: Sidney San Martín <sdy@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#586420} [modify] https://crrev.com/1da75893a70709938668f553889d7a6be0fd47d0/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h [modify] https://crrev.com/1da75893a70709938668f553889d7a6be0fd47d0/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
,
Aug 28
,
Aug 28
This should be an isolated fix, could we consider merging it into M69?
,
Aug 28
This bug requires manual review: We are only 6 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 28
M69 is VERY close to stable promotion, how safe and critical is this merge for M69?
,
Aug 28
It is a one line change in essence. I feel it is safe to merge. Without merging, I think custom theme users on Mac will notice this in stable anyway, which will result in a merge to stable. thanks.
,
Aug 28
Merge sounds good to me.
,
Aug 28
Approving merge to M69 branch 3497 based on comments #8, #11 and #12. Please merge now. Thank you.
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84147e78305ab70a9cb1e87571f224bb422299e2 commit 84147e78305ab70a9cb1e87571f224bb422299e2 Author: Wei Li <weili@chromium.org> Date: Tue Aug 28 19:46:36 2018 Paint theme background correctly on Mac fullscreen In fullscreen, the top menu bar may slide down on Mac. Chrome shift the top UI under the menu bar. In such case, we should paint the theme according to the new location. This CL fixes this by taking that Y offset shift into account. TBR=ellyjones@chromium.org BUG= 877438 Change-Id: I073fe3641b0d37af1d87b73fea79cebc8f71c94f Reviewed-on: https://chromium-review.googlesource.com/1188834 Reviewed-by: Sidney San Martín <sdy@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#586420}(cherry picked from commit 1da75893a70709938668f553889d7a6be0fd47d0) Reviewed-on: https://chromium-review.googlesource.com/1194736 Reviewed-by: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#833} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/84147e78305ab70a9cb1e87571f224bb422299e2/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h [modify] https://crrev.com/84147e78305ab70a9cb1e87571f224bb422299e2/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
,
Aug 29
Update: Retested above issue on latest Beta build #69.0.3497.72 using Mac(10.12.6, 10.13.1, 10.13.6,10.14) OS,issue is fixed and working as intended. Thank you. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by db...@etouch.net
, Aug 24