New issue
Advanced search Search tips

Issue 877425 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

App crashes on deleting the last readinglist article using swipe gesture

Project Member Reported by rakurati@chromium.org, Aug 24

Issue description

App Version: 69.0.3497.58 beta
iOS Version: 12 beta 9 only
Device: iPhone, iPad

Steps to reproduce:
1. Launch chrome 
2. Add an article to reading list
3. Open reading list
4. Swipe right to left on the article and tap on the delete button

Observed results:
Notice that app crashes

Expected results:
App shouldn’t crash

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): No on M68 (swipe function is available from UI refresh)
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M69 

Link to video:
https://drive.google.com/file/d/14o3SSxbWvVjNwZuOHYH3LJPhBLocYbhl/view?usp=sharing

Link to crash log:
https://crash.corp.google.com/browse?stbtiq=c6b8b09396a0e1fa

Stack Trace:
Thread 0 (id: 0x303) CRASHED [EXC_SOFTWARE / UNCAUGHT_NS_EXCEPTION @ 0x00000001f3a2bef8 ] MAGIC SIGNATURE THREAD
Stack Quality0%Show frame trust levels
0x00000001f3a2bef8	(CoreFoundation + 0x0011def8 )	
0x00000001f2bf9a3c	(libobjc.A.dylib + 0x00006a3c )	
0x00000001f39a1858	(CoreFoundation + 0x00093858 )	
0x00000001f391aa40	(CoreFoundation + 0x0000ca40 )	
0x00000001f39141a4	(CoreFoundation + 0x000061a4 )	
0x0000000220655964	(UIKitCore + 0x00894964 )	
0x000000022062a16c	(UIKitCore + 0x0086916c )	
0x000000022062a308	(UIKitCore + 0x00869308 )	
0x0000000220645068	(UIKitCore + 0x00884068 )	
0x0000000220655574	(UIKitCore + 0x00894574 )	
0x00000002207c66a8	(UIKitCore + 0x00a056a8 )	
0x00000002206554b4	(UIKitCore + 0x008944b4 )	
0x0000000220653a30	(UIKitCore + 0x00892a30 )	
0x00000002200d5794	(UIKitCore + 0x00314794 )	
0x00000002200dbff4	(UIKitCore + 0x0031aff4 )	
0x00000002200dc42c	(UIKitCore + 0x0031b42c )	
0x00000002200dd0ac	(UIKitCore + 0x0031c0ac )	
0x0000000220b82b30	(UIKitCore + 0x00dc1b30 )	
0x00000002207c7adc	(UIKitCore + 0x00a06adc )	
0x000000022079db58	(UIKitCore + 0x009dcb58 )	
0x000000022079e144	(UIKitCore + 0x009dd144 )	
0x00000001f80137b0	(QuartzCore + 0x0014d7b0 )	
0x00000001f3464480	(libdispatch.dylib + 0x00061480 )	
0x00000001f3443b40	(libdispatch.dylib + 0x00040b40 )	
0x00000001f39ba1b8	(CoreFoundation + 0x000ac1b8 )	
0x00000001f39b5080	(CoreFoundation + 0x000a7080 )	
0x00000001f39b45b4	(CoreFoundation + 0x000a65b4 )	
0x00000001f5c25580	(GraphicsServices + 0x0000b580 )	
0x00000002201267a8	(UIKitCore + 0x003657a8 )	
0x00000001026e1a10	(Chrome -chrome_exe_main.mm:54 )	main
0x00000001f3474c08	(libdyld.dylib + 0x00000c08 )	
 
Cc: kkhorimoto@chromium.org justincohen@chromium.org rohitrao@chromium.org
Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)
Assess if RBS

Cc: sczs@chromium.org
Labels: ReleaseBlock-Stable M-70
Owner: kkhorimoto@chromium.org
Since this only happens on a Beta release, only when deleting a section after the last item was deleting with the swipe gesture (Deleting using the toolbar works fine), and we're really close to submitting M69 I don't think this should be M69 RBS

kkhorimoto@ PTAL it seems there's an issue when removeEmptySections is called, though it might get fixed once iOS12 is not in beta
Status: Started (was: Assigned)
Labels: -M-70 M-71
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3133b88a72c61683057d7b1970f68d15b67c0c17

commit 3133b88a72c61683057d7b1970f68d15b67c0c17
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Thu Sep 06 19:18:52 2018

[iOS] Defer removing empty sections until editing is stopped.

The swipe to delete gesture for UITableView will throw an exception if
the deleted row's section is removed before the animation finishes.
This CL updates ReadingListTableViewController to defer removing empty
sections until self.tableView.editing is reset to NO at the end of the
swipe animation.

Bug:  877425 ,  877423 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I74e29b761fc8458e8bb9a6dbe643a73b00a8b9a4
Reviewed-on: https://chromium-review.googlesource.com/1198104
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589237}
[modify] https://crrev.com/3133b88a72c61683057d7b1970f68d15b67c0c17/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm

Labels: Merge-Approved-70
Status: Fixed (was: Started)
Labels: -Merge-Approved-70 Merge-Request-70
Status: Verified (was: Fixed)
Verified in 71.0.3545.0 Canary in iPhone 6s plus(iOS 12 beta 12) and iPad Air(iOS 12 beta 12)

Followed the steps mentioned in comment#0. App is not crashing on deleting the last reading list 
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 7

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 10

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/055c5c8c6483b3ce9cda5e51da6fc94fd8becd5f

commit 055c5c8c6483b3ce9cda5e51da6fc94fd8becd5f
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Mon Sep 10 18:22:23 2018

[iOS] Defer removing empty sections until editing is stopped.

The swipe to delete gesture for UITableView will throw an exception if
the deleted row's section is removed before the animation finishes.
This CL updates ReadingListTableViewController to defer removing empty
sections until self.tableView.editing is reset to NO at the end of the
swipe animation.

Bug:  877425 ,  877423 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I74e29b761fc8458e8bb9a6dbe643a73b00a8b9a4
Reviewed-on: https://chromium-review.googlesource.com/1198104
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589237}(cherry picked from commit 3133b88a72c61683057d7b1970f68d15b67c0c17)
Reviewed-on: https://chromium-review.googlesource.com/1217169
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#232}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/055c5c8c6483b3ce9cda5e51da6fc94fd8becd5f/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm

Verified in 71.0.3549.0 Canary in iPhone 6s plus(iOS 12 beta 12) and iPad Air(iOS 12 beta 12)

Followed the steps mentioned in comment#0. App is not crashing on deleting the last reading list entry.  Looks good.
Verified in 70.0.3538.17 Beta in iPhone 6s plus(iOS 12 beta 12) and iPad Air(iOS 12 beta 12)

Followed the steps mentioned in comment#0. App is not crashing on deleting the last reading list entry.  Looks good.

Link to video:
https://drive.google.com/file/d/1YX3KzEl6gulfHLs4tMBa6u30ok92sDSC/view?usp=sharing

Sign in to add a comment