New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 877424 link

Starred by 16 users
Status: Verified
Owner:
nikitapodguzov@chromium.org
Closed: Nov 2
Cc:
hendrich@chromium.org
ryutas@chromium.org
ultrotter@chromium.org
vkasatkin@google.com
poromov@chromium.org
steve...@chromium.org
█ rtillilie@chromium.org
isandrk@chromium.org
█ jayhlee@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

End user can overwrite PEAP identity and password set via policy

Project Member Reported by kaned@chromium.org, Aug 24 
Chrome Version: Tested on 67 and 68
Network info: 802.1x PEAP network pushed via policy from CPanel

Steps To Reproduce:
(1) From CPanel configure a WiFi network using PEAP and set the username and password (either statically if using a service account or to ${LOGIN_ID} and ${PASSWORD} as per https://support.google.com/chrome/a/answer/2634553?hl=en#top&add&wifi&thirdparty&variables&change&managecerts&autoconnect&
(2) Connect to the configured network from a managed Chromebook
(3) Disconnect from the network
(4) Change the identity and password fields and press save

Expected Result: End user cannot modify network set via policy

Actual Result: End user can modify settings pushed via policy. Once changed there is no way to enforce the account details from the policy

Impact: devices are either disconnected from the network (if the end user enters invalid credentials) or are authenticated but to the wrong account (if the user enters valid credentials).

Comment 1 by rogerta@chromium.org, Aug 27

Labels: Enterprise-Triaged
Owner: maxkirsch@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by maxkirsch@chromium.org, Aug 27

Owner: marcuskoehler@chromium.org

Comment 3 by marcuskoehler@chromium.org, Sep 4 

Validation:

(1) Configure WiFi from CPanel
(2) The user is indeed able to change the visible information of the pre-configured Wifi in the UI (e.g. username, certificate, etc.)
(3) However, this information is not used when connecting the Wifi. 

Fix:
Block the UI of managed networks so that the user is not able to change the information.

Blueprint: "manage other people" dialog
- "These settings are controlled by enterprise policy. Please contact your administrator for more information." notification at the top
- Add "managed setting" - icon to each setting.

Comment 4 by marcuskoehler@chromium.org, Sep 4

Blockedon: 872785
Labels: -Pri-1 Hotlist-GoodFirstBug Pri-3
Owner: ultrotter@chromium.org
Merge with 872785

Comment 5 by poromov@chromium.org, Sep 5

Cc: hendrich@chromium.org
This change should be pretty straightforward - remove "Configure" button if the network is managed.
+Alex in cc, who recently did network policy changes.

Comment 6 by hendrich@chromium.org, Sep 5 

In the merged bug crbug.com/872785 it says that this should be a noogler task.
Should I take care of this or leave it for a noogler?
This should be an easy one line fix. I can either do it now or help a noogler with this task later on.

Comment 7 by poromov@chromium.org, Sep 5

Cc: poromov@chromium.org ultrotter@chromium.org
Owner: nikitapodguzov@chromium.org
Alex, we'd like this one to be a noogler task, just asking for your feedback in case we are going to do something wrong :)

Comment 8 by hendrich@chromium.org, Sep 5 

Ok, I can help with that :)
Just ping me on chat or come by my desk if you need any help.

Comment 9 by isandrk@chromium.org, Sep 10

Cc: isandrk@chromium.org

Comment 10 by hendrich@chromium.org, Sep 12 

Apparently, simply disabling the UI for policy configured networks is not enough, since the policy might also have "recommended" values. For these we only suggest values, but the user should still be able to change them.
So for policies without the "recommended" field, we can just disable this UI, for policies with "recommended" we would still have to show the UI and disable everything except the recommended values. This should still be a good noogler task, though.

See bug  crbug.com/873775  for "recommended" policy values.

Comment 11 by poromov@chromium.org, Sep 12 

Good that we don't have "recommended" for usual policies - otherwise we'd have such problems all around the OS.
However, it's interesting for this case - does configuration of a network on CPanel lead to "recommended" values for identity or not?

Comment 12 by steve...@chromium.org, Sep 12

Cc: steve...@chromium.org
Labels: -Pri-3 Pri-2
Upping the priority on this since this was a regression and oversight in the new Settings based network config UI.

For policy enforced or recommended preferences, we automatically show an "enterprise" icon and (if enforced) disable the control. See https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/policy/ for details. This includes a cr-policy-network-indicator element which is designed to work with ONC properties and which we use correctly in the "details" page, but not in the elements used in network_config.html, specifically network-config-select and network-password-input. There are also a few cr-input elements that should be decorated with a policy indicator and disabled when enforced.

This is not going to be a trivial undertaking, but a lot of the tricky bits have been done. Please let me know if you have any questions.

Comment 13 by steve...@chromium.org, Sep 12

Cc: ryutas@chromium.org jayhlee@chromium.org
 Issue 874715  has been merged into this issue.

Comment 14 by hendrich@chromium.org, Sep 14 

@stevenjb: some more implementation questions before we start implementing this:

1) Looking at network_config.js we already have |networkProperties| and |configProperties|. To determine editability for each individual input, we would simply get a |managedProperties| from networkingPrivate.getManagedProperties then?
2) We would set the input fields disable/enabled state depending on the propertie's UserEditable/DeviceEditable
3) We would add a cr-policy-network-indicator to the right of each input field with the associated property from |managedProperties| (similar to https://drive.google.com/file/d/14BRo9vfhC5NKLy7-0h6HKKM_CImlOuQK/view)
4) network-password-input already has an icon on its right-hand side (show/hide password). How should the behavior be here? Add two icons? If the password value is not recommended, I would simply display the policy indicator. If the password value is recommended or not from policy, I would leave the password field as it is right now (only one icon for show/hide value). WDYT?
5) We would basically create/edit these new elements:
-network-config-policy-select
-network-config-policy-password
-network-config-policy-input

Comment 15 by hendrich@chromium.org, Sep 14 

follow up to previous comment:

6) If the network is configured via yaps and no value is set as recommended, should we completely hide this UI (e.g. hide the "Configure" button)?

Comment 16 by steve...@chromium.org, Sep 14 

1. Yes, we should use getManagedProperties in network_config.js instead of getProperties. There are helpers in cr_onc.js for extracting property values from managed property dictionaries.

2. Correct. That behavior should get built into <network-password-input> and <network-config-select>. Also, we should add a wrapper for cr-input. See <network-property-list> for an example. (The layout will be different for config fields, but the elements should be the same).

3. Yes, we can use the same layout for the indicators.

4. Agreed. I think we can always either show the policy indicator or the "eye" (policy indicator only when enforced).

5. I would omit 'policy' from the names of these and always include the indicator (i.e. modify the existing 'select' and 'password' elements and add <network-config-input>). <cr-policy-network-indicator> has logic to show or hide the icon and to set the correct tooltip, based on the managed 'property' object.

Comment 17 by steve...@chromium.org, Sep 14 

6. We should probably add logic to check isNetworkPolicyEnforced() (see cr_policy_network_behavior.js) for the appropriate set of properties and if they are all true, disable the 'Configure' button. (In this case disabling is probably better than hiding because it makes it clear that that the UI is disabled, not missing). We might also want to add a message or a tooltip, "This network is configured by your administrator", similar to IDS_SETTINGS_INTERNET_ADD_CONNECTION_NOT_ALLOWED.

Comment 18 by hendrich@chromium.org, Sep 20

Cc: rtillilie@chromium.org vkasatkin@google.com
 Issue 850925  has been merged into this issue.

Comment 19 by vkasatkin@google.com, Oct 5

Labels: Hotlist-Enterprise
Hi Team, any news on this issue?

Comment 20 by hendrich@chromium.org, Oct 6

Blockedon: -872785
Regarding this UI bug: We have two CLs in review:
-https://chromium-review.googlesource.com/c/chromium/src/+/1251447 (almost done)
-https://chromium-review.googlesource.com/c/chromium/src/+/1261701 (done)

Regarding recommended values: see  crbug.com/873775
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6516c5894d655d132c3e8669ab25029ad55912b1

commit 6516c5894d655d132c3e8669ab25029ad55912b1
Author: Nikita Podguzov <nikitapodguzov@chromium.org>
Date: Sat Oct 06 17:30:00 2018

Disable network 'configure' button if the network is enforced by policy.

Bug:  877424 
Change-Id: Ic55f4396247a60181bc7e007b2c2b50830ac9ffc
Reviewed-on: https://chromium-review.googlesource.com/c/1261701
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Cr-Commit-Position: refs/heads/master@{#597436}
[modify] https://crrev.com/6516c5894d655d132c3e8669ab25029ad55912b1/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/6516c5894d655d132c3e8669ab25029ad55912b1/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/6516c5894d655d132c3e8669ab25029ad55912b1/ui/webui/resources/cr_elements/policy/cr_policy_network_behavior.js
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad41842d831d80255165240e96594f959c21a976

commit ad41842d831d80255165240e96594f959c21a976
Author: Nikita Podguzov <nikitapodguzov@chromium.org>
Date: Mon Oct 15 09:39:10 2018

Fix the typo in getting active value of managed property function.

There is no "DeviceSetting" field in ManagedProperty, so it should be replaced with "SharedSetting".

Bug:  877424 
Change-Id: I09254246be27ead01a43aa79a648a12d3382daeb
Reviewed-on: https://chromium-review.googlesource.com/c/1277790
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Cr-Commit-Position: refs/heads/master@{#599601}
[modify] https://crrev.com/ad41842d831d80255165240e96594f959c21a976/ui/webui/resources/cr_elements/chromeos/network/cr_onc_types.js
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43116fdd290fd13d324df39e20d3825f5851ca1a

commit 43116fdd290fd13d324df39e20d3825f5851ca1a
Author: Nikita Podguzov <nikitapodguzov@chromium.org>
Date: Thu Oct 18 12:13:43 2018

Disable editing managed network config fields.

* Disable network configuration field if the field is enforced by policy.
* Add policy network indicator if the field is controlled by policy.

Bug:  877424 
Change-Id: Icfdb6d7fb3deb09696b6d2edce27d3c9851043a2
Reviewed-on: https://chromium-review.googlesource.com/c/1251447
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600735}
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/chrome/test/data/webui/chromeos/cr_onc_strings.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/chrome/test/data/webui/chromeos/fake_networking_private.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/chrome/test/data/webui/cr_components/network_config_test.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/BUILD.gn
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_apnlist.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_config.js
[add] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_config_element_behavior.html
[add] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_config_element_behavior.js
[add] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_config_input.html
[add] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_config_input.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_config_select.html
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_config_select.js
[add] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_config_toggle.html
[add] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_config_toggle.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_password_input.html
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_password_input.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_components/chromeos/network/network_proxy.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_elements/chromeos/network/cr_onc_types.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.js
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.html
[modify] https://crrev.com/43116fdd290fd13d324df39e20d3825f5851ca1a/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.js

Comment 24 by nikitapodguzov@chromium.org, Oct 18

Status: Fixed (was: Assigned)
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3

commit ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3
Author: Joe Downing <joedow@chromium.org>
Date: Thu Oct 18 16:29:30 2018

Revert "Disable editing managed network config fields."

This reverts commit 43116fdd290fd13d324df39e20d3825f5851ca1a.

Reason for revert: Causing multiple failures on the linux-chromeos-dbg builders:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932319379574593136/+/steps/browser_tests/0/logs/CrSettingsInternetDetailPageTest.InternetDetailPage/0

Original change's description:
> Disable editing managed network config fields.
> 
> * Disable network configuration field if the field is enforced by policy.
> * Add policy network indicator if the field is controlled by policy.
> 
> Bug:  877424 
> Change-Id: Icfdb6d7fb3deb09696b6d2edce27d3c9851043a2
> Reviewed-on: https://chromium-review.googlesource.com/c/1251447
> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600735}

TBR=stevenjb@chromium.org,hendrich@chromium.org,nikitapodguzov@google.com

Change-Id: Ib787c57ca39873750807076e09b5a2b50ed7230b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  877424 
Reviewed-on: https://chromium-review.googlesource.com/c/1288898
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600791}
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/chrome/test/data/webui/chromeos/cr_onc_strings.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/chrome/test/data/webui/chromeos/fake_networking_private.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/chrome/test/data/webui/cr_components/network_config_test.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_components/chromeos/network/BUILD.gn
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_components/chromeos/network/network_apnlist.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_components/chromeos/network/network_config.js
[delete] https://crrev.com/c3c83fe9271240d3b6501b80ed90b6c4067e46ea/ui/webui/resources/cr_components/chromeos/network/network_config_element_behavior.html
[delete] https://crrev.com/c3c83fe9271240d3b6501b80ed90b6c4067e46ea/ui/webui/resources/cr_components/chromeos/network/network_config_element_behavior.js
[delete] https://crrev.com/c3c83fe9271240d3b6501b80ed90b6c4067e46ea/ui/webui/resources/cr_components/chromeos/network/network_config_input.html
[delete] https://crrev.com/c3c83fe9271240d3b6501b80ed90b6c4067e46ea/ui/webui/resources/cr_components/chromeos/network/network_config_input.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_components/chromeos/network/network_config_select.html
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_components/chromeos/network/network_config_select.js
[delete] https://crrev.com/c3c83fe9271240d3b6501b80ed90b6c4067e46ea/ui/webui/resources/cr_components/chromeos/network/network_config_toggle.html
[delete] https://crrev.com/c3c83fe9271240d3b6501b80ed90b6c4067e46ea/ui/webui/resources/cr_components/chromeos/network/network_config_toggle.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_components/chromeos/network/network_password_input.html
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_components/chromeos/network/network_password_input.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_components/chromeos/network/network_proxy.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_elements/chromeos/network/cr_onc_types.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.js
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.html
[modify] https://crrev.com/ab5288ecaaaeb91f71b1ff43b8e5aa15d3fc1cb3/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.js

Comment 26 by nikitapodguzov@chromium.org, Oct 19

Status: Started (was: Fixed)
Project Member

Comment 27 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4

commit 7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4
Author: Nikita Podguzov <nikitapodguzov@chromium.org>
Date: Mon Oct 22 10:12:59 2018

Reland "Disable editing managed network config fields."

This is a reland of 43116fdd290fd13d324df39e20d3825f5851ca1a

Original change's description:
> Disable editing managed network config fields.
> 
> * Disable network configuration field if the field is enforced by policy.
> * Add policy network indicator if the field is controlled by policy.
> 
> Bug:  877424 
> Change-Id: Icfdb6d7fb3deb09696b6d2edce27d3c9851043a2
> Reviewed-on: https://chromium-review.googlesource.com/c/1251447
> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600735}

Bug:  877424 
Change-Id: I48473017b8656504de789f2cad9d0fabd89fcec7
Reviewed-on: https://chromium-review.googlesource.com/c/1290914
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Cr-Commit-Position: refs/heads/master@{#601515}
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/chrome/test/data/webui/chromeos/cr_onc_strings.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/chrome/test/data/webui/chromeos/fake_networking_private.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/chrome/test/data/webui/cr_components/network_config_test.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/BUILD.gn
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_apnlist.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_config.js
[add] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_config_element_behavior.html
[add] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_config_element_behavior.js
[add] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_config_input.html
[add] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_config_input.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_config_select.html
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_config_select.js
[add] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_config_toggle.html
[add] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_config_toggle.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_password_input.html
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_password_input.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/chromeos/network/network_proxy.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_components/cr_components_resources.grdp
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_elements/chromeos/network/cr_onc_types.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.js
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.html
[modify] https://crrev.com/7d7cede0ece3fed218e5a3aafdc9571b9fbc16c4/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.js

Comment 28 by hendrich@google.com, Oct 23

Status: Fixed (was: Started)

Comment 29 by chchakrapani@google.com, Oct 31

Status: Assigned (was: Fixed)
User able to edit the "Identity" and "Password" after disconnecting the admin configured network via cpanel.

UserPolicy of the configured network:
{
      "GUID": "{da326ba8-4cbd-498a-b87a-f764979101d9}",
      "Name": "PEAPNetwork",
      "ProxySettings": {
         "Type": "Direct"
      },
      "Type": "WiFi",
      "WiFi": {
         "AutoConnect": false,
         "EAP": {
            "AnonymousIdentity": "PEAP",
            "Identity": "CrOS",
            "Inner": "MSCHAPv2",
            "Outer": "PEAP",
            "Password": "********",
            "Recommended": [ "AnonymousIdentity", "Identity", "Password" ],
            "SaveCredentials": true,
            "UseSystemCAs": false
         },
         "HiddenSSID": false,
         "SSID": "CrOS_WPA2_LinksysE3000N_5GHz",
         "Security": "WPA-EAP"
      }
   }

Attached logs and screenshots.

Google Chrome: 72.0.3593.0
Platform: 11210.0.0 kevin

Please take a look and confirm the behavior.
Screenshot 2018-10-31 at 13.36.23.png
192 KB View Download
Screenshot 2018-10-31 at 13.36.34.png
189 KB View Download
Screenshot 2018-10-31 at 13.36.51.png
237 KB View Download
debug-logs_20181031-133733.tgz
976 KB Download

Comment 30 by nikitapodguzov@chromium.org, Nov 2 

@chchakrapani: It's intended behavior since the given user policy has "Identity" and "Password" fields as recommended, that means user can change it from given values if he wants to.

Comment 31 by chchakrapani@google.com, Nov 2

Status: Verified (was: Assigned)
Thank you. Closing the issue as verified.
►

Sign in to add a comment